Kris Avi
b7154f811f
Fixed #24128 -- Made admindocs TemplateDetailView respect template_loaders.
...
Co-Authored-By: Author: Alexander Lazarević <laza@e11bits.com>
2024-01-29 10:28:00 +01:00
David Smith
1df8983aa3
Refs #35058 -- Added support for measured geometries to GDAL LineString.
2024-01-29 08:44:42 +01:00
David Smith
2005530920
Refs #35058 -- Made centroid available on all geometry types.
...
Centroid is available on all geometry types since GDAL 1.8.0.
Previously it was restricted to Polygon.
https://gdal.org/doxygen/classOGRGeometry.html#a91787f669b2a148169667e270e7e40df
2024-01-28 14:40:19 +01:00
Mariusz Felisiak
305757aec1
Applied Black's 2024 stable style.
...
https://github.com/psf/black/releases/tag/24.1.0
2024-01-26 12:45:07 +01:00
David Smith
3f6d939c62
Refs #35058 -- Added support for measured geometries to GDAL Point.
...
Co-authored-by: Nick Pope <nick@nickpope.me.uk>
2024-01-25 08:59:16 +01:00
Baptiste Mispelon
a702a0773d
Added test for the sendtestemail command when no recipients are given.
2024-01-24 15:02:42 -03:00
Marijke Luttekes
e412d85b46
Fixed #35115 -- Made admin's footer render in <footer> tag.
2024-01-24 14:11:54 +01:00
David Smith
f4c5973464
Refs #35058 -- Deprecated OGRGeometry.coord_dim setter.
...
Reflecting a change in the underlying GDAL library (since GDAL 2.1)
using coord_dim to set a geometries dimensions is deprecated in favor
of set_3d().
2024-01-23 05:37:59 +01:00
David Smith
1c3a9b9f96
Added more WKT and WKB tests.
2024-01-22 10:40:32 +01:00
Mariusz Felisiak
4879907223
Fixed #35127 -- Made Model.full_clean() ignore GeneratedFields.
...
Thanks Claude Paroz for the report.
Regression in f333e3513e
.
2024-01-19 08:55:50 +01:00
Mariusz Felisiak
51967b56c4
Corrected forms imports in forms_tests/tests/test_forms.py.
2024-01-18 12:20:19 +01:00
David Smith
cfacd69ab8
Refs #35058 -- Added is_3d and set_3d() to OGRGeometry.
2024-01-18 10:48:40 +01:00
Amir Karimi
27a3eee721
Fixed #31700 -- Made makemigrations command display meaningful symbols for each operation.
2024-01-17 14:00:02 +01:00
Alexis Athlani
c7e986fc9f
Fixed #35117 -- Added support for the hectare unit in Area.
2024-01-16 20:31:46 +01:00
Simon Charette
0fcee1676c
Fixed #35111 -- Fixed compilation of DateField __in/__range rhs on SQLite and MySQL.
...
Also removed tests that ensured that adapt_(date)timefield backend
operations where able to deal with expressions when it's not the case
for any other adapt methods.
2024-01-16 08:34:14 +01:00
Simon Charette
561f770415
Refs #22288 -- Corrected __range lookup test names.
2024-01-16 08:34:06 +01:00
Aivars Kalvans
f92641a636
Fixed #28344 -- Allowed customizing queryset in Model.refresh_from_db()/arefresh_from_db().
...
The from_queryset parameter can be used to:
- use a custom Manager
- lock the row until the end of transaction
- select additional related objects
2024-01-15 10:55:14 +01:00
Simon Charette
92d6cff6a2
Fixed #35028 -- Disabled server-side bindings for named cursors on psycopg >= 3.
...
While we provide a `cursor_factory` based on the value of the
`server_side_bindings` option to `psycopg.Connection` it is ignored by
the `cursor` method when `name` is specified for `QuerySet.iterator()`
usage and it causes the usage of `psycopg.ServerCursor` which performs
server-side bindings.
Since the ORM doesn't generates SQL that is suitable for server-side
bindings when dealing with parametrized expressions a specialized cursor
must be used to allow server-side cursors to be used with client-side
bindings.
Thanks Richard Ebeling for the report.
Thanks Florian Apolloner and Daniele Varrazzo for reviews.
2024-01-12 21:40:18 +01:00
nessita
02eaee1209
Added test ensuring that validate_password is used in AdminPasswordChangeForm.
...
Co-authored-by: Fabian Braun <fsbraun@gmx.de>
2024-01-12 17:27:55 -03:00
Florian Apolloner
6e520d9537
Avoided nested transactions in SkippingClassTestCase.
2024-01-12 09:57:52 +01:00
Alexander Lazarević
4787972c94
Refs #28404 -- Made displaying property values in admin respect non-None empty values.
2024-01-11 12:47:06 +01:00
Nick Pope
40b5b1596f
Fixed #35100 -- Reworked GeoIP2 database initialization.
2024-01-11 12:01:35 +01:00
Nick Pope
f50184a84b
Fixed #35092 -- Exposed extra fields for GeoIP2.country() and GeoIP2.city() responses.
2024-01-10 12:09:44 +01:00
Alexander Lazarević
9b02ad91ea
Fixed #28404 -- Made displaying values in admin respect Field's empty_values.
2024-01-10 08:34:25 +01:00
Tim Graham
ecd3071dac
Fixed #35097 -- Tested parse_datetime() with bare date.
...
Regression test for behavior change in
f35ab74752
.
2024-01-09 14:08:03 -03:00
Alexander Lazarević
1b0a8991ae
Refs #28404 -- Split test_null_display_for_field() test.
2024-01-09 11:44:16 +01:00
Sarah Boyce
a9094ec1f4
Fixed #35087 -- Reallowed filtering against foreign keys not listed in ModelAdmin.list_filters.
...
Regression in f80669d2f5
.
2024-01-08 09:21:54 +01:00
Nick Pope
cc56c22a24
Fixed #35091 -- Allowed GeoIP2 querying using IPv4Address/IPv6Address.
2024-01-07 08:15:40 +01:00
David Smith
45f59d0eab
Fixed #35086 -- Added support for BoundedCircle on Spatialite 5.1+.
...
Spatialite 5.1 added support for BoundingCircle
(GEOSMinimumBoundingCircle). GEOS 3.7 is required which is lower than
Django's currently supported minmum of 3.8.
https://groups.google.com/g/spatialite-users/c/hAJ2SgitN4M
https://www.gaia-gis.it/gaia-sins/spatialite-sql-5.1.0.html
2024-01-05 11:55:44 +01:00
Mariusz Felisiak
0c5456ef37
Used enterClassContext() where appropriate.
2024-01-04 05:55:29 +01:00
David Wobrock
8fb0be3500
Fixed #33277 -- Disallowed database connections in threads in SimpleTestCase.
2024-01-03 13:02:26 +01:00
Nick Pope
45f778eded
Fixed #35075 -- Added deduplicate_items parameter to BTreeIndex.
2024-01-02 12:55:12 +01:00
Salvo Polizzi
3915d4c70d
Fixed #35060 -- Deprecated passing positional arguments to Model.save()/asave().
2024-01-02 08:42:33 +01:00
Nick Pope
c72001644f
Updated DatabaseFeatures.bare_select_suffix on Oracle 23c.
...
https://docs.oracle.com/en/database/oracle/oracle-database/23/nfcoa/application-development.html#GUID-4EB70EB9-4EE3-4FE2-99C4-86F7AAC60F12
2024-01-01 10:59:16 +01:00
Mariusz Felisiak
d88ec42bd0
Used addCleanup() in tests where appropriate.
2023-12-31 10:01:31 +01:00
Paul Bailey
9d52e0720f
Fixed #35051 -- Prevented runserver from removing non-zero Content-Length for HEAD requests.
2023-12-31 08:32:37 +01:00
Nick Pope
94b6f101f7
Fixed #29049 -- Added slicing notation to F expressions.
...
Co-authored-by: Priyansh Saxena <askpriyansh@gmail.com>
Co-authored-by: Niclas Olofsson <n@niclasolofsson.se>
Co-authored-by: David Smith <smithdc@gmail.com>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: Abhinav Yadav <abhinav.sny.2002@gmail.com>
2023-12-30 08:24:30 +01:00
Simon Charette
e16d0c176e
Fixed #35064 -- Fixed Window(order_by) crash with DecimalFields on SQLite.
...
This avoids cast of Window(order_by) for DecimalFields on SQLite.
This was achieved by piggy-backing ExpressionList which already
implements a specialized as_sqlite() method to override the inherited
behaviour of Func through SQLiteNumericMixin.
Refs #31723 .
Thanks Quoates for the report.
2023-12-29 09:07:31 +01:00
Christian Clauss
ebf9320838
Removed unnecessary list() calls on sorted().
2023-12-28 10:58:37 +01:00
Mariusz Felisiak
751d732a38
Fixed #35056 -- Fixed system check crash on reverse m2m relations with related_name in ModelAdmin.filter_horizontal/vertical.
...
Thanks Thomas Feldmann for the report.
Regression in 107865780a
.
2023-12-27 20:36:22 +01:00
David Smith
21b0b23a67
Refs #35058 -- Made OGRGeomType aware of additional WKB geometry types.
...
This commit increases OGRGeomType's knowledge of WKB types and allows
for improved error messages when Django doesn't yet have a corresponding
class to wrap a given type.
2023-12-27 11:40:28 +01:00
Natalia
7c26dbf6ef
Improved cache.tests.FileBasedCacheTests.test_touch to avoid flakiness due to slow file system access.
2023-12-27 06:05:33 +01:00
David Smith
2a2481f5a2
Refs #35058 -- Added __repr__() to OGRGeomType.
2023-12-26 21:23:33 +01:00
David Wobrock
14917c9ae2
Fixed #35050 -- Fixed prefixing field names in FilteredRelation().
...
Thanks Mark Zorn for the report.
Regression in 59f4754704
.
2023-12-23 17:35:13 +01:00
David Wobrock
7045661069
Fixed #35022 -- Fixed RenameIndex() crash on unnamed indexes if exists unique constraint on the same fields.
2023-12-22 12:47:17 +01:00
Nicolas Lupien
2bf46c3825
Fixed #34658 -- Added SimpleTestCase.assertNotInHTML().
2023-12-22 08:27:59 +01:00
David Smith
c709a748ce
Fixed #35049 -- Dropped support for GDAL 2.4.
2023-12-20 21:44:11 +01:00
Claude Paroz
08306bad57
Fixed #34411 -- Updated GDAL API to handle vector DataSource's.
...
Co-authored-by: David Smith <smithdc@gmail.com>
2023-12-18 09:42:04 +01:00
Simon Charette
77278929c8
Fixed #35042 -- Fixed a count() crash on combined queries.
...
Regression in 59bea9efd2
.
Thanks Marcin for the report.
2023-12-16 20:19:24 +01:00
Simon Charette
eea4f92f9a
Refs #34013 -- Registered instance lookups as documented in tests.
2023-12-16 20:05:36 +01:00
Eliana Rosselli
c83c639ba0
Fixed #34909 -- Associated links in admin navigation sidebar with row descriptions.
...
This adds aria-describedby attribute to the models' links in the admin
navigation sidebar.
Thanks Thibaud Colas for the review.
Co-authored-by: Dara Silvera <dsilvera@octobot.io>
2023-12-15 21:01:00 +01:00
Tobias Krönke
4b7fe146cc
Refs #32503 -- Added assertion for effective default value when altering TextField to non-nullable with default.
2023-12-14 10:53:37 +01:00
Mariusz Felisiak
8fa7c2ae88
Improved test coverage for django.contrib.sessions.backends.base.SessionBase.
2023-12-13 12:51:58 +01:00
Nick Pope
a93375e8ab
Fixed #34305 -- Changed GeoIP2 tests to use MaxMind test databases.
...
GEOIP_SETTINGS is removed from the global scope as this prevents
modifications to the settings using @override_settings in tests.
Additional improvements now that we have stable test databases include:
- Made testing more comprehensive and improved coverage
- Patched socket.gethostbyname() for whole test case
- Added testing of non-free GeoIP2 databases
Co-authored-by: Tom Forbes <tom@tomforb.es>
2023-12-12 09:58:26 +01:00
Simon Charette
b0ad41198b
Fixed #34013 -- Added QuerySet.order_by() support for annotation transforms.
...
Thanks Eugene Morozov and Ben Nace for the reports.
2023-12-12 05:51:33 +01:00
Mariusz Felisiak
fcf95e5927
Fixed #35018 -- Fixed migrations crash on GeneratedField with BooleanField as output_field on Oracle < 23c.
...
Thanks Václav Řehák for the report.
Regression in f333e3513e
.
2023-12-12 05:39:11 +01:00
Sarah Boyce
b287af5dc9
Fixed #35019 -- Fixed save() on models with both GeneratedFields and ForeignKeys.
...
Thanks Deb Kumar Das for the report.
Regression in f333e3513e
.
2023-12-08 09:46:11 +01:00
Avaneesh Kumar
705b1702bd
Fixed #34742 -- Made CommonMiddleware raise APPEND_SLASH RuntimeError on DELETE requests.
2023-12-08 05:56:36 +01:00
Mariusz Felisiak
5b3b791e90
Fixed #35024 -- Fixed model instance creation crash on GeneratedField.output_field with backend converters.
...
Regression in d9de74141e
.
This is a long standing issue, however it caused a crash of
GeneratedFields for all output fields that have backend-specific
converters when the RETURNING clause is not supported
(MySQL and SQLite < 3.35).
That's why severity was exacerbated.
2023-12-07 20:50:18 +01:00
Nick Pope
af6e7e3de8
Refs #34986 -- Fixed backends.postgresql.test_server_side_cursors.ServerSideCursorsPostgres tests for PyPy.
2023-12-07 09:43:20 +01:00
Nick Pope
958a590e53
Refs #34986 -- Used non-binary build of psycopg for PyPy.
2023-12-07 09:21:37 +01:00
Sarah Boyce
f80669d2f5
Fixed #35020 -- Fixed ModelAdmin.lookup_allowed() for non-autofield primary keys.
...
Thanks Joshua Goodwin for the report.
Regression in 45ecd9acca
.
2023-12-07 06:16:35 +01:00
Nick Pope
fb9216382a
Refs #34986 -- Moved garbage_collect() helper to django.test.utils.
2023-12-06 09:26:11 +01:00
Nick Pope
1c3614e306
Refs #34986 -- Avoided implementation-specific unpickleable types.
...
The implementation of some core types differ between CPython and PyPy
and this may affect the way that pickling works such that errors are
raised in differing locations in the interpreter or not at all.
Use our own custom non-pickleable type instead to avoid these quirks.
2023-12-06 09:23:35 +01:00
Nick Pope
2c6e4a29b0
Fixed typo in tests/backends/postgresql/test_server_side_cursors.py.
2023-12-06 09:17:49 +01:00
Nick Pope
07f9f9960c
Deprecated django.contrib.gis.geoip2.GeoIP2.open().
2023-12-05 08:21:19 +01:00
yushanfans2233
14b0132e5e
Fixed #34830 -- Added request to bad_request/csrf_failure view template contexts.
2023-12-04 10:52:06 +01:00
Peter Thomassen
54cb1a7e16
Fixed #35002 -- Made UniqueConstraints with fields respect nulls_distinct.
...
Regression in 595a2abb58
.
2023-12-03 12:30:45 +01:00
Nick Pope
0f83133a35
Made GeoIP2.__del__() close all databases.
2023-12-01 13:55:45 +01:00
Nick Pope
b925fefd7d
Deprecated django.contrib.gis.geoip2.GeoIP2.coords().
...
The `ordering` argument is undocumented and of limited use, so this is
effectively the same as `GeoIP2.lon_lat()`.
2023-12-01 08:38:42 +01:00
Sarah Boyce
af2fd36815
Refs #34995 -- Made Selenium tests more robust for admin_views and admin_widgets suites.
...
Depending on screen sizes, the selenium tests that would "click" or interact
with an element outside the scope of the visible window would produce test
failures (raising ElementNotInteractableException in CI runs).
This branch switches those to using ActionChains, which ensures that the click
(or other interaction) is performed only after successfully completing the
move to the relevant element.
Co-authored-by: Tom Carrick <tom@carrick.eu>
2023-11-30 10:39:10 -03:00
Mariusz Felisiak
37fc832a54
Fixed #35006 -- Fixed migrations crash when altering Meta.db_table_comment on SQLite.
...
Thanks Юрий for the report.
Regression in 78f163a4fb
.
2023-11-30 10:10:27 +01:00
Nick Pope
06c5cb1284
Refs #34986 -- Removed redundant CustomChoicesTests.test_timezone_unsupported().
...
This test relied on the behavior of subclassing `datetime.timezone`
which is not permitted by the C-extension version of CPython's
`datetime` module. This restriction isn't enforced by the pure
Python version, nor by PyPy.
See https://github.com/python/cpython/issues/112451
It's not critical, and doesn't test any Django behavior, so just
remove it.
2023-11-29 21:12:53 +01:00
nessita
134cde8415
Removed hard-coded expected results in SeleniumTests.test_select_multiple test.
...
This ensures that both tests, test_select() and test_select_multiple(),
use analogous calculations for the expected amount of results, and for
the iteration when pressing "arrow down" and waiting for the ajax call
to complete.
2023-11-28 23:06:17 +01:00
Mariusz Felisiak
a4931cd75a
Refs #34380 -- Added FORMS_URLFIELD_ASSUME_HTTPS transitional setting.
...
This allows early adoption of the new default "https".
2023-11-28 20:04:21 +01:00
David Smith
76280b4f4d
Refs #21442 -- Increased test coverage of requests.
2023-11-28 09:33:59 +01:00
Nick Pope
baf705f34a
Refs #34986 -- Fixed some test assertions for PyPy.
...
These failures were due to minor inconsistencies or implementation
differences between CPython and PyPy.
2023-11-28 06:19:38 +01:00
Nick Pope
6089230d3e
Refs #34986 -- Fixed mocking in utils_tests.test_http.HttpDateProcessingTests.test_parsing_rfc850.
...
Mocking in the `datetime` module can be tricky. In CPython the datetime
C module is used, but PyPy uses a pure Python implementation. This
caused issues with the prior approach to mocking `datetime.datetime`.
See https://docs.python.org/3/library/unittest.mock-examples.html#partial-mocking
2023-11-28 06:19:38 +01:00
Aman Pandey
0fcd72bc48
Fixed #34633 -- Made create() method of reverse many-to-one managers clear prefetch_related() cache.
2023-11-28 05:46:04 +01:00
Tom Carrick
729266c6f2
Fixed #34982 -- Fixed admin's read-only password widget and help texts alignment for tablet screen size.
...
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2023-11-27 14:42:25 -03:00
Nick Pope
9baaf89eed
Refs #34986 -- Added django.utils.version.PYPY.
2023-11-27 10:37:29 +01:00
Nathaniel Conroy
0257426fe1
Fixed #34992 -- Fixed DatabaseFeatures.allows_group_by_selected_pks on MariaDB with ONLY_FULL_GROUP_BY sql mode.
...
Regression in 041551d716
.
2023-11-27 09:20:10 +01:00
Simon Charette
978680db22
Refs #34925 -- Avoided altering passed by reference refresh_from_db(fields).
...
Follow up to b0ec87b857
.
2023-11-25 17:01:14 +01:00
trontelj
b0ec87b857
Fixed #34925 -- Prevented Model.refresh_from_db() from mutating list of fields.
2023-11-24 13:42:40 +01:00
Standa Opichal
1c6e8ec4ed
Fixed #34968 -- Made multipart parsing of headers raise an error on too long headers.
...
This also allow customizing the maximum size of headers via
MAX_TOTAL_HEADER_SIZE.
2023-11-24 12:06:54 +01:00
Nick Pope
5e28cd3f2c
Fixed #34983 -- Deprecated django.utils.itercompat.is_iterable().
2023-11-24 12:06:29 +01:00
Parth Verma
eabfa2d0e3
Fixed #34818 -- Prevented GenericIPAddressField from mutating error messages.
...
Co-authored-by: Parth Verma <parth.verma@gmail.com>
2023-11-24 05:46:17 +01:00
Prashant Pandey
a8adb6aa6c
Fixed #26827 -- Improved ModelState error message when relations refer model classes.
2023-11-23 21:17:44 +01:00
Tom Carrick
a03593967f
Fixed #14611 -- Added query_params argument to RequestFactory and Client classes.
2023-11-23 10:39:29 +01:00
Simon Charette
e76cc93b01
Fixed #34987 -- Fixed queryset crash when mixing aggregate and window annotations.
...
Regression in f387d024fc
.
Just like `OrderByList` the `ExpressionList` expression used to wrap
`Window.partition_by` must implement `get_group_by_cols` to ensure the
necessary grouping when mixing window expressions with aggregate
annotations is performed against the partition members and not the
partition expression itself.
This is necessary because while `partition_by` is implemented as
a source expression of `Window` it's actually a fragment of the WINDOW
expression at the SQL level and thus it should result in a group by its
members and not the sum of them.
Thanks ElRoberto538 for the report.
2023-11-23 06:09:08 +01:00
Mariusz Felisiak
101a85a5a0
Fixed #34985 -- Fixed GeneratedFields.contribute_to_class() crash when apps are not populated.
...
Thanks Paolo Melchiorre for the report.
Regression in f333e3513e
.
2023-11-22 13:41:32 +01:00
Sarah Boyce
828082dad9
Fixed #34984 -- Skipped GeneratedFields when remaking tables on SQLite.
...
Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.t
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
2023-11-22 12:29:14 +01:00
Mariusz Felisiak
584fc49ac4
Refs #34900 -- Skipped Selenium requirement on daily builds for Python 3.13.
...
Selenium required trio and trio required cffi on Windows.
2023-11-22 09:51:22 +01:00
Michał Górny
09b4a4e2c1
Fixed runtests.py crash on PyPy.
...
The gc.set_threshold() call was made conditional to non-PyPy
implementations. The method is not available in PyPy3, and GC is much
less aggressive there, so the adjustment probably is not necessary.
2023-11-21 08:07:16 +01:00
Mariusz Felisiak
6af83d2ee6
Refs #34900 -- Skipped argon2-cffi requirement on daily builds for Python 3.13.
2023-11-21 07:54:18 +01:00
Mariusz Felisiak
00a950f923
Refs #34900 -- Added Python 3.13 to daily builds.
2023-11-20 19:52:56 +01:00
Mariusz Felisiak
19c4052f98
Refs #34118 -- Used Python 3.12 for GitHub actions.
2023-11-18 16:58:25 +01:00
Simon Charette
15cb3c262a
Refs #34975 -- Complemented rhs filtering aggregations for __in lookup.
...
While this isn't a regression it's clear that similar logic should be
applied when dealing with lists of expressions passed as a lookup value.
2023-11-18 15:40:52 +01:00
Simon Charette
7530cf3900
Fixed #34975 -- Fixed crash of conditional aggregate() over aggregations.
...
Adjustments made to solve_lookup_type to defer the resolving of
references for summarized aggregates failed to account for similar
requirements for lookup values which can also reference annotations
through Aggregate.filter.
Regression in b181cae2e3
.
Refs #25307 .
Thanks Sergey Nesterenko for the report.
2023-11-18 15:38:04 +01:00
David Smith
eec7e9ba89
Refs #32819 -- Established relationship between form fieldsets and their help text.
...
This adds aria-describedby for widgets rendered in a fieldset such as
radios. aria-describedby for these widgets is added to the <fieldset>
element rather than each <input>.
2023-11-17 08:12:36 +01:00
David Smith
557fa51837
Refs #32819 -- Added aria-describedby test for widgets with custom id.
2023-11-17 05:43:33 +01:00
Mariusz Felisiak
c705625ebf
Refs #34944 -- Propagated system checks for GeneratedField.output_field.
2023-11-14 20:22:07 +01:00
Mariusz Felisiak
5875f03ce6
Fixed #34944 -- Made GeneratedField.output_field required.
...
Regression in f333e3513e
.
2023-11-14 20:22:07 +01:00
Mariusz Felisiak
de4884b114
Reverted "Refs #30446 , Refs #34944 -- Fixed crash when adding GeneratedField with string Value()."
...
This reverts commit 8b1acc0440
.
2023-11-14 15:45:43 +01:00
Simon Charette
6364b6ee10
Fixed #34955 -- Made Concat() use || operator on PostgreSQL.
...
This also avoids casting string based expressions in Concat() on
PostgreSQL.
2023-11-14 10:56:20 +01:00
jedidiah
bdf30b952c
Fixed #34919 -- Added scope attribute to admindocs model templates.
2023-11-14 05:34:56 +01:00
Andrew Cordery
ad41f1c53a
Fixed #34952 -- Copied dir list when processing locale folders to avoid missing entries during os.walk traversal.
...
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2023-11-13 14:03:48 -03:00
David Sanders
b863c5ffde
Fixed #34967 -- Fixed queryset crash when grouping by constants on SQLite < 3.39.
...
On SQLite < 3.39, this forces a GROUP BY clause with a HAVING clause
when no grouping is specified.
Co-authored-by: Simon Charette <charette.s@gmail.com>
2023-11-13 12:01:40 +01:00
nessita
1b56b24f81
Fixed #34958 -- Fixed isolation of messages_tests.tests.TestLevelTags.test_lazy.
2023-11-13 09:35:57 +01:00
Adam Johnson
f7389c4b07
Fixed #34457 -- Restored output for makemigrations --check.
...
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2023-11-09 10:03:19 -03:00
Simon Charette
8b1acc0440
Refs #30446 , Refs #34944 -- Fixed crash when adding GeneratedField with string Value().
...
This should allow smarter output_field inferring in functions dealing
with text expressions.
Regression in f333e3513e
.
2023-11-08 15:48:15 +03:00
Natalia
5f2f12f61c
Reverted "Fixed #34830 -- Added request to csrf_failure view's template context."
...
This reverts commit 535f7b5c6c
.
2023-11-08 08:50:55 -03:00
Prakhar
535f7b5c6c
Fixed #34830 -- Added request to csrf_failure view's template context.
...
Co-authored-by: nessita <124304+nessita@users.noreply.github.com>
2023-11-07 09:09:39 -03:00
Simon Charette
8a28e983df
Fixed #34946 -- Preserved db_default on combined default field addition.
...
Regression in 7414704e88
.
2023-11-07 13:32:34 +03:00
David Sanders
797957fb48
Fixed #34936 -- Fixed migration crash for DecimalField with db_default on SQLite.
...
CAST() must be wrapped in parentheses to be recognized as an expression on SQLite.
Regression in 7414704e88
.
2023-11-02 17:57:39 +01:00
David Sanders
1944f490f9
Refs #34936 -- Added test for altering DecimalField with db_default to non-nullable.
2023-11-02 17:57:34 +01:00
Tim Graham
208870b612
Refs #31300 -- Allowed testing GeneratedField without collation.
...
CockroachDB and Snowflake don't support it.
2023-11-02 13:58:46 +01:00
Antoine Cheneau
65c283be16
Fixed #34927 -- Fixed admin system check for inlines with foreign keys to proxy models.
...
Follow up to 0e8be73812
.
2023-11-02 10:42:20 +01:00
Mariusz Felisiak
05ba4130ee
Fixed CVE-2023-46695 -- Fixed potential DoS in UsernameField on Windows.
...
Thanks MProgrammer (https://hackerone.com/mprogrammer ) for the report.
2023-11-01 06:10:30 +01:00
Akash Kumar Sen
40b3975e7d
Fixed #34462 -- Made admin log actions in bulk.
...
This also deprecates ModelAdmin.log_deletion() and
LogEntryManager.log_action().
2023-10-31 18:06:44 +01:00
Akash Kumar Sen
45e0c5892f
Refs #34462 -- Moved ModelAdmin.log_deletion() test to a separate test case.
2023-10-31 10:36:23 +01:00
Ben Cail
523fed1d2f
Fixed #32106 -- Preserved HTTP_HOST in test Client when following redirects.
...
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
2023-10-31 05:29:43 +01:00
Sarah Boyce
e4d012ca05
Refs #29850 -- Added exclusion support to window frames.
2023-10-30 12:04:55 +01:00
Tom Carrick
34b411762b
Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.
...
Regression in f3f9d03edf
(4.2) and
8ed25d65ea
(5.0).
2023-10-30 07:37:40 +01:00
Sarah Boyce
6375cee490
Refs #29850 -- Added RowRange support for positive integer start and negative integer end.
2023-10-28 15:16:07 +02:00
ksg
a6c7db1d1d
Fixed #34943 -- Made EmailValidator.__eq__() ignore domain_allowlist ordering.
...
Signed-off-by: ksg97031 <ksg97031@gmail.com>
2023-10-28 14:35:25 +02:00
Mariusz Felisiak
cf57e220a9
Fixed isolation of DatabaseWrapperLoggingTests.test_commit_debug_log().
2023-10-27 09:05:09 +02:00
Tom Carrick
e67d3580ed
Fixed #10941 -- Added {% query_string %} template tag.
2023-10-26 09:57:21 +02:00
sindre
64060d1c17
Fixed #34904 -- Prevented mutating sent emails from outbox in locmem email backend.
2023-10-25 08:52:31 +02:00
Mariusz Felisiak
311718feb5
Fixed #34923 -- Avoided initializing LEVEL_TAGS when importing django.contrib.messages.
...
Regression in b7fe36ad37
.
Thanks James Gillard for the report.
2023-10-24 14:09:31 -03:00
ksg97031
d22ba07630
Fixed #34920 -- Made FileExtensionValidator.__eq__() ignore allowed_extensions ordering.
2023-10-24 05:31:11 +02:00
Nick Pope
171f91d9ef
Fixed #34899 -- Added blank choice to forms' callable choices lazily.
2023-10-23 13:44:23 -03:00
Nick Pope
74afcee234
Refs #34899 -- Extracted Field.flatchoices to flatten_choices helper function.
...
Co-authored-by: Natalia Bidart <124304+nessita@users.noreply.github.com>
2023-10-23 13:44:23 -03:00
Nick Pope
07fa79ef2b
Refs #31262 -- Added __eq__() and __getitem__() to BaseChoiceIterator.
...
This makes it easier to work with lazy iterators used for callables,
etc. when extracting items or comparing to lists, e.g. during testing.
Also added `BaseChoiceIterator.__iter__()` to make it clear that
subclasses must implement this and added `__all__` to the module.
Co-authored-by: Adam Johnson <me@adamj.eu>
Co-authored-by: Natalia Bidart <124304+nessita@users.noreply.github.com>
2023-10-23 13:44:16 -03:00
David Sanders
b5311ee232
Fixed #34921 -- Fixed crash of warning for unbound naive datetimes.
2023-10-22 14:26:38 +02:00
laserhyena
21382e2743
Fixed #34911 -- Corrected HTML heading levels on admindocs' main page.
2023-10-20 05:44:55 +02:00
ontowhee
89d2ae257b
Fixed #34905 -- Corrected admin's main content element rendered in <main> tag.
...
Regression in 91e617c743
.
Thanks Tom Carrick for the report.
2023-10-19 17:25:50 +02:00
Sarah Boyce
71a813a72c
Made SeleniumTests.test_select_multiple less flaky by improving Selenium waits.
2023-10-19 16:01:52 +02:00
Sarah Boyce
be56c982c0
Refs #34043 -- Added --screenshots option to runtests.py and selenium tests.
2023-10-18 06:14:40 +02:00
Sarah Boyce
f6629ee2c9
Refs #34043 -- Added context managers to SeleniumTestCase for changing window size.
2023-10-16 10:36:26 +02:00
Mariusz Felisiak
20b7aac7ca
Refs #34900 , Refs #34118 -- Updated assertion in test_skip_class_unless_db_feature() test on Python 3.12.1+.
...
Python 3.12.1+ no longer includes skipped tests in the number of
running tests. Check out:
https://github.com/python/cpython/issues/110890#issuecomment-1763458686
https://github.com/python/cpython/pull/106588
2023-10-16 06:27:27 +02:00
Simon Charette
3b4a571275
Fixed #34798 -- Fixed QuerySet.aggregate() crash when referencing expressions containing subqueries.
...
Regression in 59bea9efd2
,
complements e5c844d6f2
.
Refs #28477 , #34551 .
Thanks Haldun Komsuoglu for the report.
2023-10-16 05:37:30 +02:00
Mariusz Felisiak
9fd3a0ffc8
Refs #34840 -- Fixed test_validate_nullable_textfield_with_isnull_true() on databases that don's support table check constraints.
...
Thanks Tim Graham for the report.
2023-10-12 20:01:44 +02:00
Mariana
fc62e17778
Fixed #12241 -- Preserved query strings when using "Save and continue/add another" in admin.
...
Co-authored-by: Grady Yu <gradyy@users.noreply.github.com>
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Co-authored-by: Matthew Newton <matthewn@berkeley.edu>
2023-10-11 11:00:25 +02:00
Mariusz Felisiak
6e369f36f2
Refs #34882 -- Fixed GISFunctionsTests.test_asgeojson_option_0() test on Oracle.
...
This uses an example with the same precision for all databases.
Follow up to 96e7a752b6
.
2023-10-11 10:58:10 +02:00
Mariusz Felisiak
296b75a3c0
Fixed #34889 -- Fixed get_prefetch_queryset() fallback in prefetch_one_level().
...
Thanks Matt Westcott for the report.
Regression in cac94dd8aa
.
2023-10-06 20:18:41 +02:00
Denis Rouzaud
96e7a752b6
Fixed #34882 -- Fixed no options in AsGeoJSON() for geometries in non-default CRS.
2023-10-06 05:25:32 +02:00
Simon Charette
ea596a52d9
Refs #33482 -- Fixed QuerySet selecting and filtering againts Exists() with empty queryset.
...
Thanks Tobias Bengfort for the report.
2023-10-04 21:30:50 +02:00
pieterck
0989cf13e7
Fixed #34759 -- Confirmed support for SpatiaLite 5.1.
...
Thanks The Epic Dev for helping with tests.
2023-10-04 19:58:27 +02:00
Natalia
17b51094d7
Fixed CVE-2023-43665 -- Mitigated potential DoS in django.utils.text.Truncator when truncating HTML text.
...
Thanks Wenchao Li of Alibaba Group for the report.
2023-10-04 09:22:26 -03:00
Chinmoy Chakraborty
1dae65dc63
Fixed #34657 -- Made assert(Not)Contains/assertInHTML display haystacks in error messages.
2023-10-03 10:44:36 +02:00
Mariusz Felisiak
679212a47a
Refs #34657 -- Made msg_prefix handling in assertURLEqual()/assertInHTML consistent with other assertions.
...
Co-authored-by: Chinmoy Chakraborty <chinmoy12c@gmail.com>
2023-10-03 09:25:48 +02:00
Carlton Gibson
35bbb2c9c0
Fixed #34883 -- Allowed template tags to set extra data on templates.
...
By setting a value in the `parser.extra_data` mapping, template tags
pass additional data out of the parsing context.
Any extra data set is exposed on the template via the matching
`.extra_data` attribute.
Library authors should use a key to namespace extra data. The 'django'
namespace is reserved for internal use.
2023-10-02 16:16:43 +02:00
Chinmoy Chakraborty
e99c7d8847
Refs #34657 -- Made assertInHTML() use unparsed needle in error messages.
2023-09-29 09:52:39 +02:00
Mariusz Felisiak
6ad0dbc8d9
Refs #15667 -- Added resetting default renderer when FORM_RENDERER is changed.
2023-09-29 08:54:13 +02:00
Dan Jacob
fe835c2355
Fixed #34878 -- Fixed autoreloader crash when FORM_RENDERER is set to TemplatesSetting.
...
Regression in 439242c594
.
2023-09-29 06:01:04 +02:00
Paolo Melchiorre
e7e8eb44a3
Fixed #34877 -- Fixed migrations crash when adding GeneratedField with output_field with params.
2023-09-28 05:50:42 +02:00
Mariusz Felisiak
f9e9526800
Fixed #34873 -- Added QuerySet.explain() support for GENERIC_PLAN option on PostgreSQL 16+.
2023-09-26 12:05:26 +02:00
lstaana
357365a64e
Fixed #34835 -- Made admin's changelist filters render in <nav> tag.
2023-09-26 08:45:07 +02:00
David Sanders
a5905b164d
Fixed #34825 -- Avoided setting unused connections when initializing parallel workers.
2023-09-25 10:14:55 +02:00
David Sanders
4f2ae0644d
Fixed #34849 -- Avoided raising RuntimeWarning about import-time queries when apps are reinitialized with test tools.
...
Regression in fbd16438f4
.
2023-09-25 08:17:03 +02:00
Paolo Melchiorre
574ee4023e
Fixed #34861 -- Fixed crash when adding GeneratedField with some expressions.
...
Co-authored-by: Simon Charette <charette.s@gmail.com>
2023-09-22 21:01:54 +02:00
Arian
51d703a27f
Fixed #34823 -- Fixed assertTemplateUsed() context manager crash on unnamed templates.
2023-09-22 10:51:10 +02:00
toan
4de31ec680
Fixed #34858 -- Corrected resolving output_field for PositiveIntegerField.
...
Regression in 40b8a6174f
.
2023-09-22 09:33:50 +02:00
Natalia
d797243663
Fixed #34848 -- Ignored i18n_catalog.js file when building Django's translations catalog.
2023-09-22 08:20:08 +02:00
Tim Graham
b0788a0918
Fixed JSONField's test_deep_distinct for DatabaseFeatures.nulls_order_largest=False.
...
Failure observed on CockroachDB.
2023-09-22 06:25:17 +02:00
Mariusz Felisiak
779cd28acb
Fixed #34840 -- Avoided casting string base fields on PostgreSQL.
...
Thanks Alex Vandiver for the report.
Regression in 09ffc5c121
.
2023-09-22 06:01:11 +02:00
Mariusz Felisiak
2c6ebb65c9
Fixed #34851 -- Dropped support for PostgreSQL 12 and PostGIS 2.5.
2023-09-20 13:45:51 +02:00
Lily Foote
45078a204b
Defined PASSWORD_HASHERS for auth_tests.test_views.ChangelistTests.
...
auth_tests.test_views.ChangelistTests.test_view_user_password_is_readonly
depends on the password hasher having the three components algorithm,
salt and hash.
The default password hasher (PBKDF2PasswordHasher) has an extra
iterations component, breaking the test.
2023-09-20 05:35:49 +02:00
Mariusz Felisiak
3623a0c079
Fixed #34850 -- Dropped support for MariaDB 10.4.
2023-09-19 15:06:05 +02:00
Mariusz Felisiak
8af3ae4ad9
Isolated test models for GeneratedFields.
...
Test regression in f333e3513e
.
2023-09-19 08:09:03 +02:00
Mariusz Felisiak
0e560edf32
Increased the default PBKDF2 iterations for Django 5.1.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
caf87b4d42
Advanced deprecation warnings for Django 5.1.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
f72f420f17
Refs #26029 -- Removed DEFAULT_FILE_STORAGE and STATICFILES_STORAGE settings.
...
This also removes django.core.files.storage.get_storage_class().
Per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
3a3e737694
Refs #33199 -- Removed support for passing positional arguments to Signer/TimestampSigner.
...
Per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
5e4c1793b7
Refs #33308 -- Removed support for passing encoded JSON string literals to JSONField & co.
...
Per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
69af3bea99
Refs #33990 -- Removed TransactionTestCase.assertQuerysetEqual() per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
c35fd9e275
Refs #33990 -- Removed SimpleTestCase.assertFormsetError() per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
7433237664
Refs #33924 -- Removed BaseGeometryWidget.map_height/map_width attributes per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
04eb1b4567
Refs #33872 -- Removed django.contrib.postgres.fields.CIText/CICharField/CIEmailField/CITextField.
...
Per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
6e4e5523a8
Refs #33691 -- Removed insecure password hashers per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
14ef92fa9e
Refs #33864 -- Removed length_is template filter per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
2abf417c81
Refs #27236 -- Removed Meta.index_together per deprecation timeline.
2023-09-18 22:12:40 +02:00
Mariusz Felisiak
00e1879610
Refs #33764 -- Removed BaseUserManager.make_random_password() per deprecation timeline.
2023-09-18 22:12:40 +02:00
Clément Escolano
cac94dd8aa
Fixed #33651 -- Added support for prefetching GenericForeignKey.
...
Co-authored-by: revanthgss <revanthgss@almabase.com>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2023-09-18 13:23:21 +02:00
Ryanwalker277
225328efd9
Fixed #31558 -- Added support for boolean attribute on properties in ModelAdmin.list_display.
2023-09-16 20:54:26 +02:00
Paolo Melchiorre
2f1ab16be5
Fixed #34842 -- Fixed ModelAdmin.readonly_fields crash with GeneratedFields.
2023-09-16 20:13:02 +02:00
Sarah Abderemane
814e7bc220
Fixed #34832 -- Made admin's header content render in <header> tag.
...
Header tag was changed to <header> get the landmark banner for
accessibility.
2023-09-15 05:36:43 +02:00
Paolo Melchiorre
68d769e691
Fixed #34838 -- Corrected output_field of resolved columns for GeneratedFields.
...
Thanks Simon Charette for the implementation idea.
2023-09-14 21:17:12 +02:00
Lemuel Sta Ana
969ecb8236
Fixed #34834 -- Added role="search" to the admin changelist search form.
2023-09-14 20:35:48 +02:00
Natalia
691f70c477
Fixed #24561 -- Added support for callables on model fields' choices.
2023-09-14 10:15:33 -03:00
Sarah Abderemane
91e617c743
Fixed #34833 -- Made admin's main content render in <main> tag.
2023-09-14 05:41:31 +02:00
Nick Pope
f92e68c30a
Fixed #34822 -- Added support for serializing functions decorated with functools.lru_cache in migrations.
...
`@functools.cache` and `@functools.lru_cache` return an object of type
`functools._lru_cache_wrapper` which prevented the migrations serializer from
working. Simply using the existing `FunctionTypeSerializer` for this additional
type works as expected.
2023-09-13 15:57:18 -03:00
Nick Pope
c131949e3e
Refs #34822 -- Added tests for serializing decorated functions in migrations.
...
Functions decorated with a decorator that is properly wrapped, e.g. by
using `@functools.wraps`, are already supported.
2023-09-13 15:39:56 -03:00
Mariusz Felisiak
0e540fca13
Corrected logger in CsrfViewMiddlewareTestMixin.test_ensures_csrf_cookie_no_logging().
...
Logger was changed in 55fec16aaf
.
2023-09-13 13:49:01 +02:00
Ben Lomax
74f7deec9e
Refs #31949 -- Made make_middleware_decorator to work with async functions.
2023-09-13 11:41:01 +02:00
Ben Lomax
059cb0dbc9
Added more tests for decorators.
2023-09-13 10:16:01 +02:00
Nick Pope
fe19b33e2f
Modernized enumeration helpers on Python 3.11+.
...
- use @enum.property
https://docs.python.org/3/library/enum.html#enum.property
- use @enum.nonmember
Using @property on an enum class does not yield the expected result.
do_not_call_in_templates attribute works because a @property instance
is truthy. We can make this a literal True value as expected by using
@enum.nonmember in Python 3.11+.
https://docs.python.org/3/library/enum.html#enum.nonmember
- used enum.IntEnum/StrEnum
Python 3.11+ has ReprEnum which uses int.__str__() and str.__str__()
for __str__() in the `IntEnum` and `StrEnum` subclasses. We can emulate
that for Python < 3.11.
https://docs.python.org/3/library/enum.html#enum.ReprEnum
https://docs.python.org/3/library/enum.html#enum.IntEnum
https://docs.python.org/3/library/enum.html#enum.StrEnum
2023-09-13 08:30:21 +02:00
Nick Pope
e15174983a
Renamed ChoicesMeta to ChoicesType.
...
This also uses enum.EnumType for Python 3.11+ as Python 3.11 renamed
EnumMeta to EnumType. While the former is still available as an alias
of the latter for now, let's prefer the canonical name for this.
Check out https://docs.python.org/3/library/enum.html#enum.EnumType
2023-09-12 11:51:01 +02:00
Sam Toyer
64cea1e48f
Fixed #34752 -- Fixed handling ASGI http.disconnect for streaming responses.
2023-09-11 19:53:21 +02:00
Mariusz Felisiak
a7c73b944f
Fixed #34821 -- Prevented DEFAULT_FILE_STORAGE/STATICFILES_STORAGE settings from mutating the main STORAGES.
...
Regression in 6b965c6000
.
2023-09-11 13:04:32 +02:00
donghao
938170008e
Fixed #34824 -- Prevented unnecessary AlterField when ForeignObject.from_fields/to_fields is not a tuple.
2023-09-11 08:46:43 +02:00
Yves Weissig
369b498219
Fixed #34642 -- Added File.open() support for *args and **kwargs.
2023-09-11 06:07:47 +02:00
donghao
71820c9f91
Fixed #34820 -- Fixed migrations crash when changing a ForeignObject field.
2023-09-09 22:15:14 +02:00
Oguzhan Akan
e41f9f9450
Fixed #34816 -- Fixed GenericForeignKey crash when checking cache for primary keys with different types.
2023-09-08 08:47:11 +02:00
Jacob Walls
1ab2cf7994
Fixed #34810 -- Measured test coverage on django-admin commands.
2023-09-07 15:47:26 -03:00
Maxime Toussaint
254df3a3bb
Fixed #34791 -- Fixed incorrect Prefetch()'s cache for singly related objects.
...
Changed the cache name used for singly related objects to be the
to_attr parameter passed to a Prefetch object. This fixes issues with
checking if values have already been fetched in cases where the Field
already has some prefetched value, but not for the same model attr.
2023-09-07 12:56:08 +02:00
Jeremy Nauta
f333e3513e
Fixed #31300 -- Added GeneratedField model field.
...
Thanks Adam Johnson and Paolo Melchiorre for reviews.
Co-Authored-By: Lily Foote <code@lilyf.org>
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2023-09-07 06:19:08 +02:00
François Freitag
cafe7266ee
Fixed #34730 -- Added django.contrib.messages.test.MessagesTestMixin.assertMessages().
2023-09-05 11:55:37 +02:00
Jacob Walls
6c6606aa01
Refs #34233 -- Bumped minimum supported version of docutils to 0.19.
2023-09-04 22:30:45 +02:00
Mariusz Felisiak
3f41d6d629
Fixed CVE-2023-41164 -- Fixed potential DoS in django.utils.encoding.uri_to_iri().
...
Thanks MProgrammer (https://hackerone.com/mprogrammer ) for the report.
Co-authored-by: nessita <124304+nessita@users.noreply.github.com>
2023-09-04 11:58:37 +02:00
Jacob Walls
bcd80de8b5
Fixed #34778 -- Avoided importing modules in startapp/startproject.
2023-09-01 13:24:05 +02:00
Sulabh Katila
9a9620dda6
Fixed #34768 -- Avoided initializing colorama on non-Windows platforms.
2023-09-01 11:26:29 +02:00
willzhao
9cc0d7f7f8
Fixed #34803 -- Fixed queryset crash when filtering againts deeply nested OuterRef annotations.
...
Thanks Pierre-Nicolas Rigal for the report.
Regression in c67ea79aa9
.
2023-09-01 10:44:20 +02:00
Mariusz Felisiak
c74a6fad54
Refs #32355 -- Removed unnecessary getattr() call.
...
options.test_name_patterns is always defined.
Follow up to ec0ff40631
.
2023-08-31 10:27:32 +02:00
Bruno Alla
4c4536f744
Refs #34712 -- Added system check for staticfiles storage in STORAGES setting.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: Natalia Bidart <124304+nessita@users.noreply.github.com>
2023-08-31 08:21:44 +02:00
David Smith
74b5074174
Fixed #34210 -- Added unittest's durations option to the test runner.
2023-08-31 07:14:58 +02:00
David Smith
27b399d235
Fixed #34547 -- Deprecated DatabaseOperations.field_cast_sql().
2023-08-31 06:18:07 +02:00
Nick Pope
500e01073a
Fixed #31262 -- Added support for mappings on model fields and ChoiceField's choices.
2023-08-30 22:57:40 -03:00
John Whitman
68a8996bdf
Fixed #34799 -- Made MySQL introspection skip cross-database relations.
2023-08-30 12:46:15 +02:00
Olivier Tabone
3f8dbe267d
Fixed #34757 -- Added support for following redirects to AsyncClient.
2023-08-30 06:12:25 +02:00
sarahboyce
f6ed2c36dd
Fixed #34787 -- Fixed autoreloader crash when run from installed script on Windows.
2023-08-28 12:57:14 +02:00
Mariusz Felisiak
11920e7795
Fixed #34709 -- Raised BadRequest for non-UTF-8 requests with the application/x-www-form-urlencoded content type.
...
Thanks Eki Xu for the report.
2023-08-25 21:27:22 +02:00
François Freitag
b7fe36ad37
Refs #34730 -- Made Message importable from django.contrib.messages.
2023-08-25 06:55:12 +02:00
François Freitag
7bba231b67
Refs #24121 -- Added __repr__() to Message.
2023-08-24 11:06:13 +02:00
David Sanders
76c3e310dd
Fixed #34744 -- Prevented recreation of migration for constraints with a dict_keys.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2023-08-23 11:42:18 +02:00
Mariusz Felisiak
dd45d5223b
Fixed ResourceWarning from unclosed SQLite connection on Python 3.13+.
...
- backends.sqlite.tests.ThreadSharing.test_database_sharing_in_threads
- backends.tests.ThreadTests.test_default_connection_thread_local:
on SQLite, close() doesn't explicitly close in-memory connections.
- servers.tests.LiveServerInMemoryDatabaseLockTest
- test_runner.tests.SQLiteInMemoryTestDbs.test_transaction_support
Check out https://github.com/python/cpython/pull/108015 .
2023-08-23 09:09:23 +02:00
konsti
48a1929ca0
Removed unnecessary trailing commas in tests.
2023-08-22 12:42:57 +02:00
Natalia
f1c0a3baf7
Added tests for model field's choices iterator/iterable values.
2023-08-22 05:55:23 +02:00
Florian Zimmermann
fbd16438f4
Fixed #33143 -- Raised RuntimeWarning when performing import-time queries.
2023-08-21 13:44:25 +02:00
Mariusz Felisiak
4c85d94bc0
Fixed utils_tests.test_lazyobject.SimpleLazyObjectPickleTestCase.
...
SimpleLazyObjectPickleTestCase executes database queries so it must
inherit from django.test.TestCase.
2023-08-20 16:09:07 +02:00
Juan Alvarez
517d3bb4dd
Fixed #34779 -- Avoided unnecessary selection of non-nullable m2m fields without natural keys during serialization.
...
By using `select_related(None)` instead of `select_related()`, the
unnecessary joins are completely avoided. Note that the current tests
already covers the change, when the field is not `null=True`.
Regression in f9936deed1
.
2023-08-19 10:29:43 +02:00
Mariusz Felisiak
6b965c6000
Fixed #34773 -- Fixed syncing DEFAULT_FILE_STORAGE/STATICFILES_STORAGE settings with STORAGES.
...
Thanks Petr Dlouhý for the report.
Bug in 32940d390a
.
2023-08-18 18:11:24 +02:00
Francesco Panico
59f4754704
Fixed #34362 -- Fixed FilteredRelation() crash on conditional expressions.
...
Thanks zhu for the report and Simon Charette for reviews.
2023-08-11 12:32:18 +02:00
Francesco Panico
1506f498fe
Fixed #34743 -- Fixed Meta.constraints validation crash when using pk.
...
Thanks Nwawel A Iroume for the report.
2023-08-11 08:51:29 +02:00
Jingbei Li
9946f0b0d9
Fixed #33817 -- Added support for python-oracledb and deprecated cx_Oracle.
2023-08-10 10:11:53 +02:00
Mariusz Felisiak
e69a9920e2
Fixed non-deterministic order in SubqueryTests.test_slice_subquery_and_query.
...
Slice on unordered subquery may be non-deterministic in some databases.
2023-08-10 05:33:13 +02:00
Mariusz Felisiak
80a5667c50
Refs #34233 -- Bumped required cx_Oracle to 8.3.
...
This bumps minimum supported versions of cx_Oracle to the first release
to support Python 3.10.
2023-08-09 12:41:47 +02:00
priyank.panchal
439242c594
Fixed #34692 -- Made autoreloader reset cached template loader for default renderer.
2023-08-09 09:09:52 +02:00
Mariana
e02fc58889
Fixed #34586 -- Made QuerySet.create() raise ValueError for reverse one-to-many relations.
2023-08-09 06:59:40 +02:00
Nick Pope
aa3cb3f372
Added IntegerField tests for checks for invalid choices.
2023-08-08 18:57:15 +02:00
Mateusz Więckowski
5aa4c0b675
Fixed #34542 -- Made createsuperuser handle required blank fields in non-interactive mode.
2023-08-08 09:26:28 +02:00
Olivier Tabone
0f3b1a783d
Fixed #34739 -- Added GEOSGeometry.equals_identical() method.
2023-08-05 18:23:38 +02:00
Mariusz Felisiak
0336aa6672
Fixed TransactionalTests.test_password_with_at_sign() isolation on Oracle.
2023-08-04 17:36:04 +02:00
Simon Charette
3434dbd39d
Fixed #34754 -- Fixed JSONField check constraints validation on NULL values.
...
The __isnull lookup of JSONField must special case
Value(None, JSONField()) left-hand-side in order to be coherent with
its convoluted null handling.
Since psycopg>=3 offers no way to pass a NULL::jsonb the issue is
resolved by optimizing IsNull(Value(None), True | False) to
True | False.
Regression in 5c23d9f0c3
.
Thanks Alexandre Collet for the report.
2023-08-04 10:14:03 +02:00
Mariusz Felisiak
2b582387d5
Fixed #34760 -- Dropped support for SQLite < 3.27.
2023-08-04 06:35:13 +02:00
Olivier Tabone
f46a6b2816
Fixed #34686 -- Added support for GEOS 3.12.
2023-08-04 05:53:29 +02:00
Mariusz Felisiak
b719688b21
Fixed #34761 -- Dropped support for MySQL < 8.0.11.
2023-08-03 18:54:29 +02:00
Mariusz Felisiak
9b9c805ced
Removed unneeded escapes in regexes.
...
Special characters lose their special meaning inside sets of characters.
"-" lose its special meaning if it's placed as the first or last
character.
Follow up to 7c6b66383d
.
2023-08-02 19:53:16 +02:00
Nick Pope
c77fbda7ce
Added more tests for django.http.request.split_domain_port().
2023-08-02 13:06:23 +02:00
Mariusz Felisiak
c9b9a52edc
Fixed #34750 -- Fixed QuerySet.count() when grouping by unused multi-valued annotations.
...
Thanks Toan Vuong for the report.
Thanks Simon Charette for the review.
Regression in 59bea9efd2
.
2023-08-01 16:16:28 +02:00
Gregor Jerše
10725a3187
Fixed #32820 -- Added aria-invalid="true" to fields with errors.
...
Co-authored-by: Demetris Stavrou <demestav@gmail.com>
Co-authored-by: David Smith <smithdc@gmail.com>
2023-08-01 06:08:04 +02:00
John Parton
fff14736f1
Fixed #34331 -- Added QuerySet.aiterator() support for prefetch_related().
2023-07-31 21:17:36 +02:00
nessita
1ad7761ee6
Refs #34655 -- Made cosmetic edits to RadioSelect tests.
...
Follow up to f9c5958b8f
.
2023-07-31 20:17:10 +02:00
Mariusz Felisiak
22b0b73c77
Fixed warnings per flake8 6.1.0.
2023-07-30 16:17:07 +02:00
Simon Charette
4087367ba8
Fixed #34748 -- Fixed queryset crash when grouping by a reference in a subquery.
...
Regression in dd68af62b2
.
Thanks Toan Vuong for the report.
2023-07-29 16:08:20 +02:00
Jakub Bagiński
f9c5958b8f
Fixed #34655 -- Increased radioselect's test coverage.
2023-07-28 09:18:07 -03:00
Nick Pope
89c8c2e831
Simplified call_command() calls.
2023-07-27 15:48:47 +02:00
Christopher Cave-Ayland
95e4d6b813
Fixed #34532 -- Made formset_factory() respect Form's default_renderer.
...
Co-authored-by: David Smith <smithdc@gmail.com>
2023-07-24 09:09:53 +02:00
Olivier Tabone
b9473cac65
Fixed #34714 -- Added aget_object_or_404()/aget_list_or_404() shortcuts.
2023-07-24 07:37:54 +02:00
devilsautumn
f05cc5e3d2
Refs #24686 -- Made AlterField operation a noop when renaming related model with db_table.
2023-07-22 20:13:42 +02:00
Michel Alexandre Salim
62b83889e0
Fixed #34731 , Refs #34118 -- Replaced assertEquals() with assertEqual() in test_condition_with_func_and_lookup_outside_relation_name().
...
Signed-off-by: Michel Alexandre Salim <salimma@fedoraproject.org>
2023-07-21 21:18:24 +02:00
Francesco Panico
e4a5527d1d
Refs #29789 -- Added more tests for FilteredRelation with condition outside of relation name.
2023-07-21 12:03:42 +02:00
Simon Charette
d7d80040c1
Made UniqueConstraint raise TypeError for type violations.
2023-07-19 21:46:20 +02:00
Simon Charette
595a2abb58
Fixed #34701 -- Added support for NULLS [NOT] DISTINCT on PostgreSQL 15+.
2023-07-19 21:42:27 +02:00
Simon Charette
68912e4f6f
Fixed #34717 -- Fixed QuerySet.aggregate() crash when referencing window functions.
...
Regression in 59bea9efd2
.
Refs #28477 .
Thanks younes-chaoui for the report.
2023-07-19 08:21:33 +02:00
Mariusz Felisiak
3109038992
Refs #33201 -- Avoided unnecessary queries when renaming models with db_table on SpatiaLite.
2023-07-18 14:08:47 +02:00
Nicolò Intrieri
e8252fc445
Fixed #34716 -- Fixed serialization of nested class methods in migrations.
...
Co-authored-by: Nicolò <nicolo.intrieri@spinforward.it>
2023-07-18 05:27:40 +02:00
Mariusz Felisiak
da2f8e8257
Refs #34118 -- Improved sanitize_address() error message for tuple with empty strings.
2023-07-17 11:03:36 +02:00
David Smith
1d0dfc0b92
Refs #30686 -- Moved Parser.SELF_CLOSING_TAGS to django.utils.html.VOID_ELEMENTS
2023-07-14 10:25:00 +02:00
Tushar
88a2de3c39
Fixed #34448 -- Doc'd and tested --no-obsolete option of makemessages.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2023-07-14 08:47:30 +02:00
Yury V. Zaytsev
02966a30dd
Fixed #34697 -- Fixed non-deterministic order of dependencies and sets/frozensets in migrations.
...
Co-authored-by: Dakota Hawkins <dakotahawkins@gmail.com>
2023-07-12 12:33:23 +02:00
Mariusz Felisiak
4afaeb14c2
Refs #30116 -- Simplified tests related with dictionary order.
...
Dicts preserve order since Python 3.6.
2023-07-12 11:06:59 +02:00
Sage Abdullah
3f73df44f2
Fixed #34705 -- Reallowed BoundField.as_widget()'s attrs argument to set aria-describedby.
...
Regression in 966ecdd482
.
2023-07-12 05:43:41 +02:00
Amir Karimi
d1855c4847
Fixed #34691 -- Added system check for unmatched angle brackets in path().
2023-07-11 11:59:27 +02:00
Mariusz Felisiak
c7276a9cb9
Refs #34695 -- Added tests for check for CSRF_FAILURE_VIEW signature with valid class-based view.
2023-07-11 10:46:34 +02:00
Thomas Chaumeny
89c7454dbd
Fixed #34698 -- Made QuerySet.bulk_create() retrieve primary keys when updating conflicts.
2023-07-10 13:17:28 +02:00
Ben Lomax
b7a17b0ea0
Refs #31949 -- Made @vary_on_(cookie/headers) decorators work with async functions.
2023-07-10 11:43:36 +02:00
Cauê Thenório
f7cfa48283
Fixed #34696 -- Updated selection counter in admin changelist on Chrome.
2023-07-10 10:09:07 +02:00
Ben Lomax
953f81e078
Refs #31949 -- Made @csrf_exempt decorator to work with async functions.
2023-07-10 07:55:02 +02:00
Andrew Northall
6d427288e4
Fixed #34688 -- Removed contrib.sitemaps.ping_google() and ping_google management command.
...
Thanks Joachim Jablon for the report.
Google has deprecated the sitemap ping endpoint, and will be removing
it in 6 months ~January 2024.
2023-07-10 05:59:35 +02:00
Mariusz Felisiak
2584783f46
Refs #9602 -- Moved AlreadyRegistered/NotRegistered exceptions to django.contrib.admin.exceptions.
2023-07-07 13:22:06 +02:00
Neeraj Kumar
eed096574f
Fixed #32210 -- Fixed model inlines with to_field that has a default.
2023-07-07 09:11:46 +02:00
Neeraj Kumar
b91d62cca0
Refs #24377 -- Added assertions for model inlines with primary key that has a default.
...
This ensures that a model field default is ignored.
2023-07-07 08:18:31 +02:00
Mariusz Felisiak
f64fd47a76
Fixed #9602 -- Added AdminSite.get_model_admin().
...
This allows retrieving an admin class for the given model class without
using internal attributes.
2023-07-07 08:06:01 +02:00
Simon Charette
d569c1dcfe
Fixed #34639 -- Reverted "Fixed #32682 -- Made admin changelist use Exists() instead of distinct() for preventing duplicates."
...
This reverts commit 1871182031
which
moved to using Exists() instead due to an overly strict
distinct().delete() check added in #32433 .
2023-07-07 07:08:28 +02:00
Simon Charette
28e2077148
Refs #32433 -- Reallowed calling QuerySet.delete() after distinct().
...
While values(*field_excluding_pk).distinct() and
distinct(*field_excluding_pk) can reduce the number of resulting rows
in a way that makes subsequent delete() calls ambiguous standalone
.distinct() calls cannot.
Since delete() already disallows chain usages with values() the only
case that needs to be handled, as originally reported, is when
DISTINCT ON is used via distinct(*fields).
Refs #32682 which had to resort to subqueries to prevent duplicates in
the admin and caused significant performance regressions on MySQL
(refs #34639 ).
This partly reverts 6307c3f1a1
.
2023-07-07 07:08:28 +02:00
Mariusz Felisiak
95cdf9dc66
Used AdminSite.is_registered() where appropriate.
2023-07-06 11:29:16 +02:00
Gregor Jerše
966ecdd482
Fixed #32819 -- Established relationship between form fields and their help text.
...
Thanks Nimra for the initial patch.
Thanks Natalia Bidart, Thibaud Colas, David Smith, and Mariusz Felisiak
for reviews.
2023-07-06 08:03:19 +02:00
sarahboyce
649262a406
Made some Selenium tests less flaky by adding explicit wait.
2023-07-05 09:45:50 +02:00
Mariusz Felisiak
42b4f81e6e
Fixed isolation of SeleniumTests.test_search_input_filtered_page() test.
...
Test crashed when the sidebar was not closed.
2023-07-04 13:34:08 +02:00
Sarah Boyce
968684aed4
Made SeleniumTests.test_updating_related_objects_updates_fk_selects_except_autocompletes() test less flaky by adding explicit Selenium wait.
2023-07-04 13:34:08 +02:00
davidolz
075e9c0a4d
Fixed typo in tests/admin_docs/models.py.
2023-07-03 10:47:41 +02:00
Mariusz Felisiak
ad0410ec4f
Fixed CVE-2023-36053 -- Prevented potential ReDoS in EmailValidator and URLValidator.
...
Thanks Seokchan Yoon for reports.
2023-07-03 08:16:55 +02:00
Mariusz Felisiak
7eeadc82c2
Fixed RelatedGeoModelTest.test_centroid_collect_filter().
2023-06-30 10:18:04 +02:00
sobolevn
5820fc4485
Fixed #34687 -- Made Apps.clear_cache() clear get_swappable_settings_name() cache.
2023-06-30 08:27:15 +02:00
Mariusz Felisiak
953f29f700
Fixed #34572 -- Added support for GDAL 3.7.
...
Co-authored-by: Michael Howitz <mh@gocept.com>
2023-06-30 06:03:08 +02:00
Akash Kumar Sen
a40b0103bc
Fixed #30382 -- Allowed specifying parent classes in force_insert of Model.save().
2023-06-29 21:52:52 +02:00
Mariusz Felisiak
601ffb0da3
Fixed #34685 -- Dropped support for GEOS 3.6 and 3.7.
2023-06-29 21:45:36 +02:00
Akash Kumar Sen
ce204bed7f
Refs #30382 -- Added more tests for using force_insert with model inheritance.
2023-06-29 11:49:32 +02:00