Commit Graph

32147 Commits

Author SHA1 Message Date
David Smith eec7e9ba89 Refs #32819 -- Established relationship between form fieldsets and their help text.
This adds aria-describedby for widgets rendered in a fieldset such as
radios. aria-describedby for these widgets is added to the <fieldset>
element rather than each <input>.
2023-11-17 08:12:36 +01:00
David Smith 557fa51837 Refs #32819 -- Added aria-describedby test for widgets with custom id. 2023-11-17 05:43:33 +01:00
David Smith 292f1ea90f Refs #32819 -- Used auto_id instead of id_for_label as unique identifier for the field.
`id_for_label` is blank for widgets with multiple inputs such as radios
and multiple checkboxes. Therefore , `help_text` for fields using these
widgets cannot currently be associated using `aria-describedby`.
`id_for_label` is being used as a guard to avoid incorrectly adding
`aria-describedby` to those widgets.

This change uses `auto_id` as the unique identified for the fields
`help_text`. A guard is added to avoid incorrectly adding
`aria-describedby` to inputs by checking the widget's `use_fieldset`
attribute. Fields rendered in a `<fieldset>` should have
`aria-describedby` added to the `<fieldset>` and not every `<input>`.
2023-11-16 12:23:42 +01:00
Markus Amalthea Magnuson 61c305f298 Fixed #34970 -- Clarified Password Validation docs regarding the password_changed callback. 2023-11-15 15:35:25 -03:00
Giannis Terzopoulos 36ed45d27c
Removed obsolete sentence in custom model field docs. 2023-11-15 13:48:45 +01:00
William Hayes 640283711e
Refs #33690 -- Added missing data-theme selector to example in theming support docs. 2023-11-15 05:26:44 +01:00
Mariusz Felisiak c705625ebf Refs #34944 -- Propagated system checks for GeneratedField.output_field. 2023-11-14 20:22:07 +01:00
Mariusz Felisiak 5875f03ce6 Fixed #34944 -- Made GeneratedField.output_field required.
Regression in f333e3513e.
2023-11-14 20:22:07 +01:00
Mariusz Felisiak de4884b114 Reverted "Refs #30446, Refs #34944 -- Fixed crash when adding GeneratedField with string Value()."
This reverts commit 8b1acc0440.
2023-11-14 15:45:43 +01:00
Simon Charette 6364b6ee10 Fixed #34955 -- Made Concat() use || operator on PostgreSQL.
This also avoids casting string based expressions in Concat() on
PostgreSQL.
2023-11-14 10:56:20 +01:00
jedidiah bdf30b952c Fixed #34919 -- Added scope attribute to admindocs model templates. 2023-11-14 05:34:56 +01:00
Andrew Cordery ad41f1c53a Fixed #34952 -- Copied dir list when processing locale folders to avoid missing entries during os.walk traversal.
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2023-11-13 14:03:48 -03:00
David Sanders b863c5ffde Fixed #34967 -- Fixed queryset crash when grouping by constants on SQLite < 3.39.
On SQLite < 3.39, this forces a GROUP BY clause with a HAVING clause
when no grouping is specified.

Co-authored-by: Simon Charette <charette.s@gmail.com>
2023-11-13 12:01:40 +01:00
nessita 1b56b24f81
Fixed #34958 -- Fixed isolation of messages_tests.tests.TestLevelTags.test_lazy. 2023-11-13 09:35:57 +01:00
Adam Johnson f7389c4b07 Fixed #34457 -- Restored output for makemigrations --check.
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2023-11-09 10:03:19 -03:00
Jacob Walls 427f0ed98d
Fixed typos in docs/ref/models/fields.txt. 2023-11-09 09:58:06 +03:00
Simon Charette 8b1acc0440 Refs #30446, Refs #34944 -- Fixed crash when adding GeneratedField with string Value().
This should allow smarter output_field inferring in functions dealing
with text expressions.

Regression in f333e3513e.
2023-11-08 15:48:15 +03:00
Natalia 5f2f12f61c Reverted "Fixed #34830 -- Added request to csrf_failure view's template context."
This reverts commit 535f7b5c6c.
2023-11-08 08:50:55 -03:00
Prakhar 535f7b5c6c Fixed #34830 -- Added request to csrf_failure view's template context.
Co-authored-by: nessita <124304+nessita@users.noreply.github.com>
2023-11-07 09:09:39 -03:00
Simon Charette 8a28e983df
Fixed #34946 -- Preserved db_default on combined default field addition.
Regression in 7414704e88.
2023-11-07 13:32:34 +03:00
Mariusz Felisiak 656192c2c9
Fixed #34941 -- Fixed fetching decimal db_defaults for DecimalFields on Oracle.
This is a long standing bug in bc91f27a86
that began manifesting in 7414704e88.
2023-11-03 16:28:04 +01:00
Mariusz Felisiak 7a09ba0962
Refs #34941 -- Skipped OperationTests.test_alter_field_change_nullable_to_decimal_database_default_not_null on Oracle. 2023-11-03 05:29:06 +01:00
David Sanders 797957fb48 Fixed #34936 -- Fixed migration crash for DecimalField with db_default on SQLite.
CAST() must be wrapped in parentheses to be recognized as an expression on SQLite.

Regression in 7414704e88.
2023-11-02 17:57:39 +01:00
David Sanders 1944f490f9 Refs #34936 -- Added test for altering DecimalField with db_default to non-nullable. 2023-11-02 17:57:34 +01:00
Tim Graham 208870b612 Refs #31300 -- Allowed testing GeneratedField without collation.
CockroachDB and Snowflake don't support it.
2023-11-02 13:58:46 +01:00
Patrick Rauscher 116e225266 Fixed #34813 -- Doc'd usage of integrity HTML attribute with ManifestStaticFilesStorage. 2023-11-02 08:21:54 -03:00
Antoine Cheneau 65c283be16 Fixed #34927 -- Fixed admin system check for inlines with foreign keys to proxy models.
Follow up to 0e8be73812.
2023-11-02 10:42:20 +01:00
Mariusz Felisiak 36173cf29d Added stub release notes for 4.2.8. 2023-11-01 08:22:47 +01:00
Mariusz Felisiak 7caf262183 Added CVE-2023-46695 to security archive. 2023-11-01 08:16:14 +01:00
Mariusz Felisiak 05ba4130ee Fixed CVE-2023-46695 -- Fixed potential DoS in UsernameField on Windows.
Thanks MProgrammer (https://hackerone.com/mprogrammer) for the report.
2023-11-01 06:10:30 +01:00
Akash Kumar Sen 40b3975e7d Fixed #34462 -- Made admin log actions in bulk.
This also deprecates ModelAdmin.log_deletion() and
LogEntryManager.log_action().
2023-10-31 18:06:44 +01:00
Akash Kumar Sen 45e0c5892f Refs #34462 -- Moved ModelAdmin.log_deletion() test to a separate test case. 2023-10-31 10:36:23 +01:00
Ben Cail 523fed1d2f Fixed #32106 -- Preserved HTTP_HOST in test Client when following redirects.
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
2023-10-31 05:29:43 +01:00
Natalia 9b18af4f6f Refs #30601 -- Fixed typos in docs/topics/db/transactions.txt. 2023-10-30 10:35:44 -03:00
Natalia b412e5645a Refs #15578 -- Made cosmetic edits to fixtures docs. 2023-10-30 10:29:37 -03:00
Sarah Boyce e4d012ca05 Refs #29850 -- Added exclusion support to window frames. 2023-10-30 12:04:55 +01:00
Tom Carrick 34b411762b Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.
Regression in f3f9d03edf (4.2) and
8ed25d65ea (5.0).
2023-10-30 07:37:40 +01:00
Mariusz Felisiak 46df3ab244
Fixed typo in docs/topics/forms/index.txt. 2023-10-30 05:16:40 +01:00
Sarah Boyce 6375cee490 Refs #29850 -- Added RowRange support for positive integer start and negative integer end. 2023-10-28 15:16:07 +02:00
ksg a6c7db1d1d
Fixed #34943 -- Made EmailValidator.__eq__() ignore domain_allowlist ordering.
Signed-off-by: ksg97031 <ksg97031@gmail.com>
2023-10-28 14:35:25 +02:00
Sarah Boyce 8992a0489c
Fixed typos in docs/ref/models/expressions.txt. 2023-10-28 14:21:15 +02:00
lufafajoshua aa80b357fb Fixed #30601 -- Doc'd the need to manually revert all app state on transaction rollbacks. 2023-10-27 17:35:47 -03:00
Marc Gibbons 8d9c0e4e24 Doc'd writing integration tests for the system check framework. 2023-10-27 09:44:14 +02:00
Mariusz Felisiak cf57e220a9
Fixed isolation of DatabaseWrapperLoggingTests.test_commit_debug_log(). 2023-10-27 09:05:09 +02:00
Izzy Hyman c42250a703
Fixed typo in docs/ref/contrib/gis/geos.txt. 2023-10-27 05:31:10 +02:00
Leo Suarez 334dc073b1 Fixed #15578 -- Stated the processing order of fixtures in the fixtures docs.
Also, added details about loading multiple fixtures and unified line wrapping
at 79 cols.

Co-Authored-By: Aniketh Babu <anikethbabu@gmail.com>
Co-Authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-Authored-By: Natalia Bidart <124304+nessita@users.noreply.github.com>
2023-10-26 17:40:26 -03:00
Tom Carrick e67d3580ed Fixed #10941 -- Added {% query_string %} template tag. 2023-10-26 09:57:21 +02:00
Mariusz Felisiak 718b32c691
Added missing pycon directives in various docs. 2023-10-25 12:27:27 +02:00
Tim Bell ee104251c4 Fixed #27403 -- Doc'd that QuerySet.prefetch_related() doesn't guarantee transactional consistency.
Added a note about the potential race condition in prefetch_related()
that could produce an inconsistent result, one that does not correspond
to any point in the database history.
2023-10-25 09:49:33 +02:00
sindre 64060d1c17 Fixed #34904 -- Prevented mutating sent emails from outbox in locmem email backend. 2023-10-25 08:52:31 +02:00