Commit Graph

32625 Commits

Author SHA1 Message Date
Mariusz Felisiak f030236a86 Fixed #35275 -- Fixed Meta.constraints validation crash on UniqueConstraint with OpClass().
This also introduces Expression.constraint_validation_compatible that
allows specifying that expression should be ignored during a constraint
validation.
2024-05-14 10:34:30 +02:00
Nick Pope ceaf1e2848 Fixed SeleniumTestCase.set_emulated_media() when using selenium_hub.
The .execute_cdp_cmd() method doesn't exist on selenium.webdriver.Remote.
2024-05-13 17:31:35 +02:00
Nick Pope 53b981eff2 Added support for using Microsoft Edge with Selenium. 2024-05-13 17:31:35 +02:00
ZeyadMoustafaKamal a09082a9be Replaced djangosites.org with builtwithdjango.com. 2024-05-13 09:48:12 +02:00
Adam Johnson d2c5a30e5a Fixed #35408 -- Optimized post-migrate permission creation.
co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2024-05-13 08:34:57 +02:00
nessita 1a36dce9c5
Updated docs for the Django release process. 2024-05-10 19:45:19 -03:00
nessita 34f329ecac
Added tests for Storage's generate_filename method. 2024-05-10 08:51:47 -03:00
minusf dd46cab6e0 Refs #35404 -- Fixed the line height of admin fieldset labels. 2024-05-10 12:11:35 +02:00
SaJH 4a76ac0e9d Fixed #35429 -- Added argparse choices to --database options. 2024-05-10 11:14:07 +02:00
Nick Pope 962215db13 Organized images in the screenshots workflow.
Added a top-level directory in the zip archive that is the commit
hash which makes it easier when downloading multiple artifacts
for comparison. Updated the filenames of screenshots for easier
comparison between different cases. Added that an error is
raised if no screenshots uploaded in workflow.
2024-05-10 10:37:56 +02:00
Nick Pope 02c2090dc0 Optimized images in the screenshots workflow.
Running `oxipng` over a set of screenshots from a previous run that were
1.9M in size resulted in a total size of 1.3M, a 31.5% reduction.

This can be useful to reduce the artifact size stored in GitHub and
locally if downloading screenshots from multiple runs.

See https://til.simonwillison.net/github-actions/oxipng
2024-05-10 10:37:56 +02:00
Nick Pope 956f6610ec Removed obsolete logic from screenshots workflow.
The id was used when we attempted to update comments in an early
version of the feature. Also removed the job summary as it
doesn't have the value that it did in the original version of
the feature.
2024-05-10 10:37:56 +02:00
SaJH f92ac845a9 Fixed #35436 -- Fixed displaying Unicode chars in forms.HStoreField. 2024-05-10 09:42:07 +02:00
Adam Zahradník d59066b90c
Corrected Slovak local name. 2024-05-08 13:43:36 -03:00
r3a96 0e445badd5 Removed Redis parser_class reference from docs. 2024-05-08 08:41:13 +02:00
Baptiste Mispelon e37f421da8 Matched blacken-docs config between ci and pre-commit. 2024-05-08 08:04:06 +02:00
Natalia b79ac89c57 Added stub release notes for 5.0.7. 2024-05-07 15:06:02 -03:00
Sarah Boyce 90175e110e Added release notes for 5.0.6 and 4.2.13. 2024-05-07 17:21:21 +02:00
Adam Johnson 7abe5112f4 Fixed #35407 -- Cached model's Options.swapped. 2024-05-07 14:25:51 +02:00
Jacob Walls ceea86baa3 Fixed #35425 -- Avoided INSERT with force_update and explicit pk.
Affected models where the primary key field is defined with a
default or db_default, such as UUIDField.
2024-05-07 12:15:27 +02:00
Sarah Boyce 34a503162f Added release date for 5.0.5 and 4.2.12. 2024-05-06 14:35:57 +02:00
alexgmin dba05042dd Added link to the csrf template tag in the csrf page. 2024-05-06 13:25:30 +02:00
Mariusz Felisiak 6345a6ff63 Migrated to ESLint 9+. 2024-05-06 11:42:37 +02:00
sobolevn 9a27c76021 Fixed #35426 -- Updated querysets to be a required argument of GenericPrefetch. 2024-05-04 11:30:36 +02:00
Shamil 32d163e680 Fixed #35427 -- Corrected help text for makemessages --extension in docs/ref/django-admin.txt. 2024-05-03 22:48:17 -03:00
Natalia 3614ce2b7c Refs #31224 -- Fixed typo in django/test/client.py. 2024-05-03 22:45:15 -03:00
Natalia e72049aa63 Refs #35422 -- Fixed typo in docs/releases/5.0.5.txt. 2024-05-03 13:07:11 -03:00
Mariusz Felisiak 91a4b9a8ec Fixed #35422 -- Fixed migrations crash when altering GeneratedField referencing rename field.
Thanks Sarah Boyce for the report and Simon Charette for the
implementation idea.
2024-05-03 09:28:24 +02:00
DevilsAutumn 9aeb38c296 Fixed #35359 -- Fixed migration operations ordering when adding fields referenced by GeneratedField.expression.
Thank you to Simon Charette for the review.
2024-05-02 21:43:13 -03:00
David Sanders 97d48cd3c6 Refs #34007, Refs #35359 -- Added Q.referenced_based_fields property.
Thank you to Mariusz Felisiak and Natalia Bidart for the reviews.
2024-05-02 19:05:13 +02:00
Sarah Boyce 39828fa778 Added a high contrast mode to screenshot cases.
Thank you to Sarah Abderemane and Nick Pope for the reviews.
2024-05-02 13:18:58 +02:00
John Parton 914bf69171 Clarified when ImageField attributes are set. 2024-05-02 10:04:55 +02:00
Mariusz Felisiak 160c0ab13a Fixed rendering XOR section in docs. 2024-05-02 09:26:44 +02:00
Mariusz Felisiak 9d5c02446e Refs #29280 -- Moved release note about transaction_mode to "Database backends" section. 2024-05-02 09:19:34 +02:00
David Smith c187f5f924 Refs #32819 -- Avoided adding 'aria-describedby' to hidden inputs.
Hidden elements are not visible for both accessibility tools and browsers presentation layer. This change therefore only reduces the size of the generated HTML.
2024-04-30 11:11:02 +02:00
Mariusz Felisiak 85c154da2f Fixed #35412 -- Dropped support for SQLite < 3.31. 2024-04-29 11:07:54 +02:00
Mariusz Felisiak 8c257cecff
Refs #35339 -- Fixed source expressions in GeoAggregate on Oracle.
Regression in 42b567ab4c.
2024-04-26 22:36:07 -03:00
Adam Zapletal 828b94b178
Fixed #20744 -- Removed hint that arbitrary kwargs are allowed when creating forms.Fields. 2024-04-26 11:23:38 -03:00
Cole D e1431dd92e
Made confirmation prompt in squashmigrations consistent with other prompts.
Prior to this change, squashmigrations would use a [yN] prompt to ask
for user confirmation. A slash was added between the yes/no options
to make it consistent with other commands that print similar prompts.
2024-04-26 09:50:47 -03:00
Chris Muthig c8df2f9941 Fixed #35339 -- Fixed PostgreSQL aggregate's filter and order_by params order.
Updated OrderableAggMixin.as_sql() to separate the order_by parameters
from the filter parameters. Previously, the parameters and SQL were
calculated by the Aggregate parent class, resulting in a mixture of
order_by and filter parameters.

Thanks Simon Charette for the review.
2024-04-25 17:40:03 -03:00
Chris Muthig 42b567ab4c Refs #35339 -- Updated Aggregate class to return consistent source expressions.
Refactored the filter and order_by expressions in the Aggregate class to
return a list of Expression (or None) values, ensuring that the list
item is always available and represents the filter expression.
For the PostgreSQL OrderableAggMixin, the returned list will always
include the filter and the order_by value as the last two elements.

Lastly, emtpy Q objects passed directly into aggregate objects using
Aggregate.filter in admin facets are filtered out when resolving the
expression to avoid errors in get_refs().

Thanks Simon Charette for the review.
2024-04-25 17:40:03 -03:00
nessita ec8552417d
Pinned GitHub Actions for reminders to commit hashes for latest release. 2024-04-24 10:21:57 -03:00
nessita 694a96524b
Improved phrasing and removed bold text in the GitHub pull request template. 2024-04-24 10:20:02 -03:00
Tim Richardson e64d42e753 Fixed #35395 -- slice filter crashes on an empty dict with Python 3.12.
Keep consistent behaviour of slice() filter between python 3.12 and prior
versions in the case of a dict passed to the filter (catch the new to python
3.12 KeyError exception).
2024-04-24 10:53:38 +02:00
0saurabh0 16d0542bb6 Fixed #35382 -- Removed unused CSS for admin inline fieldsets. 2024-04-24 10:13:16 +02:00
Simon Charette 195d885ca0 Refs #35356 -- Clarified select related with masked field logic.
By always including related objects in the select mask via adjusting the
defer logic (_get_defer_select_mask()), it becomes possible for
select_related_descend() to treat forward and reverse relationships
indistinctively.

This work also simplifies and adds comments to
select_related_descend() to make it easier to understand.
2024-04-23 13:17:17 -03:00
Simon Charette 83f5478225 Fixed #35356 -- Deferred self-referential foreign key fields adequately.
While refs #34612 surfaced issues with reverse one-to-one fields
deferrals, it missed that switching to storing remote fields would break
self-referential relationships.

This change switches to storing related objects in the select mask
instead of remote fields to prevent collisions when dealing with
self-referential relationships that might have a different directional
mask.

Despite fixing #21204 introduced a crash under some self-referential
deferral conditions, it was simply not working even before that as it
aggregated the sets of deferred fields by model.

Thanks Joshua van Besouw for the report and Mariusz Felisiak for the
review.
2024-04-23 13:17:17 -03:00
minusf bcad5ad92b
Fixed incorrect blockquotes in docs/topics/forms/index.txt. 2024-04-22 22:26:55 -03:00
James Ostrander 36b7024b7f Fixed #35392, Refs #34331 -- Allowed importing aprefetch_related_objects from django.db.models.
Thanks James Ostrander for the report and fix, and to Tim Graham and
Mariusz Felisiak for the reviews.
2024-04-22 17:05:05 -03:00
Jkhall81 53719d6b5b Fixed #35321 -- Prevented Mobile Safari zoom-in on Django admin inputs.
Thanks Simon Willison for the report and Ben Cardy for testing.
2024-04-19 14:36:37 +02:00