b7fe36ad37
Refs #34730 -- Made Message importable from django.contrib.messages.
2023-08-25 06:55:12 +02:00
7bba231b67
Refs #24121 -- Added __repr__() to Message.
2023-08-24 11:06:13 +02:00
76c3e310dd
Fixed #34744 -- Prevented recreation of migration for constraints with a dict_keys.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2023-08-23 11:42:18 +02:00
dd45d5223b
Fixed ResourceWarning from unclosed SQLite connection on Python 3.13+.
...
- backends.sqlite.tests.ThreadSharing.test_database_sharing_in_threads
- backends.tests.ThreadTests.test_default_connection_thread_local:
on SQLite, close() doesn't explicitly close in-memory connections.
- servers.tests.LiveServerInMemoryDatabaseLockTest
- test_runner.tests.SQLiteInMemoryTestDbs.test_transaction_support
Check out https://github.com/python/cpython/pull/108015 .
2023-08-23 09:09:23 +02:00
48a1929ca0
Removed unnecessary trailing commas in tests.
2023-08-22 12:42:57 +02:00
f1c0a3baf7
Added tests for model field's choices iterator/iterable values.
2023-08-22 05:55:23 +02:00
fbd16438f4
Fixed #33143 -- Raised RuntimeWarning when performing import-time queries.
2023-08-21 13:44:25 +02:00
4c85d94bc0
Fixed utils_tests.test_lazyobject.SimpleLazyObjectPickleTestCase.
...
SimpleLazyObjectPickleTestCase executes database queries so it must
inherit from django.test.TestCase.
2023-08-20 16:09:07 +02:00
517d3bb4dd
Fixed #34779 -- Avoided unnecessary selection of non-nullable m2m fields without natural keys during serialization.
...
By using `select_related(None)` instead of `select_related()`, the
unnecessary joins are completely avoided. Note that the current tests
already covers the change, when the field is not `null=True`.
Regression in f9936deed1
2023-08-19 10:29:43 +02:00
6b965c6000
Fixed #34773 -- Fixed syncing DEFAULT_FILE_STORAGE/STATICFILES_STORAGE settings with STORAGES.
...
Thanks Petr Dlouhý for the report.
Bug in 32940d390a
2023-08-18 18:11:24 +02:00
59f4754704
Fixed #34362 -- Fixed FilteredRelation() crash on conditional expressions.
...
Thanks zhu for the report and Simon Charette for reviews.
2023-08-11 12:32:18 +02:00
1506f498fe
Fixed #34743 -- Fixed Meta.constraints validation crash when using pk.
...
Thanks Nwawel A Iroume for the report.
2023-08-11 08:51:29 +02:00
9946f0b0d9
Fixed #33817 -- Added support for python-oracledb and deprecated cx_Oracle.
2023-08-10 10:11:53 +02:00
e69a9920e2
Fixed non-deterministic order in SubqueryTests.test_slice_subquery_and_query.
...
Slice on unordered subquery may be non-deterministic in some databases.
2023-08-10 05:33:13 +02:00
80a5667c50
Refs #34233 -- Bumped required cx_Oracle to 8.3.
...
This bumps minimum supported versions of cx_Oracle to the first release
to support Python 3.10.
2023-08-09 12:41:47 +02:00
439242c594
Fixed #34692 -- Made autoreloader reset cached template loader for default renderer.
2023-08-09 09:09:52 +02:00
e02fc58889
Fixed #34586 -- Made QuerySet.create() raise ValueError for reverse one-to-many relations.
2023-08-09 06:59:40 +02:00
aa3cb3f372
Added IntegerField tests for checks for invalid choices.
2023-08-08 18:57:15 +02:00
5aa4c0b675
Fixed #34542 -- Made createsuperuser handle required blank fields in non-interactive mode.
2023-08-08 09:26:28 +02:00
0f3b1a783d
Fixed #34739 -- Added GEOSGeometry.equals_identical() method.
2023-08-05 18:23:38 +02:00
0336aa6672
Fixed TransactionalTests.test_password_with_at_sign() isolation on Oracle.
2023-08-04 17:36:04 +02:00
3434dbd39d
Fixed #34754 -- Fixed JSONField check constraints validation on NULL values.
...
The __isnull lookup of JSONField must special case
Value(None, JSONField()) left-hand-side in order to be coherent with
its convoluted null handling.
Since psycopg>=3 offers no way to pass a NULL::jsonb the issue is
resolved by optimizing IsNull(Value(None), True | False) to
True | False.
Regression in 5c23d9f0c3
2023-08-04 10:14:03 +02:00
2b582387d5
Fixed #34760 -- Dropped support for SQLite < 3.27.
2023-08-04 06:35:13 +02:00
f46a6b2816
Fixed #34686 -- Added support for GEOS 3.12.
2023-08-04 05:53:29 +02:00
b719688b21
Fixed #34761 -- Dropped support for MySQL < 8.0.11.
2023-08-03 18:54:29 +02:00
9b9c805ced
Removed unneeded escapes in regexes.
...
Special characters lose their special meaning inside sets of characters.
"-" lose its special meaning if it's placed as the first or last
character.
Follow up to 7c6b66383d
2023-08-02 19:53:16 +02:00
c77fbda7ce
Added more tests for django.http.request.split_domain_port().
2023-08-02 13:06:23 +02:00
c9b9a52edc
Fixed #34750 -- Fixed QuerySet.count() when grouping by unused multi-valued annotations.
...
Thanks Toan Vuong for the report.
Thanks Simon Charette for the review.
Regression in 59bea9efd2
2023-08-01 16:16:28 +02:00
10725a3187
Fixed #32820 -- Added aria-invalid="true" to fields with errors.
...
Co-authored-by: Demetris Stavrou <demestav@gmail.com>
Co-authored-by: David Smith <smithdc@gmail.com>
2023-08-01 06:08:04 +02:00
fff14736f1
Fixed #34331 -- Added QuerySet.aiterator() support for prefetch_related().
2023-07-31 21:17:36 +02:00
1ad7761ee6
Refs #34655 -- Made cosmetic edits to RadioSelect tests.
...
Follow up to f9c5958b8f
2023-07-31 20:17:10 +02:00
22b0b73c77
Fixed warnings per flake8 6.1.0.
2023-07-30 16:17:07 +02:00
4087367ba8
Fixed #34748 -- Fixed queryset crash when grouping by a reference in a subquery.
...
Regression in dd68af62b2
2023-07-29 16:08:20 +02:00
f9c5958b8f
Fixed #34655 -- Increased radioselect's test coverage.
2023-07-28 09:18:07 -03:00
89c8c2e831
Simplified call_command() calls.
2023-07-27 15:48:47 +02:00
95e4d6b813
Fixed #34532 -- Made formset_factory() respect Form's default_renderer.
...
Co-authored-by: David Smith <smithdc@gmail.com>
2023-07-24 09:09:53 +02:00
b9473cac65
Fixed #34714 -- Added aget_object_or_404()/aget_list_or_404() shortcuts.
2023-07-24 07:37:54 +02:00
f05cc5e3d2
Refs #24686 -- Made AlterField operation a noop when renaming related model with db_table.
2023-07-22 20:13:42 +02:00
62b83889e0
Fixed #34731 , Refs #34118 -- Replaced assertEquals() with assertEqual() in test_condition_with_func_and_lookup_outside_relation_name().
...
Signed-off-by: Michel Alexandre Salim <salimma@fedoraproject.org>
2023-07-21 21:18:24 +02:00
e4a5527d1d
Refs #29789 -- Added more tests for FilteredRelation with condition outside of relation name.
2023-07-21 12:03:42 +02:00
d7d80040c1
Made UniqueConstraint raise TypeError for type violations.
2023-07-19 21:46:20 +02:00
595a2abb58
Fixed #34701 -- Added support for NULLS [NOT] DISTINCT on PostgreSQL 15+.
2023-07-19 21:42:27 +02:00
68912e4f6f
Fixed #34717 -- Fixed QuerySet.aggregate() crash when referencing window functions.
...
Regression in 59bea9efd2#28477 .
Thanks younes-chaoui for the report.
2023-07-19 08:21:33 +02:00
3109038992
Refs #33201 -- Avoided unnecessary queries when renaming models with db_table on SpatiaLite.
2023-07-18 14:08:47 +02:00
e8252fc445
Fixed #34716 -- Fixed serialization of nested class methods in migrations.
...
Co-authored-by: Nicolò <nicolo.intrieri@spinforward.it>
2023-07-18 05:27:40 +02:00
da2f8e8257
Refs #34118 -- Improved sanitize_address() error message for tuple with empty strings.
2023-07-17 11:03:36 +02:00
1d0dfc0b92
Refs #30686 -- Moved Parser.SELF_CLOSING_TAGS to django.utils.html.VOID_ELEMENTS
2023-07-14 10:25:00 +02:00
88a2de3c39
Fixed #34448 -- Doc'd and tested --no-obsolete option of makemessages.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2023-07-14 08:47:30 +02:00
02966a30dd
Fixed #34697 -- Fixed non-deterministic order of dependencies and sets/frozensets in migrations.
...
Co-authored-by: Dakota Hawkins <dakotahawkins@gmail.com>
2023-07-12 12:33:23 +02:00
4afaeb14c2
Refs #30116 -- Simplified tests related with dictionary order.
...
Dicts preserve order since Python 3.6.
2023-07-12 11:06:59 +02:00
3f73df44f2
Fixed #34705 -- Reallowed BoundField.as_widget()'s attrs argument to set aria-describedby.
...
Regression in 966ecdd482
2023-07-12 05:43:41 +02:00
d1855c4847
Fixed #34691 -- Added system check for unmatched angle brackets in path().
2023-07-11 11:59:27 +02:00
c7276a9cb9
Refs #34695 -- Added tests for check for CSRF_FAILURE_VIEW signature with valid class-based view.
2023-07-11 10:46:34 +02:00
89c7454dbd
Fixed #34698 -- Made QuerySet.bulk_create() retrieve primary keys when updating conflicts.
2023-07-10 13:17:28 +02:00
b7a17b0ea0
Refs #31949 -- Made @vary_on_(cookie/headers) decorators work with async functions.
2023-07-10 11:43:36 +02:00
f7cfa48283
Fixed #34696 -- Updated selection counter in admin changelist on Chrome.
2023-07-10 10:09:07 +02:00
953f81e078
Refs #31949 -- Made @csrf_exempt decorator to work with async functions.
2023-07-10 07:55:02 +02:00
6d427288e4
Fixed #34688 -- Removed contrib.sitemaps.ping_google() and ping_google management command.
...
Thanks Joachim Jablon for the report.
Google has deprecated the sitemap ping endpoint, and will be removing
it in 6 months ~January 2024.
2023-07-10 05:59:35 +02:00
2584783f46
Refs #9602 -- Moved AlreadyRegistered/NotRegistered exceptions to django.contrib.admin.exceptions.
2023-07-07 13:22:06 +02:00
eed096574f
Fixed #32210 -- Fixed model inlines with to_field that has a default.
2023-07-07 09:11:46 +02:00
b91d62cca0
Refs #24377 -- Added assertions for model inlines with primary key that has a default.
...
This ensures that a model field default is ignored.
2023-07-07 08:18:31 +02:00
f64fd47a76
Fixed #9602 -- Added AdminSite.get_model_admin().
...
This allows retrieving an admin class for the given model class without
using internal attributes.
2023-07-07 08:06:01 +02:00
d569c1dcfe
Fixed #34639 -- Reverted "Fixed #32682 -- Made admin changelist use Exists() instead of distinct() for preventing duplicates."
...
This reverts commit 1871182031#32433 .
2023-07-07 07:08:28 +02:00
28e2077148
Refs #32433 -- Reallowed calling QuerySet.delete() after distinct().
...
While values(*field_excluding_pk).distinct() and
distinct(*field_excluding_pk) can reduce the number of resulting rows
in a way that makes subsequent delete() calls ambiguous standalone
.distinct() calls cannot.
Since delete() already disallows chain usages with values() the only
case that needs to be handled, as originally reported, is when
DISTINCT ON is used via distinct(*fields).
Refs #32682 which had to resort to subqueries to prevent duplicates in
the admin and caused significant performance regressions on MySQL
(refs #34639 ).
This partly reverts 6307c3f1a1
2023-07-07 07:08:28 +02:00
95cdf9dc66
Used AdminSite.is_registered() where appropriate.
2023-07-06 11:29:16 +02:00
966ecdd482
Fixed #32819 -- Established relationship between form fields and their help text.
...
Thanks Nimra for the initial patch.
Thanks Natalia Bidart, Thibaud Colas, David Smith, and Mariusz Felisiak
for reviews.
2023-07-06 08:03:19 +02:00
649262a406
Made some Selenium tests less flaky by adding explicit wait.
2023-07-05 09:45:50 +02:00
42b4f81e6e
Fixed isolation of SeleniumTests.test_search_input_filtered_page() test.
...
Test crashed when the sidebar was not closed.
2023-07-04 13:34:08 +02:00
968684aed4
Made SeleniumTests.test_updating_related_objects_updates_fk_selects_except_autocompletes() test less flaky by adding explicit Selenium wait.
2023-07-04 13:34:08 +02:00
075e9c0a4d
Fixed typo in tests/admin_docs/models.py.
2023-07-03 10:47:41 +02:00
ad0410ec4f
Fixed CVE-2023-36053 -- Prevented potential ReDoS in EmailValidator and URLValidator.
...
Thanks Seokchan Yoon for reports.
2023-07-03 08:16:55 +02:00
7eeadc82c2
Fixed RelatedGeoModelTest.test_centroid_collect_filter().
2023-06-30 10:18:04 +02:00
5820fc4485
Fixed #34687 -- Made Apps.clear_cache() clear get_swappable_settings_name() cache.
2023-06-30 08:27:15 +02:00
953f29f700
Fixed #34572 -- Added support for GDAL 3.7.
...
Co-authored-by: Michael Howitz <mh@gocept.com>
2023-06-30 06:03:08 +02:00
a40b0103bc
Fixed #30382 -- Allowed specifying parent classes in force_insert of Model.save().
2023-06-29 21:52:52 +02:00
601ffb0da3
Fixed #34685 -- Dropped support for GEOS 3.6 and 3.7.
2023-06-29 21:45:36 +02:00
ce204bed7f
Refs #30382 -- Added more tests for using force_insert with model inheritance.
2023-06-29 11:49:32 +02:00
6a523500af
Fixed #34684 -- Dropped support for GDAL 2.2 and 2.3.
2023-06-29 09:11:30 +02:00
21e6864715
Fixed RecorderTests.test_has_table_cached() on databases that perform multiple queries when introspecting tables.
...
Thanks Tim Graham for the report and implementation idea.
Follow up to ea8cbca579
2023-06-28 12:11:25 +02:00
a6d30f5012
Fixed #34671 -- Fixed collation introspection for views and materialized views on Oracle.
...
Thanks Philipp Maino for the report.
2023-06-27 13:50:42 +02:00
5e98959d92
Fixed #34391 -- Added async-compatible interface to auth functions and related methods test clients.
2023-06-27 11:17:17 +02:00
370a021780
Refs #34233 -- Bumped minimum supported version of Selenium to 4.8.0.
...
This bumps minimum supported versions of selenium to the first release
to support Python 3.10.
2023-06-26 14:22:54 +02:00
3152f9de47
Refs #31949 -- Made http decorators to work with async functions.
2023-06-26 09:29:04 +02:00
cd4c4c1905
Added more tests for http decorators.
2023-06-26 09:29:04 +02:00
865a6650d0
Moved http decorator tests into decorators/test_http.py.
2023-06-26 09:29:01 +02:00
38cde27a89
Fixed #34676 -- Normalized Distance()/Area() exceptions for nonexistent units.
2023-06-25 13:09:30 +02:00
650ce96782
Refs #34391 -- Updated asgiref dependency for 5.0 release series.
2023-06-23 21:52:04 +02:00
38e391e95f
Refs #31949 -- Made @sensitive_variables/sensitive_post_parameters decorators to work with async functions.
...
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2023-06-23 13:29:40 +02:00
f8092ee9ad
Improved style of n-tuple wording in docs and comments.
2023-06-23 09:29:35 +02:00
107865780a
Fixed #34345 -- Added system check for ManyToManyFields with intermediate tables in ModelAdmin.filter_horizontal/vertical.
2023-06-21 07:48:09 +02:00
1754c2c802
Refs #34634 -- Fixed creating diamond-shaped MTI objects with ancestors inherited from different paths.
...
Co-authored-by: Simon Charette <charette.s@gmail.com>
2023-06-20 08:40:35 +02:00
82a588a6bc
Fixed #34634 -- Adjusted system check for clashing fields to warn about links to common parent for MTI models.
2023-06-20 08:10:53 +02:00
3f1bc2222f
Fixed #34656 -- Fixed unclosed div in admin password change template.
...
Regression in 6991880109
2023-06-19 08:22:10 +02:00
bcacc6321a
Refs #34517 -- Restored skipping ImageFileField.update_dimension_fields without width/height fields.
...
This avoids reading the image size when the dimensions fields
(image_width, image_height) do not exist, as that operation may be
expensive.
Partially reverts ea53e7c09f
2023-06-19 05:24:42 +02:00
0c5146523b
Fixed #34662 -- Corrected number in error messages for Array(Min/Max)LengthValidator.
2023-06-18 14:32:51 +02:00
8b062eab8e
Made SeleniumTests.test_inline_uuid_pk_add_with_popup less flaky by waiting until popup is closed.
2023-06-18 08:37:19 +02:00
1b754d638d
Fixed #34629 -- Added filtering support to GIS aggregates.
2023-06-16 12:20:13 +02:00
1fe0b167af
Fixed #34473 -- Fixed step validation for form fields with non-zero minimum value.
2023-06-16 08:38:28 +02:00
5d20e02078
Fixed #33414 -- Fixed creating diamond-shaped MTI objects for common ancestor with primary key that has a default.
...
Co-authored-by: Simon Charette <charette.s@gmail.com>
2023-06-15 08:16:11 +02:00
1c4f5f314e
Refs #32143 -- Removed superflous constraints on excluded query.
...
The outer query reference is not necessary when alias can be reused and
can even be harmful by confusing query planers.
Refs #34597 .
2023-06-14 09:44:49 +02:00
François Freitag
David Sanders
Mariusz Felisiak
konsti
Natalia
Florian Zimmermann
Juan Alvarez
Francesco Panico
Francesco Panico
Jingbei Li
priyank.panchal
Mariana
Nick Pope
Mateusz Więckowski
Olivier Tabone
Simon Charette
Gregor Jerše
John Parton
Jakub Bagiński
Christopher Cave-Ayland
devilsautumn
Michel Alexandre Salim
Nicolò Intrieri
David Smith
Tushar
Yury V. Zaytsev
Sage Abdullah
Amir Karimi
Thomas Chaumeny
Ben Lomax
Cauê Thenório
Andrew Northall
Neeraj Kumar
sarahboyce
Sarah Boyce
davidolz
sobolevn
Akash Kumar Sen
Jon Janzen
th3nn3ss
Hrushikesh
Yaser Amiri
şuayip üzülmez
Olivier Le Thanh Duong
Jacob Rief