mirror of https://github.com/django/django.git
97 lines
3.9 KiB
Python
97 lines
3.9 KiB
Python
from django.conf import settings
|
|
from django.core.checks.urls import (
|
|
check_url_config, get_warning_for_invalid_pattern,
|
|
)
|
|
from django.test import SimpleTestCase
|
|
from django.test.utils import override_settings
|
|
|
|
|
|
class CheckUrlsTest(SimpleTestCase):
|
|
@override_settings(ROOT_URLCONF='check_framework.urls.no_warnings')
|
|
def test_no_warnings(self):
|
|
result = check_url_config(None)
|
|
self.assertEqual(result, [])
|
|
|
|
@override_settings(ROOT_URLCONF='check_framework.urls.warning_in_include')
|
|
def test_check_resolver_recursive(self):
|
|
# The resolver is checked recursively (examining url()s in include()).
|
|
result = check_url_config(None)
|
|
self.assertEqual(len(result), 1)
|
|
warning = result[0]
|
|
self.assertEqual(warning.id, 'urls.W001')
|
|
|
|
@override_settings(ROOT_URLCONF='check_framework.urls.include_with_dollar')
|
|
def test_include_with_dollar(self):
|
|
result = check_url_config(None)
|
|
self.assertEqual(len(result), 1)
|
|
warning = result[0]
|
|
self.assertEqual(warning.id, 'urls.W001')
|
|
expected_msg = "Your URL pattern '^include-with-dollar$' uses include with a regex ending with a '$'."
|
|
self.assertIn(expected_msg, warning.msg)
|
|
|
|
@override_settings(ROOT_URLCONF='check_framework.urls.contains_tuple')
|
|
def test_contains_tuple_not_url_instance(self):
|
|
result = check_url_config(None)
|
|
warning = result[0]
|
|
self.assertEqual(warning.id, 'urls.E004')
|
|
self.assertRegex(warning.msg, (
|
|
r"^Your URL pattern \('\^tuple/\$', <function <lambda> at 0x(\w+)>\) is "
|
|
r"invalid. Ensure that urlpatterns is a list of url\(\) instances.$"
|
|
))
|
|
|
|
@override_settings(ROOT_URLCONF='check_framework.urls.beginning_with_slash')
|
|
def test_beginning_with_slash(self):
|
|
result = check_url_config(None)
|
|
self.assertEqual(len(result), 1)
|
|
warning = result[0]
|
|
self.assertEqual(warning.id, 'urls.W002')
|
|
expected_msg = (
|
|
"Your URL pattern '/starting-with-slash/$' has a regex beginning "
|
|
"with a '/'. Remove this slash as it is unnecessary. If this "
|
|
"pattern is targeted in an include(), ensure the include() pattern "
|
|
"has a trailing '/'."
|
|
)
|
|
|
|
self.assertIn(expected_msg, warning.msg)
|
|
|
|
@override_settings(
|
|
ROOT_URLCONF='check_framework.urls.beginning_with_slash',
|
|
APPEND_SLASH=False,
|
|
)
|
|
def test_beginning_with_slash_append_slash(self):
|
|
# It can be useful to start a URL pattern with a slash when
|
|
# APPEND_SLASH=False (#27238).
|
|
result = check_url_config(None)
|
|
self.assertEqual(result, [])
|
|
|
|
@override_settings(ROOT_URLCONF='check_framework.urls.name_with_colon')
|
|
def test_name_with_colon(self):
|
|
result = check_url_config(None)
|
|
self.assertEqual(len(result), 1)
|
|
warning = result[0]
|
|
self.assertEqual(warning.id, 'urls.W003')
|
|
expected_msg = "Your URL pattern '^$' [name='name_with:colon'] has a name including a ':'."
|
|
self.assertIn(expected_msg, warning.msg)
|
|
|
|
@override_settings(ROOT_URLCONF=None)
|
|
def test_no_root_urlconf_in_settings(self):
|
|
delattr(settings, 'ROOT_URLCONF')
|
|
result = check_url_config(None)
|
|
self.assertEqual(result, [])
|
|
|
|
def test_get_warning_for_invalid_pattern_string(self):
|
|
warning = get_warning_for_invalid_pattern('')[0]
|
|
self.assertEqual(
|
|
warning.hint,
|
|
"Try removing the string ''. The list of urlpatterns should "
|
|
"not have a prefix string as the first element.",
|
|
)
|
|
|
|
def test_get_warning_for_invalid_pattern_tuple(self):
|
|
warning = get_warning_for_invalid_pattern((r'^$', lambda x: x))[0]
|
|
self.assertEqual(warning.hint, "Try using url() instead of a tuple.")
|
|
|
|
def test_get_warning_for_invalid_pattern_other(self):
|
|
warning = get_warning_for_invalid_pattern(object())[0]
|
|
self.assertIsNone(warning.hint)
|