p34709852
/
monkey
forked from p15670423/monkey
1
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Island: Use MappingProxyType for default argument in IslandConfigOptions

This commit is contained in:
Mike Salvatore 2022-01-25 19:55:52 -05:00
parent 3450ac93a3
commit 1ca8c98b86
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
monkey/monkey_island/cc/setup/island_config_options.py
View File

@ -1,5 +1,8 @@
from __future__ import annotations from __future__ import annotations
from types import MappingProxyType as ImmutableMapping
from typing import Mapping
from common.utils.file_utils import expand_path from common.utils.file_utils import expand_path
from monkey_island.cc.server_utils.consts import ( from monkey_island.cc.server_utils.consts import (
DEFAULT_CRT_PATH, DEFAULT_CRT_PATH,
@ -19,10 +22,7 @@ _LOG_LEVEL = "log_level"
class IslandConfigOptions: class IslandConfigOptions:
def __init__(self, config_contents: dict = None): def __init__(self, config_contents: Mapping[str, Mapping] = ImmutableMapping({})):
if config_contents is None:
config_contents = {}
self.data_dir = DEFAULT_DATA_DIR self.data_dir = DEFAULT_DATA_DIR
self.log_level = DEFAULT_LOG_LEVEL self.log_level = DEFAULT_LOG_LEVEL
self.start_mongodb = DEFAULT_START_MONGO_DB self.start_mongodb = DEFAULT_START_MONGO_DB
@ -33,7 +33,7 @@ class IslandConfigOptions:
self.update(config_contents) self.update(config_contents)
def update(self, config_contents: dict): def update(self, config_contents: Mapping[str, Mapping]):
self.data_dir = config_contents.get(_DATA_DIR, self.data_dir) self.data_dir = config_contents.get(_DATA_DIR, self.data_dir)
self.log_level = config_contents.get(_LOG_LEVEL, self.log_level) self.log_level = config_contents.get(_LOG_LEVEL, self.log_level)