From bb238de037f9dfd7854928b2cc8ee95eee5b8c10 Mon Sep 17 00:00:00 2001 From: Shreya Malviya Date: Thu, 21 Apr 2022 12:58:18 +0530 Subject: [PATCH 1/2] UI: Fix current line number in telemetry overview window --- monkey/monkey_island/cc/ui/src/components/map/TelemetryLog.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monkey/monkey_island/cc/ui/src/components/map/TelemetryLog.tsx b/monkey/monkey_island/cc/ui/src/components/map/TelemetryLog.tsx index 45e303a9c..1fea52388 100644 --- a/monkey/monkey_island/cc/ui/src/components/map/TelemetryLog.tsx +++ b/monkey/monkey_island/cc/ui/src/components/map/TelemetryLog.tsx @@ -59,7 +59,8 @@ const TelemetryLog = (props: { onStatusChange: Function }) => { let telemetryLineHeight = parseInt((telemetryStyle.lineHeight).replace('px', '')); setIsScrolledUp((element.scrollTop < scrollTop)); - setTelemetryCurrentLine(Math.trunc(element.scrollTop / telemetryLineHeight) + 1); + // Zooming in or out doesn't change the number of lines that are visible at once i.e. 5. + setTelemetryCurrentLine(Math.trunc(element.scrollTop / telemetryLineHeight) + 5); setTelemetryLines(Math.trunc(element.scrollHeight / telemetryLineHeight)); } From 94c151bc56545ec4a8dec5e8470277a44af088a2 Mon Sep 17 00:00:00 2001 From: Shreya Malviya Date: Thu, 21 Apr 2022 13:09:11 +0530 Subject: [PATCH 2/2] Changelog: Add entry for telemetry overview line number bugfix --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8619ce57e..d06dce6d6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -80,6 +80,7 @@ Changelog](https://keepachangelog.com/en/1.0.0/). - Unnecessary collection of kerberos credentials. #1771 - A bug where bogus users were collected by Mimikatz and added to the config. #1860 - A bug where windows executable was not self deleting. #1763 +- Incorrect line number in the telemetry overview window on the Map page. #1905 ### Security - Change SSH exploiter so that it does not set the permissions of the agent