diff --git a/monkey/tests/unit_tests/infection_monkey/credential_collectors/mimikatz_collector/test_mimikatz_collector.py b/monkey/tests/unit_tests/infection_monkey/credential_collectors/mimikatz_collector/test_mimikatz_collector.py index d34228821..49af1d003 100644 --- a/monkey/tests/unit_tests/infection_monkey/credential_collectors/mimikatz_collector/test_mimikatz_collector.py +++ b/monkey/tests/unit_tests/infection_monkey/credential_collectors/mimikatz_collector/test_mimikatz_collector.py @@ -1,3 +1,5 @@ +from typing import List + import pytest from infection_monkey.credential_collectors import Credentials, LMHash, NTHash, Password, Username @@ -17,12 +19,16 @@ def patch_pypykatz(win_creds: [WindowsCredentials], monkeypatch): ) +def collect_credentials() -> List[Credentials]: + return list(MimikatzCredentialCollector().collect_credentials()) + + @pytest.mark.parametrize( "win_creds", [([WindowsCredentials(username="", password="", ntlm_hash="", lm_hash="")]), ([])] ) def test_empty_results(monkeypatch, win_creds): patch_pypykatz(win_creds, monkeypatch) - collected_credentials = list(MimikatzCredentialCollector().collect_credentials()) + collected_credentials = collect_credentials() assert not collected_credentials @@ -34,7 +40,7 @@ def test_pypykatz_result_parsing(monkeypatch): password = Password("secret") expected_credentials = Credentials([username], [password]) - collected_credentials = list(MimikatzCredentialCollector().collect_credentials()) + collected_credentials = collect_credentials() assert len(collected_credentials) == 1 assert collected_credentials[0] == expected_credentials @@ -46,7 +52,7 @@ def test_pypykatz_result_parsing_duplicates(monkeypatch): ] patch_pypykatz(win_creds, monkeypatch) - collected_credentials = list(MimikatzCredentialCollector().collect_credentials()) + collected_credentials = collect_credentials() assert len(collected_credentials) == 2 @@ -62,7 +68,7 @@ def test_pypykatz_result_parsing_defaults(monkeypatch): lm_hash = LMHash("lm_hash") expected_credentials = Credentials([username], [password, lm_hash]) - collected_credentials = list(MimikatzCredentialCollector().collect_credentials()) + collected_credentials = collect_credentials() assert len(collected_credentials) == 1 assert collected_credentials[0] == expected_credentials @@ -77,6 +83,6 @@ def test_pypykatz_result_parsing_no_identities(monkeypatch): nt_hash = NTHash("ntlm_hash") expected_credentials = Credentials([], [lm_hash, nt_hash]) - collected_credentials = list(MimikatzCredentialCollector().collect_credentials()) + collected_credentials = collect_credentials() assert len(collected_credentials) == 1 assert collected_credentials[0] == expected_credentials