From 658607de25e0c821501baf325bceeef923c9de77 Mon Sep 17 00:00:00 2001 From: Mike Salvatore Date: Fri, 12 Aug 2022 10:26:11 -0400 Subject: [PATCH] UT: Remove unnecessary wait() from test_version Unit tests should not be exposed to the internals of what they are testing. Furthermore, the `latest_version` and `download` properties wait for the event to be set, making the extra `wait()` redundant. --- monkey/tests/unit_tests/monkey_island/cc/test_version.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/monkey/tests/unit_tests/monkey_island/cc/test_version.py b/monkey/tests/unit_tests/monkey_island/cc/test_version.py index 7fc8ca38b..51c5def58 100644 --- a/monkey/tests/unit_tests/monkey_island/cc/test_version.py +++ b/monkey/tests/unit_tests/monkey_island/cc/test_version.py @@ -27,15 +27,17 @@ successful_response.return_value.json.return_value = { ) def test_version__request_failed(monkeypatch, request_mock): monkeypatch.setattr("requests.get", request_mock) + version = Version(version_number="1.0.0", deployment=Deployment.DEVELOP) - version._initialization_complete.wait() + assert version.latest_version == "1.0.0" assert version.download_url is None def test_version__request_successful(monkeypatch): monkeypatch.setattr("requests.get", successful_response) + version = Version(version_number="1.0.0", deployment=Deployment.DEVELOP) - version._initialization_complete.wait() + assert version.latest_version == SUCCESS_VERSION assert version.download_url == SUCCESS_URL