From 9c2cdf15e2ed648ca204c66a4708411170f21751 Mon Sep 17 00:00:00 2001 From: Mike Salvatore Date: Thu, 6 Oct 2022 17:01:06 -0400 Subject: [PATCH] Agent: Add TODO in Log4ShellExploiter --- monkey/infection_monkey/exploit/log4shell.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monkey/infection_monkey/exploit/log4shell.py b/monkey/infection_monkey/exploit/log4shell.py index 262915530..95fb7952d 100644 --- a/monkey/infection_monkey/exploit/log4shell.py +++ b/monkey/infection_monkey/exploit/log4shell.py @@ -174,9 +174,10 @@ class Log4ShellExploiter(WebRCE): ) logger.warning(error_message) - self._publish_exploitation_event(timestamp, False, error_message=error_message) + # TODO: _wait_for_victim() gets called even if trigger_exploit() raises an + # exception. Is that the desired behavior? if self._wait_for_victim(timestamp): self.exploit_info["vulnerable_service"] = { "service_name": exploit.service_name,