p34709852
/
monkey
forked from p15670423/monkey
1
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Island: Improve directory traversal error message

This commit is contained in:
Mike Salvatore 2022-06-21 14:02:19 -04:00
parent 40b192accc
commit f9775f5b54
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
monkey/monkey_island/cc/repository/file_storage/local_storage_file_repository.py
View File

@ -76,7 +76,9 @@ class LocalStorageFileRepository(IFileRepository):
# This is a paranoid check to avoid directory traversal attacks. # This is a paranoid check to avoid directory traversal attacks.
if self._storage_directory.resolve() not in safe_file_path.parents: if self._storage_directory.resolve() not in safe_file_path.parents:
raise ValueError(f"The file named {unsafe_file_name} can not be safely retrieved") raise ValueError(
f'The file named "{unsafe_file_name}" cannot be safely retrieved or written'
)
logger.debug(f"Untrusted file name {unsafe_file_name} sanitized: {safe_file_path}") logger.debug(f"Untrusted file name {unsafe_file_name} sanitized: {safe_file_path}")
return safe_file_path return safe_file_path