p34709852
/
monkey
forked from p15670423/monkey
1
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Agent: Use PUT instead of POST to send agent logs

This commit is contained in:
Mike Salvatore 2022-09-28 15:22:44 -04:00
parent 87d25d2ac8
commit ff8c8bd0a0
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
monkey/infection_monkey/island_api_client/http_island_api_client.py
View File

@ -93,7 +93,7 @@ class HTTPIslandAPIClient(IIslandAPIClient):
@handle_island_errors @handle_island_errors
def send_log(self, agent_id: AgentID, log_contents: str): def send_log(self, agent_id: AgentID, log_contents: str):
response = requests.post( # noqa: DUO123 response = requests.put( # noqa: DUO123
f"{self._api_url}/agent-logs/{agent_id}", f"{self._api_url}/agent-logs/{agent_id}",
json=log_contents, json=log_contents,
verify=False, verify=False,

4
monkey/tests/unit_tests/infection_monkey/island_api_client/test_http_island_api_client.py
View File

@ -119,7 +119,7 @@ def test_island_api_client__send_log(island_api_client, actual_error, expected_e
island_api_client.connect(SERVER) island_api_client.connect(SERVER)
with pytest.raises(expected_error): with pytest.raises(expected_error):
m.post(ISLAND_SEND_LOG_URI, exc=actual_error) m.put(ISLAND_SEND_LOG_URI, exc=actual_error)
island_api_client.send_log(agent_id=AGENT_ID, log_contents="some_data") island_api_client.send_log(agent_id=AGENT_ID, log_contents="some_data")
@ -136,7 +136,7 @@ def test_island_api_client_send_log__status_code(island_api_client, status_code,
island_api_client.connect(SERVER) island_api_client.connect(SERVER)
with pytest.raises(expected_error): with pytest.raises(expected_error):
m.post(ISLAND_SEND_LOG_URI, status_code=status_code) m.put(ISLAND_SEND_LOG_URI, status_code=status_code)
island_api_client.send_log(agent_id=AGENT_ID, log_contents="some_data") island_api_client.send_log(agent_id=AGENT_ID, log_contents="some_data")