From 0cd6f15fc1a76922124fbd0e3f7f4c44532ebaf9 Mon Sep 17 00:00:00 2001 From: Mike Salvatore Date: Tue, 24 May 2022 18:18:51 -0400 Subject: [PATCH] Island Add TODO to resources.monkey.Monkey.post() --- monkey/monkey_island/cc/resources/monkey.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/monkey/monkey_island/cc/resources/monkey.py b/monkey/monkey_island/cc/resources/monkey.py index a11f9ffb8..99f45f73d 100644 --- a/monkey/monkey_island/cc/resources/monkey.py +++ b/monkey/monkey_island/cc/resources/monkey.py @@ -61,6 +61,11 @@ class Monkey(flask_restful.Resource): # Called on monkey wakeup to initialize local configuration @TestTelemStore.store_exported_telem def post(self, **kw): + + # TODO: Why is it the registration of an agent coupled to exploit telemetry? It's hard to + # understand why an agent registering itself should be so complicated. Is it because + # agent state (dead) and config are conflated? Figure out why this thing is so + # complicated. Then simplify it. with agent_killing_mutex: monkey_json = json.loads(request.data) monkey_json["dead"] = False