From 1dbfca567a0d674938d49588e7de3f456f8a719b Mon Sep 17 00:00:00 2001 From: Kekoa Kaaikala Date: Fri, 30 Sep 2022 19:28:26 +0000 Subject: [PATCH] UT: Give constants uppercase names --- .../cc/agent_event_handlers/test_scan_event_handler.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/monkey/tests/unit_tests/monkey_island/cc/agent_event_handlers/test_scan_event_handler.py b/monkey/tests/unit_tests/monkey_island/cc/agent_event_handlers/test_scan_event_handler.py index 82ede960f..ae8f7f2d9 100644 --- a/monkey/tests/unit_tests/monkey_island/cc/agent_event_handlers/test_scan_event_handler.py +++ b/monkey/tests/unit_tests/monkey_island/cc/agent_event_handlers/test_scan_event_handler.py @@ -98,9 +98,9 @@ def scan_event_handler(agent_repository, machine_repository, node_repository): return ScanEventHandler(agent_repository, machine_repository, node_repository) -machines = {MACHINE_ID: SOURCE_MACHINE, TARGET_MACHINE.id: TARGET_MACHINE} -machines_by_id = {MACHINE_ID: SOURCE_MACHINE, TARGET_MACHINE.id: TARGET_MACHINE} -machines_by_ip = { +MACHINES = {MACHINE_ID: SOURCE_MACHINE, TARGET_MACHINE.id: TARGET_MACHINE} +MACHINES_BY_ID = {MACHINE_ID: SOURCE_MACHINE, TARGET_MACHINE.id: TARGET_MACHINE} +MACHINES_BY_IP = { IPv4Address("10.10.10.99"): [SOURCE_MACHINE], IPv4Address("10.10.10.1"): [TARGET_MACHINE], } @@ -112,11 +112,11 @@ def machine_id(request): def machine_from_id(id: int): - return machines_by_id[id] + return MACHINES_BY_ID[id] def machines_from_ip(ip: IPv4Address): - return machines_by_ip[ip] + return MACHINES_BY_IP[ip] class error_machine_by_id: