p41275903
/
monkey
forked from p15670423/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Agent: Fix exception handling for failed delivery of agent events 

If there's an exception while sending the event to the island it should be logged as exception, not warning (events are not being stored, that's a big no-no). Also, the log should contain proper information of stack trace, not event type
This commit is contained in:
vakaris_zilius 2022-09-30 09:54:12 +00:00 committed by Kekoa Kaaikala
parent 3d27e42ff3
commit 550c375abc
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
monkey/infection_monkey/agent_event_forwarder.py
View File

@ -79,8 +79,8 @@ class BatchingAgentEventForwarder:
try: try:
logger.debug(f"Sending Agent events to Island: {events}") logger.debug(f"Sending Agent events to Island: {events}")
self._island_api_client.send_events(events) self._island_api_client.send_events(events)
except Exception as err: except Exception:
logger.warning(f"Exception caught when connecting to the Island: {err}") logger.exception("Exception caught when connecting to the Island")
def _send_remaining_events(self): def _send_remaining_events(self):
self._send_events_to_island() self._send_events_to_island()