From 59ff3d39ced4907f18d7a3a844266f9a491d69b3 Mon Sep 17 00:00:00 2001 From: vakarisz Date: Tue, 14 Dec 2021 17:23:44 +0200 Subject: [PATCH] UT: small readability improvement in test_scan --- .../network/test_scan_target_generator.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/monkey/tests/unit_tests/infection_monkey/network/test_scan_target_generator.py b/monkey/tests/unit_tests/infection_monkey/network/test_scan_target_generator.py index 8d3166268..a28ae8275 100644 --- a/monkey/tests/unit_tests/infection_monkey/network/test_scan_target_generator.py +++ b/monkey/tests/unit_tests/infection_monkey/network/test_scan_target_generator.py @@ -1,3 +1,5 @@ +from itertools import chain + import pytest from infection_monkey.network.scan_target_generator import ( @@ -191,9 +193,7 @@ def test_local_subnet_added(): assert len(scan_targets) == 254 - for ip in range(0, 5): - assert f"10.0.0.{ip} in scan_targets" - for ip in range(6, 255): + for ip in chain(range(0, 5), range(6, 255)): assert f"10.0.0.{ip} in scan_targets" @@ -213,14 +213,10 @@ def test_multiple_local_subnets_added(): assert len(scan_targets) == 2 * (255 - 1) - for ip in range(0, 5): - assert f"10.0.0.{ip} in scan_targets" - for ip in range(6, 255): + for ip in chain(range(0, 5), range(6, 255)): assert f"10.0.0.{ip} in scan_targets" - for ip in range(0, 99): - assert f"172.33.66.{ip} in scan_targets" - for ip in range(100, 255): + for ip in chain(range(0, 99), range(100, 255)): assert f"172.33.66.{ip} in scan_targets"