Merge pull request #1587 from guardicore/1537-remove-serialize-config

1537 remove serialize config

CHANGELOG.md

@@ -21,6 +21,7 @@ Changelog](https://keepachangelog.com/en/1.0.0/).
 - Checkbox to disable/enable sending log to server. #1537
 - Checkbox for self deleting a monkey agent on cleanup. #1537
 - Checkbox for file logging. #1537
+- Remove serialization of config. #1537
 
 ### Fixed
 - A bug in network map page that caused delay of telemetry log loading. #1545

monkey/infection_monkey/config.py

@@ -128,9 +128,6 @@ class Configuration(object):
     # Configuration servers to try to connect to, in this order.
     command_servers = ["192.0.2.0:5000"]
 
-    # sets whether or not to locally save the running configuration after finishing
-    serialize_config = False
-
     # sets whether or not to retry failed hosts on next scan
     retry_failed_explotation = True
 

monkey/infection_monkey/main.py

@@ -123,18 +123,6 @@ def main():
     try:
         monkey.start()
 
-        if WormConfiguration.serialize_config:
-            with open(config_file, "w") as config_fo:
-                json_dict = WormConfiguration.as_dict()
-                json.dump(
-                    json_dict,
-                    config_fo,
-                    skipkeys=True,
-                    sort_keys=True,
-                    indent=4,
-                    separators=(",", ": "),
-                )
-
         return True
     except Exception as e:
         logger.exception("Exception thrown from monkey's start function. More info: {}".format(e))

monkey/monkey_island/cc/services/config_schema/internal.py

@@ -60,12 +60,6 @@ INTERNAL = {
                     "monkey propagating to "
                     "a high number of machines",
                 },
-                "serialize_config": {
-                    "title": "Serialize config",
-                    "type": "boolean",
-                    "default": False,
-                    "description": "Should the monkey dump its config on startup",
-                },
                 "alive": {
                     "title": "Alive",
                     "type": "boolean",

monkey/tests/data_for_tests/monkey_configs/monkey_config_standard.json

@@ -52,7 +52,6 @@
       "monkey": {
         "victims_max_find": 100,
         "victims_max_exploit": 100,
-        "serialize_config": false,
         "alive": true,
         "aws_keys": {
           "aws_access_key_id": "",