p41275903
/
monkey
forked from p15670423/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Island: Remove dependency from ILockableEncryptor -> IEncryptor 

ILockableEncryptor adds additional constraints on when encrypt() or
decrypt() can be used. If ILockableEncryptor inherits from IEncryptor,
it will violate the Liskov Substitution Principle
This commit is contained in:
Mike Salvatore 2022-07-11 15:07:16 -04:00
parent d6655a8e2c
commit 75f3fb02ee
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
monkey/monkey_island/cc/server_utils/encryption/i_lockable_encryptor.py
View File

@ -1,6 +1,4 @@
from abc import abstractmethod from abc import ABC, abstractmethod
from . import IEncryptor
# NOTE: The ILockableEncryptor introduces temporal coupling, that is, you must first unlock the # NOTE: The ILockableEncryptor introduces temporal coupling, that is, you must first unlock the
# encryptor before you can use it. This is because the key material used to encrypt repository # encryptor before you can use it. This is because the key material used to encrypt repository
@ -33,7 +31,7 @@ class ResetKeyError(Exception):
""" """
class ILockableEncryptor(IEncryptor): class ILockableEncryptor(ABC):
""" """
An encryptor that can be locked or unlocked. An encryptor that can be locked or unlocked.