forked from p15670423/monkey
Island: Remove unneeded comments from PyPubSubIslandEventQueue
This commit is contained in:
parent
69813f8cd4
commit
c16c6456aa
|
@ -16,22 +16,9 @@ class PyPubSubIslandEventQueue(IIslandEventQueue):
|
||||||
|
|
||||||
def subscribe(self, topic: IslandEventTopic, subscriber: IslandEventSubscriber):
|
def subscribe(self, topic: IslandEventTopic, subscriber: IslandEventSubscriber):
|
||||||
topic_name = topic.name # needs to be a string for pypubsub
|
topic_name = topic.name # needs to be a string for pypubsub
|
||||||
|
|
||||||
# NOTE: The subscriber's signature needs to match the MDS (message data specification) of
|
|
||||||
# the topic, otherwise, errors will arise. The MDS of a topic is set when the topic
|
|
||||||
# is created, which in our case is when a subscriber subscribes to a topic which
|
|
||||||
# is new (hasn't been subscribed to before). If the topic is being subscribed to by
|
|
||||||
# a subscriber for the first time, the topic's MDS will automatically be set
|
|
||||||
# according to that subscriber's signature.
|
|
||||||
self._pypubsub_publisher_wrapped.subscribe(topic_name, subscriber)
|
self._pypubsub_publisher_wrapped.subscribe(topic_name, subscriber)
|
||||||
|
|
||||||
def publish(self, topic: IslandEventTopic, event: Any = None):
|
def publish(self, topic: IslandEventTopic, event: Any = None):
|
||||||
topic_name = topic.name # needs to be a string for pypubsub
|
topic_name = topic.name # needs to be a string for pypubsub
|
||||||
|
|
||||||
logger.debug(f"Publishing {topic_name} event")
|
logger.debug(f"Publishing {topic_name} event")
|
||||||
|
|
||||||
# NOTE: `event_data` needs to match the MDS (message data specification) of the topic,
|
|
||||||
# otherwise, errors will arise. The MDS of a topic is set when the topic is created,
|
|
||||||
# which in our case is when a subscriber subscribes to a topic (in `subscribe()`)
|
|
||||||
# which is new (hasn't been subscribed to before).
|
|
||||||
self._pypubsub_publisher_wrapped.publish(topic_name, event)
|
self._pypubsub_publisher_wrapped.publish(topic_name, event)
|
||||||
|
|
Loading…
Reference in New Issue