test_ok2/changelog/11785.trivial.rst

Some changes were made to private functions which may affect plugins which access them:

- ``FixtureManager._getautousenames()`` now takes a ``Node`` itself instead of the nodeid.
- ``FixtureManager.getfixturedefs()`` now takes the ``Node`` itself instead of the nodeid.
- The ``_pytest.nodes.iterparentnodeids()`` function is removed without replacement.
  Prefer to traverse the node hierarchy itself instead.
  If you really need to, copy the function from the previous pytest release.
fixtures: match fixtures based on actual node hierarchy, not textual nodeids Refs #11662. --- Problem Each fixture definition has a "visibility", the `FixtureDef.baseid` attribute. This is nodeid-like string. When a certain `node` requests a certain fixture name, we match node's nodeid against the fixture definitions with this name. The matching currently happens on the textual representation of the nodeid - we split `node.nodeid` to its "parent nodeids" and then check if the fixture's `baseid` is in there. While this has worked so far, we really should try to avoid textual manipulation of nodeids as much as possible. It has also caused problem in an odd case of a `Package` in the root directory: the `Package` gets nodeid `.`, while a `Module` in it gets nodeid `test_module.py`. And textually, `.` is not a parent of `test_module.py`. --- Solution Avoid this entirely by just checking the node hierarchy itself. This is made possible by the fact that we now have proper `Directory` nodes (`Dir` or `Package`) for the entire hierarchy. Also do the same for `_getautousenames` which is a similar deal. The `iterparentnodeids` function is no longer used and is removed. 2024-01-06 19:12:02 +08:00			`Some changes were made to private functions which may affect plugins which access them:`

			- ``FixtureManager._getautousenames()`` now takes a ``Node`` itself instead of the nodeid.
			- ``FixtureManager.getfixturedefs()`` now takes the ``Node`` itself instead of the nodeid.
			- The ``_pytest.nodes.iterparentnodeids()`` function is removed without replacement.
			`Prefer to traverse the node hierarchy itself instead.`
			`If you really need to, copy the function from the previous pytest release.`