p53209761
/
test_ok2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
test_ok2/changelog/4988.bugfix.rst

2 lines
67 B
ReStructuredText
Raw Normal View History

logging: close log_file_handler While it should be closed in logging's shutdown [1], the following would still issue a ResourceWarning: ``` import logging log_file_handler = logging.FileHandler("temp.log", mode="w", encoding="UTF-8") root_logger = logging.getLogger() root_logger.addHandler(log_file_handler) root_logger.removeHandler(log_file_handler) root_logger.error("error") del log_file_handler ``` It looks like the weakref might get lost for some reason. See https://github.com/pytest-dev/pytest/pull/4981/commits/92ffe42b45 / #4981 for more information. 1: https://github.com/python/cpython/blob/c1419578a18d787393c7ccee149e7c1fff17a99e/Lib/logging/__init__.py#L2107-L2139
2019-03-23 16:16:14 +08:00
Close logging's file handler explicitly when the session finishes.