p53209761
/
test_ok2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add issue references to the todos

This commit is contained in:
Ronny Pfannschmidt 2018-12-20 11:57:44 +01:00
parent 64a353f2b6
commit 102ffc69e8
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/_pytest/config/__init__.py
View File

@ -270,6 +270,7 @@ class PytestPluginManager(PluginManager):
opts = {} opts = {}
if opts is not None: if opts is not None:
# TODO: DeprecationWarning, people should use hookimpl # TODO: DeprecationWarning, people should use hookimpl
# https://github.com/pytest-dev/pytest/issues/4562
known_marks = {m.name for m in getattr(method, "pytestmark", [])} known_marks = {m.name for m in getattr(method, "pytestmark", [])}
for name in ("tryfirst", "trylast", "optionalhook", "hookwrapper"): for name in ("tryfirst", "trylast", "optionalhook", "hookwrapper"):
@ -286,6 +287,7 @@ class PytestPluginManager(PluginManager):
if name.startswith("pytest_"): if name.startswith("pytest_"):
# todo: deprecate hookspec hacks # todo: deprecate hookspec hacks
# https://github.com/pytest-dev/pytest/issues/4562
known_marks = {m.name for m in getattr(method, "pytestmark", [])} known_marks = {m.name for m in getattr(method, "pytestmark", [])}
opts = { opts = {
"firstresult": hasattr(method, "firstresult") "firstresult": hasattr(method, "firstresult")

2
src/_pytest/python.py
View File

@ -1290,6 +1290,8 @@ class Function(FunctionMixin, nodes.Item, fixtures.FuncargnamesCompatAttr):
self.keywords.update(keywords) self.keywords.update(keywords)
# todo: this is a hell of a hack # todo: this is a hell of a hack
# https://github.com/pytest-dev/pytest/issues/4569
self.keywords.update( self.keywords.update(
dict.fromkeys( dict.fromkeys(
[ [