p53209761
/
test_ok2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

releasing: Always set doc_version (#9589) 

Looks like something (tox?) does not deal with empty arguments being passed to release.py correctly
This commit is contained in:
Florian Bruhin 2022-02-03 11:48:55 +01:00 committed by GitHub
parent 90b1c93f7e
commit 12b288d84a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/prepare-release-pr.py
View File

@ -90,13 +90,10 @@ def prepare_release_pr(
if prerelease: if prerelease:
template_name = "release.pre.rst" template_name = "release.pre.rst"
doc_version = release_branch
elif is_feature_release: elif is_feature_release:
template_name = "release.minor.rst" template_name = "release.minor.rst"
doc_version = "" # unused in template
else: else:
template_name = "release.patch.rst" template_name = "release.patch.rst"
doc_version = "" # unused in template
# important to use tox here because we have changed branches, so dependencies # important to use tox here because we have changed branches, so dependencies
# might have changed as well # might have changed as well
@ -107,7 +104,7 @@ def prepare_release_pr(
"--", "--",
version, version,
template_name, template_name,
doc_version, release_branch, # doc_version
"--skip-check-links", "--skip-check-links",
] ]
print("Running", " ".join(cmdline)) print("Running", " ".join(cmdline))