allow running testids which contain :: in the parametrized portion

This commit is contained in:
Anthony Sottile 2022-02-07 20:17:14 -05:00
parent bc33ba0be9
commit 2442034a1e
3 changed files with 11 additions and 1 deletions

View File

@ -0,0 +1 @@
Fix running tests by id with ``::`` in the parametrize portion.

View File

@ -870,7 +870,10 @@ def resolve_collection_argument(
If the path doesn't exist, raise UsageError. If the path doesn't exist, raise UsageError.
If the path is a directory and selection parts are present, raise UsageError. If the path is a directory and selection parts are present, raise UsageError.
""" """
strpath, *parts = str(arg).split("::") base, squacket, rest = str(arg).partition("[")
strpath, *parts = base.split("::")
if parts:
parts[-1] = f"{parts[-1]}{squacket}{rest}"
if as_pypath: if as_pypath:
strpath = search_pypath(strpath) strpath = search_pypath(strpath)
fspath = invocation_path / strpath fspath = invocation_path / strpath

View File

@ -171,6 +171,12 @@ class TestResolveCollectionArgument:
invocation_path, "pkg::foo::bar", as_pypath=True invocation_path, "pkg::foo::bar", as_pypath=True
) )
def test_parametrized_name_with_colons(self, invocation_path: Path) -> None:
ret = resolve_collection_argument(
invocation_path, "src/pkg/test.py::test[a::b]"
)
assert ret == (invocation_path / "src/pkg/test.py", ["test[a::b]"])
def test_does_not_exist(self, invocation_path: Path) -> None: def test_does_not_exist(self, invocation_path: Path) -> None:
"""Given a file/module that does not exist raises UsageError.""" """Given a file/module that does not exist raises UsageError."""
with pytest.raises( with pytest.raises(