Improve CHANGELOG and add some comments

Ref: #5768
This commit is contained in:
Bruno Oliveira 2019-08-30 11:20:19 -03:00
parent 62381125e7
commit 3ddbc7fb2a
3 changed files with 7 additions and 1 deletions

View File

@ -1 +1,2 @@
Fix ``self`` reference in function scoped fixtures that are in a plugin class
Fixed ``self`` reference in function-scoped fixtures defined plugin classes: previously ``self``
would be a reference to a *test* class, not the *plugin* class.

View File

@ -897,6 +897,8 @@ def resolve_fixture_function(fixturedef, request):
# request.instance so that code working with "fixturedef" behaves
# as expected.
if request.instance is not None:
# handle the case where fixture is defined not in a test class, but some other class
# (for example a plugin class with a fixture), see #2270
if hasattr(fixturefunc, "__self__") and not isinstance(
request.instance, fixturefunc.__self__.__class__
):

View File

@ -3946,6 +3946,9 @@ class TestScopeOrdering:
reprec.assertoutcome(passed=2)
def test_class_fixture_self_instance(self, testdir):
"""Check that plugin classes which implement fixtures receive the plugin instance
as self (see #2270).
"""
testdir.makeconftest(
"""
import pytest