From 412fc001a0770d44b281d9b39f736df3cdc80c37 Mon Sep 17 00:00:00 2001 From: Ronny Pfannschmidt Date: Sun, 7 Mar 2021 14:57:19 +0100 Subject: [PATCH] fix bug in test for issue 519 assert the actual outcome and fix the filename --- changelog/8411.trivial.rst | 1 + testing/example_scripts/issue_519.py | 4 ++-- testing/examples/test_issue519.py | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 changelog/8411.trivial.rst diff --git a/changelog/8411.trivial.rst b/changelog/8411.trivial.rst new file mode 100644 index 000000000..8f169a900 --- /dev/null +++ b/changelog/8411.trivial.rst @@ -0,0 +1 @@ +Assert the outcomes for the issue 518 test and fix the test. diff --git a/testing/example_scripts/issue_519.py b/testing/example_scripts/issue_519.py index 392829488..e44367fca 100644 --- a/testing/example_scripts/issue_519.py +++ b/testing/example_scripts/issue_519.py @@ -20,12 +20,12 @@ def checked_order(): yield order pprint.pprint(order) assert order == [ - ("testing/example_scripts/issue_519.py", "fix1", "arg1v1"), + ("issue_519.py", "fix1", "arg1v1"), ("test_one[arg1v1-arg2v1]", "fix2", "arg2v1"), ("test_two[arg1v1-arg2v1]", "fix2", "arg2v1"), ("test_one[arg1v1-arg2v2]", "fix2", "arg2v2"), ("test_two[arg1v1-arg2v2]", "fix2", "arg2v2"), - ("testing/example_scripts/issue_519.py", "fix1", "arg1v2"), + ("issue_519.py", "fix1", "arg1v2"), ("test_one[arg1v2-arg2v1]", "fix2", "arg2v1"), ("test_two[arg1v2-arg2v1]", "fix2", "arg2v1"), ("test_one[arg1v2-arg2v2]", "fix2", "arg2v2"), diff --git a/testing/examples/test_issue519.py b/testing/examples/test_issue519.py index 85ba545e6..7b9c10988 100644 --- a/testing/examples/test_issue519.py +++ b/testing/examples/test_issue519.py @@ -1,6 +1,7 @@ from _pytest.pytester import Pytester -def test_510(pytester: Pytester) -> None: +def test_519(pytester: Pytester) -> None: pytester.copy_example("issue_519.py") - pytester.runpytest("issue_519.py") + res = pytester.runpytest("issue_519.py") + res.assert_outcomes(passed=8)