p53209761
/
test_ok2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: harden test_better_reporting_on_conftest_load_failure (#6713)

This commit is contained in:
Daniel Hahler 2020-02-14 17:00:01 +01:00 committed by GitHub
parent de3353aac1
commit 4b70ba2c21
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
testing/acceptance_test.py
View File

@ -190,10 +190,10 @@ class TestGeneralUsage:
) )
@pytest.mark.filterwarnings("default") @pytest.mark.filterwarnings("default")
def test_better_reporting_on_conftest_load_failure(self, testdir, request): def test_better_reporting_on_conftest_load_failure(self, testdir):
"""Show a user-friendly traceback on conftest import failures (#486, #3332)""" """Show a user-friendly traceback on conftest import failures (#486, #3332)"""
testdir.makepyfile("") testdir.makepyfile("")
testdir.makeconftest( conftest = testdir.makeconftest(
""" """
def foo(): def foo():
import qwerty import qwerty
@ -208,22 +208,18 @@ class TestGeneralUsage:
""" """
) )
result = testdir.runpytest() result = testdir.runpytest()
dirname = request.node.name + "0"
exc_name = ( exc_name = (
"ModuleNotFoundError" if sys.version_info >= (3, 6) else "ImportError" "ModuleNotFoundError" if sys.version_info >= (3, 6) else "ImportError"
) )
result.stderr.fnmatch_lines( assert result.stdout.lines == []
[ assert result.stderr.lines == [
"ImportError while loading conftest '*{sep}{dirname}{sep}conftest.py'.".format( "ImportError while loading conftest '{}'.".format(conftest),
dirname=dirname, sep=os.sep "conftest.py:3: in <module>",
), " foo()",
"conftest.py:3: in <module>", "conftest.py:2: in foo",
" foo()", " import qwerty",
"conftest.py:2: in foo", "E {}: No module named 'qwerty'".format(exc_name),
" import qwerty", ]
"E {}: No module named 'qwerty'".format(exc_name),
]
)
def test_early_skip(self, testdir): def test_early_skip(self, testdir):
testdir.mkdir("xyz") testdir.mkdir("xyz")