p53209761
/
test_ok2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not advertise that importlib will be default import mode 

It is clear at this point that changing the default would break a lot of suites, and is not a clear win in all cases anyway.

Close #10003
This commit is contained in:
Bruno Oliveira 2022-05-31 09:51:09 -03:00
parent a72e8b3d3e
commit 6017666fe1
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
doc/en/explanation/goodpractices.rst
View File

@ -173,10 +173,9 @@ This layout prevents a lot of common pitfalls and has many benefits, which are b
`blog post by Ionel Cristian Mărieș <https://blog.ionelmc.ro/2014/05/25/python-packaging/#the-structure>`_. `blog post by Ionel Cristian Mărieș <https://blog.ionelmc.ro/2014/05/25/python-packaging/#the-structure>`_.
.. note:: .. note::
The new ``--import-mode=importlib`` (see :ref:`import-modes`) doesn't have The ``--import-mode=importlib`` option (see :ref:`import-modes`) does not have
any of the drawbacks above because ``sys.path`` is not changed when importing any of the drawbacks above because ``sys.path`` is not changed when importing
test modules, so users that run test modules, so users that run into this issue are strongly encouraged to try it.
into this issue are strongly encouraged to try it and report if the new option works well for them.
The ``src`` directory layout is still strongly recommended however. The ``src`` directory layout is still strongly recommended however.

15
doc/en/explanation/pythonpath.rst
View File

@ -45,10 +45,19 @@ these values:
* ``importlib``: new in pytest-6.0, this mode uses :mod:`importlib` to import test modules. This gives full control over the import process, and doesn't require changing :py:data:`sys.path`. * ``importlib``: new in pytest-6.0, this mode uses :mod:`importlib` to import test modules. This gives full control over the import process, and doesn't require changing :py:data:`sys.path`.
For this reason this doesn't require test module names to be unique, but also makes test For this reason this doesn't require test module names to be unique.
modules non-importable by each other.
One drawback however is that test modules are non-importable by each other. Also, utility
modules in the tests directories are not automatically importable because the tests directory is no longer
added to :py:data:`sys.path`.
Initially we intended to make ``importlib`` the default in future releases, however it is clear now that
it has its own set of drawbacks so the default will remain ``prepend`` for the foreseeable future.
.. seealso::
The :confval:`pythonpath` configuration variable.
We intend to make ``importlib`` the default in future releases, depending on feedback.
``prepend`` and ``append`` import modes scenarios ``prepend`` and ``append`` import modes scenarios
------------------------------------------------- -------------------------------------------------