[svn r38560] Compare collectors by id rather than by name. It needs to be rethought

a bit.

--HG--
branch : trunk
This commit is contained in:
fijal 2007-02-12 14:20:49 +01:00
parent d01fb4a18e
commit 6294a4b189
2 changed files with 12 additions and 10 deletions

View File

@ -65,10 +65,11 @@ class Collector(object):
return "<%s %r>" %(self.__class__.__name__, self.name)
def __eq__(self, other):
try:
return self.name == other.name and self.parent == other.parent
except AttributeError:
return False
#try:
# return self.name == other.name and self.parent == other.parent
#except AttributeError:
# return False
return self is other
def __hash__(self):
return hash((self.name, self.parent))
@ -358,7 +359,7 @@ class Module(FSCollector, PyCollectorMixin):
if res is None:
attr = getattr(self.obj, name, None)
if attr is not None:
res = self.makeitem(name, attr, usefilters=False)
return self.makeitem(name, attr, usefilters=False)
return res
def startcapture(self):

View File

@ -397,7 +397,8 @@ class TestConfigColitems:
assert trail[0] == a.relto(config.topdir)
assert trail[1] == ('trail.py',)
col2 = config._getcollector(trail)
assert col2.listchain() == col.listchain()
assert [i.name for i in col2.listchain()] == \
[i.name for i in col.listchain()]
def test_get_collector_trail_topdir_and_beyond(self):
config = py.test.config._reparse([self.tmpdir])