p53209761
/
test_ok2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

junitxml: compile a regex lazily 

Instead of slowing down startup, and making the code harder to follow,
compile it lazily (it is still cached internally).
This commit is contained in:
Ran Benita 2020-07-23 17:33:17 +03:00
parent 27a4c6cd6d
commit 6ea6f0dac8
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/_pytest/junitxml.py
View File

@ -68,8 +68,6 @@ del _legal_chars
del _legal_ranges del _legal_ranges
del _legal_xml_re del _legal_xml_re
_py_ext_re = re.compile(r"\.py$")
def bin_xml_escape(arg: object) -> py.xml.raw: def bin_xml_escape(arg: object) -> py.xml.raw:
def repl(matchobj: Match[str]) -> str: def repl(matchobj: Match[str]) -> str:
@ -473,7 +471,7 @@ def mangle_test_address(address: str) -> List[str]:
pass pass
# convert file path to dotted path # convert file path to dotted path
names[0] = names[0].replace(nodes.SEP, ".") names[0] = names[0].replace(nodes.SEP, ".")
names[0] = _py_ext_re.sub("", names[0]) names[0] = re.sub(r"\.py$", "", names[0])
# put any params back # put any params back
names[-1] += possible_open_bracket + params names[-1] += possible_open_bracket + params
return names return names