mypy: disallow untyped defs by default (#11862)

Change our mypy configuration to disallow untyped defs by default, which ensures *new* files added to the code base are fully typed.

To avoid having to type-annotate everything now, add `# mypy: allow-untyped-defs` to files which are not fully type annotated yet.

As we fully type annotate those modules, we can then just remove that directive from the top.

setup.cfg

@@ -94,6 +94,7 @@ formats = sdist.tgz,bdist_wheel
 mypy_path = src
 check_untyped_defs = True
 disallow_any_generics = True
+disallow_untyped_defs = True
 ignore_missing_imports = True
 show_error_codes = True
 strict_equality = True

src/_pytest/_code/code.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import ast
 import dataclasses
 import inspect

src/_pytest/_code/source.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import ast
 import inspect
 import textwrap

src/_pytest/_io/pprint.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 # This module was imported from the cpython standard library
 # (https://github.com/python/cpython/) at commit
 # c5140945c723ae6c4b7ee81ff720ac8ea4b52cfd (python3.12).

src/_pytest/_py/path.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """local path implementation."""
 from __future__ import annotations
 

src/_pytest/assertion/__init__.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Support for presenting detailed information in failing assertions."""
 import sys
 from typing import Any

src/_pytest/assertion/util.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Utilities for assertion debugging."""
 import collections.abc
 import os

src/_pytest/cacheprovider.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Implementation of the cache provider."""
 # This plugin was not named "cache" to avoid conflicts with the external
 # pytest-cache version.

src/_pytest/capture.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Per-test stdout/stderr capturing mechanism."""
 import abc
 import collections

src/_pytest/compat.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Python version compatibility code."""
 from __future__ import annotations
 

src/_pytest/config/__init__.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Command line options, ini-file and conftest.py processing."""
 import argparse
 import collections.abc

src/_pytest/config/argparsing.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import argparse
 import os
 import sys

src/_pytest/debugging.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Interactive debugging with PDB, the Python Debugger."""
 import argparse
 import functools

src/_pytest/doctest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Discover and run doctests in modules and test files."""
 import bdb
 import functools

src/_pytest/fixtures.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import abc
 import dataclasses
 import functools

src/_pytest/helpconfig.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Version info, help messages, tracing configuration."""
 import os
 import sys

src/_pytest/hookspec.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Hook specifications for pytest plugins which are invoked by pytest itself
 and by builtin plugins."""
 from pathlib import Path

src/_pytest/junitxml.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Report test results in JUnit-XML format, for use with Jenkins and build
 integration servers.
 

src/_pytest/legacypath.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Add backward compatibility support for the legacy py path type."""
 import dataclasses
 import os

src/_pytest/logging.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Access and control log capturing."""
 import io
 import logging

src/_pytest/mark/structures.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import collections.abc
 import dataclasses
 import inspect

src/_pytest/monkeypatch.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Monkeypatching and mocking functionality."""
 import os
 import re

src/_pytest/nodes.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import abc
 import os
 import warnings

src/_pytest/pastebin.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Submit failure or test session information to a pastebin service."""
 import tempfile
 from io import StringIO

src/_pytest/pathlib.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import atexit
 import contextlib
 import fnmatch

src/_pytest/pytester.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """(Disabled by default) support for testing pytest and pytest plugins.
 
 PYTEST_DONT_REWRITE

src/_pytest/python.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Python test discovery, setup and run of test functions."""
 import abc
 import dataclasses

src/_pytest/python_api.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import math
 import pprint
 from collections.abc import Collection

src/_pytest/recwarn.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Record warnings during test function execution."""
 import re
 import warnings

src/_pytest/reports.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import dataclasses
 import os
 from io import StringIO

src/_pytest/runner.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Basic collect and runtest protocol implementations."""
 import bdb
 import dataclasses

src/_pytest/skipping.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Support for skip/xfail functions and markers."""
 import dataclasses
 import os

src/_pytest/terminal.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Terminal reporting of the full testing process.
 
 This is a good source for looking at the various reporting hooks.

src/_pytest/tmpdir.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Support for providing temporary directories to test functions."""
 import dataclasses
 import os

src/_pytest/unittest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Discover and run std-library "unittest" style tests."""
 import sys
 import traceback

src/_pytest/warnings.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import sys
 import warnings
 from contextlib import contextmanager

testing/_py/test_local.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import contextlib
 import multiprocessing
 import os

testing/acceptance_test.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import dataclasses
 import importlib.metadata
 import os

testing/code/test_code.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import re
 import sys
 from types import FrameType

testing/code/test_excinfo.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 from __future__ import annotations
 
 import importlib

testing/code/test_source.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 # flake8: noqa
 # disable flake check on this file because some constructs are strange
 # or redundant on purpose and can't be disable on a line-by-line basis

testing/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import dataclasses
 import re
 import sys

testing/deprecated_test.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 from _pytest import deprecated
 from _pytest.pytester import Pytester

testing/example_scripts/acceptance/fixture_mock_integration.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Reproduces issue #3774"""
 from unittest import mock
 

testing/example_scripts/collect/collect_init_tests/tests/__init__.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_init():
     pass

testing/example_scripts/collect/collect_init_tests/tests/test_foo.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_foo():
     pass

testing/example_scripts/collect/package_infinite_recursion/conftest.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def pytest_ignore_collect(collection_path):
     return False

testing/example_scripts/collect/package_infinite_recursion/tests/test_basic.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test():
     pass

testing/example_scripts/collect/package_init_given_as_arg/pkg/__init__.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_init():
     pass

testing/example_scripts/collect/package_init_given_as_arg/pkg/test_foo.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_foo():
     pass

testing/example_scripts/config/collect_pytest_prefix/test_foo.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_foo():
     pass

testing/example_scripts/conftest_usageerror/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 def pytest_configure(config):
     import pytest
 

testing/example_scripts/customdirectory/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 # content of conftest.py
 import json
 

testing/example_scripts/customdirectory/tests/test_first.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 # content of test_first.py
 def test_1():
     pass

testing/example_scripts/customdirectory/tests/test_second.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 # content of test_second.py
 def test_2():
     pass

testing/example_scripts/customdirectory/tests/test_third.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 # content of test_third.py
 def test_3():
     pass

testing/example_scripts/dataclasses/test_compare_initvar.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 from dataclasses import dataclass
 from dataclasses import InitVar
 

testing/example_scripts/dataclasses/test_compare_recursive_dataclasses.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 from dataclasses import dataclass
 
 

testing/example_scripts/doctest/main_py/__main__.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_this_is_ignored():
     assert True

testing/example_scripts/doctest/main_py/test_normal_module.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 def test_doc():
     """
     >>> 10 > 5

testing/example_scripts/fixtures/custom_item/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/custom_item/foo/test_foo.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test():
     pass

testing/example_scripts/fixtures/fill_fixtures/test_conftest_funcargs_only_available_in_subdir/sub1/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_conftest_funcargs_only_available_in_subdir/sub1/test_in_sub1.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_1(arg1):
     pass

testing/example_scripts/fixtures/fill_fixtures/test_conftest_funcargs_only_available_in_subdir/sub2/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_conftest_funcargs_only_available_in_subdir/sub2/test_in_sub2.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_2(arg2):
     pass

testing/example_scripts/fixtures/fill_fixtures/test_detect_recursive_dependency_error.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_extend_fixture_conftest_conftest/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_extend_fixture_conftest_conftest/pkg/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_extend_fixture_conftest_conftest/pkg/test_spam.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_spam(spam):
     assert spam == "spamspam"

testing/example_scripts/fixtures/fill_fixtures/test_extend_fixture_conftest_module/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_extend_fixture_conftest_module/test_extend_fixture_conftest_module.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_extend_fixture_module_class.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_funcarg_basic.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_funcarg_lookup_classlevel.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_funcarg_lookup_modulelevel.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/fill_fixtures/test_funcarg_lookupfails.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/test_fixture_named_request.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/fixtures/test_getfixturevalue_dynamic.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/issue88_initial_file_multinodes/conftest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/issue88_initial_file_multinodes/test_hello.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_hello():
     pass

testing/example_scripts/issue_519.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pprint
 from typing import List
 from typing import Tuple

testing/example_scripts/marks/marks_considered_keywords/test_marks_as_keywords.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/perf_examples/collect_stats/generate_folders.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import argparse
 import pathlib
 

testing/example_scripts/perf_examples/collect_stats/template_test.py

@@ -1,2 +1,3 @@
+# mypy: allow-untyped-defs
 def test_x():
     pass

testing/example_scripts/tmpdir/tmp_path_fixture.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 
 

testing/example_scripts/unittest/test_parametrized_fixture_error_message.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import unittest
 
 import pytest

testing/example_scripts/unittest/test_setup_skip.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Skipping an entire subclass with unittest.skip() should *not* call setUp from a base class."""
 import unittest
 

testing/example_scripts/unittest/test_setup_skip_class.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Skipping an entire subclass with unittest.skip() should *not* call setUpClass from a base class."""
 import unittest
 

testing/example_scripts/unittest/test_setup_skip_module.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """setUpModule is always called, even if all tests in the module are skipped"""
 import unittest
 

testing/example_scripts/unittest/test_unittest_asyncio.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 from typing import List
 from unittest import IsolatedAsyncioTestCase
 

testing/example_scripts/unittest/test_unittest_asynctest.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 """Issue #7110"""
 import asyncio
 from typing import List

testing/example_scripts/unittest/test_unittest_plain_async.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import unittest
 
 

testing/example_scripts/warnings/test_group_warnings_by_message.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import warnings
 
 import pytest

testing/example_scripts/warnings/test_group_warnings_by_message_summary/test_1.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import warnings
 
 import pytest

testing/example_scripts/warnings/test_group_warnings_by_message_summary/test_2.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 from test_1 import func
 
 

testing/freeze/tests/test_trivial.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 def test_upper():
     assert "foo".upper() == "FOO"
 

testing/io/test_saferepr.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import pytest
 from _pytest._io.saferepr import DEFAULT_REPR_MAX_SIZE
 from _pytest._io.saferepr import saferepr

testing/io/test_terminalwriter.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import io
 import os
 import re

testing/logging/test_reporting.py

@@ -1,3 +1,4 @@
+# mypy: allow-untyped-defs
 import io
 import os
 import re