p53209761
/
test_ok2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

python: type some CallSpec2 fields as immutable 

Knowing that a field is immutable makes it easier to understand the
code.
This commit is contained in:
Ran Benita 2023-08-02 22:48:30 +03:00
parent 8032d21271
commit 8d815ca55b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/_pytest/python.py
View File

@ -1123,9 +1123,9 @@ class CallSpec2:
# arg name -> arg index. # arg name -> arg index.
indices: Dict[str, int] = dataclasses.field(default_factory=dict) indices: Dict[str, int] = dataclasses.field(default_factory=dict)
# Used for sorting parametrized resources. # Used for sorting parametrized resources.
_arg2scope: Dict[str, Scope] = dataclasses.field(default_factory=dict) _arg2scope: Mapping[str, Scope] = dataclasses.field(default_factory=dict)
# Parts which will be added to the item's name in `[..]` separated by "-". # Parts which will be added to the item's name in `[..]` separated by "-".
_idlist: List[str] = dataclasses.field(default_factory=list) _idlist: Sequence[str] = dataclasses.field(default_factory=tuple)
# Marks which will be applied to the item. # Marks which will be applied to the item.
marks: List[Mark] = dataclasses.field(default_factory=list) marks: List[Mark] = dataclasses.field(default_factory=list)
@ -1141,7 +1141,7 @@ class CallSpec2:
) -> "CallSpec2": ) -> "CallSpec2":
params = self.params.copy() params = self.params.copy()
indices = self.indices.copy() indices = self.indices.copy()
arg2scope = self._arg2scope.copy() arg2scope = dict(self._arg2scope)
for arg, val in zip(argnames, valset): for arg, val in zip(argnames, valset):
if arg in params: if arg in params:
raise ValueError(f"duplicate parametrization of {arg!r}") raise ValueError(f"duplicate parametrization of {arg!r}")