Remove ExceptionInfo.__str__, falling back to __repr__ (#5413)

Remove ExceptionInfo.__str__, falling back to __repr__
This commit is contained in:
Bruno Oliveira 2019-06-07 08:48:03 -03:00 committed by GitHub
commit 9f5c356784
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 18 deletions

View File

@ -0,0 +1,2 @@
``ExceptionInfo`` objects (returned by ``pytest.raises``) now have the same ``str`` representation as ``repr``, which
avoids some confusion when users use ``print(e)`` to inspect the object.

View File

@ -534,13 +534,6 @@ class ExceptionInfo:
)
return fmt.repr_excinfo(self)
def __str__(self):
if self._excinfo is None:
return repr(self)
entry = self.traceback[-1]
loc = ReprFileLocation(entry.path, entry.lineno + 1, self.exconly())
return str(loc)
def match(self, regexp):
"""
Check whether the regular expression 'regexp' is found in the string

View File

@ -333,18 +333,10 @@ def test_excinfo_exconly():
assert msg.endswith("world")
def test_excinfo_repr():
def test_excinfo_repr_str():
excinfo = pytest.raises(ValueError, h)
s = repr(excinfo)
assert s == "<ExceptionInfo ValueError tblen=4>"
def test_excinfo_str():
excinfo = pytest.raises(ValueError, h)
s = str(excinfo)
assert s.startswith(__file__[:-9]) # pyc file and $py.class
assert s.endswith("ValueError")
assert len(s.split(":")) >= 3 # on windows it's 4
assert repr(excinfo) == "<ExceptionInfo ValueError tblen=4>"
assert str(excinfo) == "<ExceptionInfo ValueError tblen=4>"
def test_excinfo_for_later():