p53209761
/
test_ok2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fixtures: require `item.fixturenames` to exist in `_fillfixtures` 

I could find 2 plugins that would be broken by this (pytest-play and
pytest-wdl), but they will be better served by just copying
`_fillfixtures` instead of use the private function.
This commit is contained in:
Ran Benita 2023-09-01 15:13:15 +03:00
parent d2b5177dd6
commit b8906b29a7
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/_pytest/fixtures.py
View File

@ -685,11 +685,7 @@ class TopRequest(FixtureRequest):
def _fillfixtures(self) -> None: def _fillfixtures(self) -> None:
item = self._pyfuncitem item = self._pyfuncitem
fixturenames = getattr(item, "fixturenames", None) for argname in item.fixturenames:
if fixturenames is None:
# Mildly expensive so don't move into the getattr!
fixturenames = self.fixturenames
for argname in fixturenames:
if argname not in item.funcargs: if argname not in item.funcargs:
item.funcargs[argname] = self.getfixturevalue(argname) item.funcargs[argname] = self.getfixturevalue(argname)