Merge pull request #9642 from pytest-dev/run-testid-with-colon-colon

allow running testids which contain :: in the parametrized portion
This commit is contained in:
Anthony Sottile 2022-02-08 08:34:49 -05:00 committed by GitHub
commit c326c04494
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 1 deletions

View File

@ -0,0 +1 @@
Fix running tests by id with ``::`` in the parametrize portion.

View File

@ -870,7 +870,10 @@ def resolve_collection_argument(
If the path doesn't exist, raise UsageError.
If the path is a directory and selection parts are present, raise UsageError.
"""
strpath, *parts = str(arg).split("::")
base, squacket, rest = str(arg).partition("[")
strpath, *parts = base.split("::")
if parts:
parts[-1] = f"{parts[-1]}{squacket}{rest}"
if as_pypath:
strpath = search_pypath(strpath)
fspath = invocation_path / strpath

View File

@ -171,6 +171,12 @@ class TestResolveCollectionArgument:
invocation_path, "pkg::foo::bar", as_pypath=True
)
def test_parametrized_name_with_colons(self, invocation_path: Path) -> None:
ret = resolve_collection_argument(
invocation_path, "src/pkg/test.py::test[a::b]"
)
assert ret == (invocation_path / "src/pkg/test.py", ["test[a::b]"])
def test_does_not_exist(self, invocation_path: Path) -> None:
"""Given a file/module that does not exist raises UsageError."""
with pytest.raises(