Merge pull request #7253 from bluetech/fixture-special-case

fixtures: remove special cases when deciding when pytest.fixture() is a direct decoration
This commit is contained in:
Ran Benita 2020-06-05 11:33:43 +03:00 committed by GitHub
commit e7c26a92d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 6 deletions

View File

@ -0,0 +1,3 @@
When using ``pytest.fixture`` on a function directly, as in ``pytest.fixture(func)``,
if the ``autouse`` or ``params`` arguments are also passed, the function is no longer
ignored, but is marked as a fixture.

View File

@ -1152,13 +1152,15 @@ def fixture(
if params is not None:
params = list(params)
if fixture_function and params is None and autouse is False:
# direct decoration
return FixtureFunctionMarker(scope, params, autouse, name=name)(
fixture_function
)
fixture_marker = FixtureFunctionMarker(
scope=scope, params=params, autouse=autouse, ids=ids, name=name,
)
return FixtureFunctionMarker(scope, params, autouse, ids=ids, name=name)
# Direct decoration.
if fixture_function:
return fixture_marker(fixture_function)
return fixture_marker
def yield_fixture(