Remove redundant if, tidy if-body

2017-10-23 16:12:07 +01:00 · 2017-10-23 16:12:07 +01:00 · ee7e1c94d2
parent de9d116a49
commit ee7e1c94d2
1 changed files with 4 additions and 5 deletions
--- a/_pytest/fixtures.py
+++ b/_pytest/fixtures.py
@ -1145,11 +1145,10 @@ class FixtureManager:
            return []
        sep = py.path.local.sep
        parts = nodeid.split(sep)
-        if parts:
-            last_part = parts[-1]
-            if '::' in last_part:
-                namespace_parts = last_part.split("::")
-                parts[-1:] = namespace_parts
+        last_part = parts[-1]
+        if '::' in last_part:
+            # Replace single last element 'test_foo.py::Bar::()' with multiple elements 'test_foo.py', 'Bar', '()'
+            parts[-1:] = last_part.split("::")
        return parts

    @classmethod