From 361f0e6ba7f1949d7daefa882be4b7c975375e1c Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Mon, 14 Oct 2019 22:44:29 +0200 Subject: [PATCH] minor: test_failure_function: use vars --- testing/test_junitxml.py | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/testing/test_junitxml.py b/testing/test_junitxml.py index 06a033489..885d25941 100644 --- a/testing/test_junitxml.py +++ b/testing/test_junitxml.py @@ -477,22 +477,25 @@ class TestPython: assert "ValueError" in fnode.toxml() systemout = fnode.next_sibling assert systemout.tag == "system-out" - assert "hello-stdout" in systemout.toxml() - assert "info msg" not in systemout.toxml() + systemout_xml = systemout.toxml() + assert "hello-stdout" in systemout_xml + assert "info msg" not in systemout_xml systemerr = systemout.next_sibling assert systemerr.tag == "system-err" - assert "hello-stderr" in systemerr.toxml() - assert "info msg" not in systemerr.toxml() + systemerr_xml = systemerr.toxml() + assert "hello-stderr" in systemerr_xml + assert "info msg" not in systemerr_xml if junit_logging == "system-out": - assert "warning msg" in systemout.toxml() - assert "warning msg" not in systemerr.toxml() + assert "warning msg" in systemout_xml + assert "warning msg" not in systemerr_xml elif junit_logging == "system-err": - assert "warning msg" not in systemout.toxml() - assert "warning msg" in systemerr.toxml() - elif junit_logging == "no": - assert "warning msg" not in systemout.toxml() - assert "warning msg" not in systemerr.toxml() + assert "warning msg" not in systemout_xml + assert "warning msg" in systemerr_xml + else: + assert junit_logging == "no" + assert "warning msg" not in systemout_xml + assert "warning msg" not in systemerr_xml @parametrize_families def test_failure_verbose_message(self, testdir, run_and_parse, xunit_family):