p53209761
/
test_ok2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nodes: keep plugins which subclass Item, File working for a bit more (#9279) 

* nodes: keep plugins which subclass Item, File working for a bit more

Fix #8435.

* Update src/_pytest/nodes.py

Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>

Co-authored-by: Florian Bruhin <me@the-compiler.org>
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
This commit is contained in:
Ran Benita 2021-11-08 16:51:04 +02:00 committed by GitHub
parent eb6c4493b2
commit f87df9c52e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/_pytest/nodes.py
View File

@ -669,9 +669,13 @@ class Item(Node):
nodeid: Optional[str] = None, nodeid: Optional[str] = None,
**kw, **kw,
) -> None: ) -> None:
# The first two arguments are intentionally passed positionally,
# to keep plugins who define a node type which inherits from
# (pytest.Item, pytest.File) working (see issue #8435).
# They can be made kwargs when the deprecation above is done.
super().__init__( super().__init__(
name=name, name,
parent=parent, parent,
config=config, config=config,
session=session, session=session,
nodeid=nodeid, nodeid=nodeid,

2
testing/test_nodes.py
View File

@ -71,7 +71,7 @@ def test_subclassing_both_item_and_collector_deprecated(
), ),
): ):
class SoWrong(nodes.File, nodes.Item): class SoWrong(nodes.Item, nodes.File):
def __init__(self, fspath, parent): def __init__(self, fspath, parent):
"""Legacy ctor with legacy call # don't wana see""" """Legacy ctor with legacy call # don't wana see"""
super().__init__(fspath, parent) super().__init__(fspath, parent)