b17c6e5f89
Merge pull request #3028 from thisch/removelogger
...
Remove logger parameter from catching_logs
2017-12-13 20:56:48 -02:00
c3f63ac143
Fix memory leak caused by fixture values never been garbage collected
...
The leak was caused by the (unused) `FixtureRequest._fixture_values`
cache.
This was introduced because the `partial` object (created to call
FixtureDef.finish() bound with the Request) is kept alive
through the entire session when a function-scoped fixture depends
on a session-scoped (or higher) fixture because of the nested
`addfinalizer` calls.
FixtureDef.finish() started receiving a request object in order to
obtain the proper hook proxy object (#2127 ), but this does not seem
useful at all in practice because `pytest_fixture_post_finalizer`
will be called with the `request` object of the moment the fixture value
was *created*, not the request object active when the fixture value
is being destroyed. We should probably deprecate/remove the request
parameter from `pytest_fixture_post_finalizer`.
Fix #2981
2017-12-13 19:49:06 -02:00
3862b0b28d
Remove logger parameter from catching_logs
...
The logger parameter of catching_logs is not used anywhere. The main
motivation for removing the logger parameter is that it removes the
logger = logger or logging.getLogger(logger)
line. IMO there are too many occurences of the string 'logg' ;)
2017-12-13 21:13:59 +01:00
476d4df1b7
Merge pull request #3010 from cryvate/fix-issue-2985
...
Improve handling of pyargs
2017-12-13 13:56:42 +01:00
52449903c3
Merge pull request #3023 from nicoddemus/preparse-deprecated
...
Add param annotations and types to hookspec
2017-12-13 13:51:20 +01:00
506c9c91c0
Merge pull request #3025 from anntzer/dont-rewrite-plugin
...
Respect PYTEST_DONT_REWRITE for plugins too.
closes #2995
2017-12-13 12:34:51 +01:00
38f34e2fa1
Merge pull request #3012 from thisch/merge_contextmanagers
...
Integrate logging_using_handler into catching_logs
2017-12-13 06:59:48 -02:00
ba41015ef6
Merge pull request #3021 from jurko-gospodnetic/cleanup
...
Code cleanup
2017-12-13 06:58:18 -02:00
ebfc1c49d1
Fix changelog formatting
2017-12-13 06:58:07 -02:00
45e7734b1a
Change set ops to use methods instead of operators.
2017-12-13 00:54:57 -08:00
8ce6e39b1c
Small formatting to CHANGELOG
2017-12-13 06:52:37 -02:00
c8e7d1ae34
Respect PYTEST_DONT_REWRITE for plugins too.
2017-12-12 17:43:17 -08:00
7b5d4d01ed
Add param annotations and types to hookspec
...
Also mention which hook to use instead of the deprecated
pytest_cmdline_preparse
Fix #3022
2017-12-12 18:01:31 -02:00
a4f4579f19
add changelog entry
2017-12-12 13:41:31 +01:00
e4da9bacdf
fix `actial` --> `actual` typo
2017-12-12 12:55:32 +01:00
1e295535c3
Move _patched_find_module to module namespace.
2017-12-12 09:53:06 +00:00
3ca1e4b7f0
Make patch for issue in pkgutil.ImpImporter local by using contextmanager.
2017-12-12 08:43:01 +00:00
dc19624248
Improve testing comments and code of issue 2985 (symlink in pyargs).
2017-12-12 08:26:40 +00:00
f8f1a52ea0
Merge remote-tracking branch 'upstream/master' into features
2017-12-11 22:18:50 -02:00
5c6d7739bc
Merge pull request #3015 from jurko-gospodnetic/code-cleanup
...
Code cleanup
2017-12-11 22:15:50 -02:00
771b5c8852
Merge pull request #3019 from srinivasreddy/rm_ast
...
remove '_ast' module; and redirect '_ast' references to 'ast'
2017-12-11 22:12:40 -02:00
fc5ec5807e
Add changelog for 3018
2017-12-11 17:40:35 -02:00
fc544dc660
remove redundant checking because
...
* isinstance([], Sequence) is True
* isinstance((), Sequence) is True
2017-12-12 00:10:59 +05:30
7792587b3f
remove unnecessary import
2017-12-12 00:03:38 +05:30
c2cd239d35
remove _ast reference from test cases as well
2017-12-11 23:24:47 +05:30
cb0ba18f53
remove '_ast' module; and redirect '_ast' references to 'ast'
2017-12-11 23:14:17 +05:30
3b85e0c3a9
simplify test_conftest_found_with_double_dash() test code
2017-12-11 15:10:04 +01:00
73bc6bacfa
add changelog entry
2017-12-09 13:34:58 +01:00
8e8a953ac6
fix test name typo
2017-12-09 13:34:58 +01:00
852b96714e
use spaces consistently instead of some of them being
2017-12-09 13:34:57 +01:00
dd64f1a4a9
fix tox.ini comment typos
2017-12-09 13:34:57 +01:00
41a6ec6f31
touch up test_cmdline_python_namespace_package() test code
2017-12-09 13:34:56 +01:00
7feab7391d
simplify test_pdb_collection_failure_is_shown test data setup code
2017-12-09 13:34:56 +01:00
f0bfe9de3d
shorten some test code
2017-12-09 13:34:56 +01:00
596937e610
remove extra whitespace
2017-12-09 13:34:55 +01:00
57fcd3f57e
remove corpse code comments
2017-12-09 13:34:55 +01:00
65f5383106
fix comment & docstring typos, line wrapping & wording
2017-12-09 13:34:54 +01:00
964c29cb93
Merge pull request #3014 from nicoddemus/cap-named-tuple
...
Change capture docs to use namedtuple
2017-12-09 09:38:39 +01:00
38fb6aae78
Change capture docs to use namedtuple
2017-12-08 18:34:29 -02:00
1c5b887dfd
Fix spelling of pytest in CHANGELOG
2017-12-08 09:04:42 -02:00
ba209b5230
Integrate logging_using_handler into catching_logs
...
logging_using_handler is only used in catching_logs. Therefore it makes
sense to remove one of the many context managers from the logging
plugin.
2017-12-07 16:34:53 +01:00
b62fd79c0c
Fix issue 2985.
2017-12-07 15:12:44 +00:00
655146e522
Merge remote-tracking branch 'upstream/master' into features
2017-12-05 22:30:35 -02:00
88f2cc9b64
Small formatting fixes in CHANGELOG
2017-12-05 22:28:56 -02:00
ed2bb9d723
Merge pull request #2997 from nicoddemus/release-3.3.1
...
Preparing release version 3.3.1
2017-12-05 22:21:41 -02:00
2a111ff700
Preparing release version 3.3.1
2017-12-05 20:41:57 +00:00
5c6758fde4
Merge pull request #3006 from The-Compiler/template-fix
...
Fix example in PR template
2017-12-05 18:35:42 -02:00
9bd8420a6b
Merge pull request #3005 from The-Compiler/blacklist-catchlog
...
Also blacklist pytest-capturelog plugin
2017-12-05 18:35:09 -02:00
cbdab02d05
Fix example in PR template
2017-12-05 20:05:35 +01:00
ce30896cd2
Also blacklist pytest-capturelog plugin
...
This is the older plugin before pytest-catchlog was around. Apparently there are
people still using it.
Fixes #3004
2017-12-05 20:02:56 +01:00
Bruno Oliveira
Thomas Hisch
Ronny Pfannschmidt
Antony Lee
Jurko Gospodnetić
Henk-Jaap Wagenaar
Srinivas Reddy Thatiparthy
Florian Bruhin