p59342861
/
monkey
forked from p15670423/monkey
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

UT: Fix windows bug in test_monkey_log_path.py 

Bug was happening due to an attempt to delete a file with an unclosed handle
This commit is contained in:
vakarisz 2022-03-30 17:58:13 +03:00
parent 72984bb3e3
commit 301284f4d0
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
monkey/infection_monkey/utils/monkey_log_path.py
View File

@ -1,3 +1,4 @@
import os
import tempfile import tempfile
import time import time
from functools import lru_cache, partial from functools import lru_cache, partial
@ -11,7 +12,8 @@ def _get_log_path(monkey_arg: str) -> Path:
prefix = f"infection-monkey-{monkey_arg}-{timestamp}-" prefix = f"infection-monkey-{monkey_arg}-{timestamp}-"
suffix = ".log" suffix = ".log"
_, monkey_log_path = tempfile.mkstemp(suffix=suffix, prefix=prefix) handle, monkey_log_path = tempfile.mkstemp(suffix=suffix, prefix=prefix)
os.close(handle)
return Path(monkey_log_path) return Path(monkey_log_path)

1
monkey/tests/unit_tests/infection_monkey/utils/test_monkey_log_path.py
View File

@ -2,6 +2,7 @@ import pytest
from infection_monkey.utils.monkey_log_path import get_agent_log_path, get_dropper_log_path from infection_monkey.utils.monkey_log_path import get_agent_log_path, get_dropper_log_path
def delete_log_file(log_path): def delete_log_file(log_path):
if log_path.is_file(): if log_path.is_file():
log_path.unlink() log_path.unlink()