From 46a71ff8f198a4b33e089af1ca53c22d2c7f81ac Mon Sep 17 00:00:00 2001
From: Mike Salvatore
Date: Wed, 13 Jul 2022 13:07:31 -0400
Subject: [PATCH] Island: Remove "default" exploits display in report
I'm not sure why this decision was made. It seems to me you'd always
want to display which exploiters were enabled during the simulation.
Telling me it was "default" means I need to go look up what the defaults
are in order to understand the report.
---
.../cc/services/reporting/report.py | 7 -------
.../report-components/SecurityReport.js | 17 ++++++-----------
2 files changed, 6 insertions(+), 18 deletions(-)
diff --git a/monkey/monkey_island/cc/services/reporting/report.py b/monkey/monkey_island/cc/services/reporting/report.py
index 27e76db85..5a9a33721 100644
--- a/monkey/monkey_island/cc/services/reporting/report.py
+++ b/monkey/monkey_island/cc/services/reporting/report.py
@@ -391,15 +391,8 @@ class ReportService:
@staticmethod
def get_config_exploits():
exploits_config_value = EXPLOITER_CLASSES_PATH
- # TODO: Return default config here
- default_exploits = ConfigService.get_default_config(False)
- for namespace in exploits_config_value:
- default_exploits = default_exploits[namespace]
exploits = ConfigService.get_config_value(exploits_config_value, True)
- if exploits == default_exploits:
- return ["default"]
-
return [
ExploiterDescriptorEnum.get_by_class_name(exploit).display_name for exploit in exploits
]
diff --git a/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js b/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js
index c79e068df..d91d2d0fc 100644
--- a/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js
+++ b/monkey/monkey_island/cc/ui/src/components/report-components/SecurityReport.js
@@ -297,17 +297,12 @@ class ReportPageComponent extends AuthComponent {
}
{
this.state.report.overview.config_exploits.length > 0 ?
- (
- this.state.report.overview.config_exploits[0] === 'default' ?
- ''
- :
-
- The Monkey uses the following exploit methods:
-
- {this.state.report.overview.config_exploits.map(x => - {x}
)}
-
-
- )
+
+ The Monkey uses the following exploit methods:
+
+ {this.state.report.overview.config_exploits.map(x => - {x}
)}
+
+
:
No exploits are used by the Monkey.