From 92156946fe5e5fd6cf8bcfed013497cd40603f2f Mon Sep 17 00:00:00 2001
From: Shay Nehmad <shay.nehmad@guardicore.com>
Date: Mon, 19 Aug 2019 14:59:10 +0300
Subject: [PATCH] Added docs for function
---
.../cc/services/reporting/zero_trust_service.py | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/monkey/monkey_island/cc/services/reporting/zero_trust_service.py b/monkey/monkey_island/cc/services/reporting/zero_trust_service.py
index bbe82f049..d28b072d8 100644
--- a/monkey/monkey_island/cc/services/reporting/zero_trust_service.py
+++ b/monkey/monkey_island/cc/services/reporting/zero_trust_service.py
@@ -86,12 +86,17 @@ class ZeroTrustService(object):
@staticmethod
def __get_lcd_worst_status_for_test(all_findings_for_test):
- current_status = STATUS_UNEXECUTED
+ """
+ :param all_findings_for_test: All findings of a specific test (get this using Finding.objects(test={A_TEST}))
+ :return: the "worst" (i.e. most severe) status out of the given findings.
+ lcd stands for lowest common denominator.
+ """
+ current_worst_status = STATUS_UNEXECUTED
for finding in all_findings_for_test:
- if ORDERED_TEST_STATUSES.index(finding.status) < ORDERED_TEST_STATUSES.index(current_status):
- current_status = finding.status
+ if ORDERED_TEST_STATUSES.index(finding.status) < ORDERED_TEST_STATUSES.index(current_worst_status):
+ current_worst_status = finding.status
- return current_status
+ return current_worst_status
@staticmethod
def get_all_findings():