From d811c6548cef36f8e92db5229bb8c7a776a71c17 Mon Sep 17 00:00:00 2001 From: Kekoa Kaaikala Date: Thu, 29 Sep 2022 11:30:31 -0400 Subject: [PATCH] Island: Prefer existing OS data to ping OS data Co-authored-by: Mike Salvatore --- .../cc/agent_event_handlers/handle_ping_scan_event.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monkey/monkey_island/cc/agent_event_handlers/handle_ping_scan_event.py b/monkey/monkey_island/cc/agent_event_handlers/handle_ping_scan_event.py index 9ea022e4a..f0a98757b 100644 --- a/monkey/monkey_island/cc/agent_event_handlers/handle_ping_scan_event.py +++ b/monkey/monkey_island/cc/agent_event_handlers/handle_ping_scan_event.py @@ -65,6 +65,6 @@ class handle_ping_scan_event: return self._machine_repository.get_machine_by_id(agent.machine_id) def _update_destination_machine(self, machine: Machine, event: PingScanEvent): - if event.os is not None: + if event.os is not None and machine.operating_system is None: machine.operating_system = event.os self._machine_repository.upsert_machine(machine)