Commit Graph

1257 Commits

Author SHA1 Message Date
Oran Nadler b54eb89330 Add 'Two machines should not share any local admin.' report 2018-05-15 11:10:32 +03:00
Daniel Goldberg 4d7cff9fdb
Merge pull request #132 from cclauss/patch-2
ftp.py: Undefined name local_ip --> self.local_ip
2018-05-08 19:06:44 +03:00
Daniel Goldberg e19e609fae
Merge pull request #131 from cclauss/patch-1
Travis CI for automated testing of all pull requests
2018-05-08 18:36:29 +03:00
Oran Nadler e672e26f71 handle the PartCoponent issue in the report 2018-05-08 17:25:46 +03:00
Oran Nadler 7af6e6473c Handle the Win32_GroupUser missing PartCompenent issue 2018-05-08 17:05:33 +03:00
Oran Nadler 588387a263 typo 2018-05-08 16:12:51 +03:00
Oran Nadler 404da6e6d6 typo 2018-05-08 15:48:53 +03:00
Oran Nadler 0ca804d4e3 add comment 2018-05-08 15:44:05 +03:00
Oran Nadler 4c1d0bfff5 add ldap wmi queries 2018-05-08 15:40:38 +03:00
cclauss 023c7cb093
ftp.py: Undefined name local_ip --> self.local_ip
__local_ip__ is an __undefined name__ in this context (could raise NameError at runtime) so this PR recommends the use of __self.local_ip__ instead.  

flake8 testing of https://github.com/guardicore/monkey on Python 3.6.3

$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__
```
./infection_monkey/transport/ftp.py:86:29: F821 undefined name 'local_ip'
        self.servsock.bind((local_ip,0))
                            ^
```
2018-05-08 12:23:30 +02:00
Daniel Goldberg 2bc87794b7
Merge pull request #130 from cclauss/long-was-removed-in-Python3
long was removed in Python 3
2018-05-08 13:06:36 +03:00
Daniel Goldberg 1af9ffc0d4
Merge pull request #129 from cclauss/new-style-exceptions
New style exceptions, has_key(), and types
2018-05-08 13:05:08 +03:00
cclauss 9cd839abf6
Travis CI for automated testing of all pull requests
Travis Continuous Integration is free for all open source projects like this one.  This config file would have Travis CI run [flake8](http://flake8.pycqa.org) tests to find Python syntax errors and undefined names in all pull requests _before_ they are reviewed.  To turn Travis CI on, visit https://travis-ci.com/guardicore
2018-05-07 17:19:28 +02:00
cclauss 0bb0cfbd5d long was removed in Python 3 2018-05-07 16:48:49 +02:00
cclauss bc76ea977b New style exceptions, has_key(), and types 2018-05-07 16:24:11 +02:00
Daniel Goldberg b2b67d3034 Update issue templates 2018-05-05 18:36:42 +03:00
Daniel Goldberg b6e39280be Spacing in __str__ method of VictimHost 2018-05-05 16:23:58 +03:00
Daniel Goldberg 3423290a37
Update where we want PRs to go to 2018-05-04 18:44:21 +03:00
Daniel Goldberg e80e004fae
Merge pull request #123 from goswami-rahul/patch-1
update __repr__ method in VictimHost class
2018-05-04 18:42:48 +03:00
theonlydoo 58d7f6de50 quickwin dockerization 2018-05-04 17:23:10 +02:00
Rahul Goswami 7503a77ff7
update __repr__ method in VictimHost class
- __repr__ method should return the standard constructor string (pep8)
2018-05-03 00:50:02 +05:30
Daniel Goldberg 0937ebb520
Remove year in the license 2018-05-01 15:12:30 +03:00
Itay Mizeretz b83ca0536f Merge branch 'develop' into feature/detect-cross-segment-traffic
# Conflicts:
#	infection_monkey/network/network_scanner.py
#	monkey_island/cc/services/report.py
2018-04-30 20:38:13 +03:00
Oran Nadler 72fa6bbd68 no need to eval SidType 2018-04-30 18:42:30 +03:00
Oran Nadler 1d25ba9085 check SidType everywhere to make sure we don't have type errors 2018-04-30 18:40:11 +03:00
Oran Nadler 9594fab1a2 shared users seems to work 2018-04-30 18:15:10 +03:00
Oran Nadler 8ab880340f don't count DomainAdmins as shared admins 2018-04-30 17:58:15 +03:00
Oran Nadler 0025d242d7 fix 2018-04-30 17:50:38 +03:00
Oran Nadler 99ee46c38a add unique local admin 2018-04-30 17:48:21 +03:00
Oran Nadler d83dad727d remove secret from display 2018-04-30 16:53:48 +03:00
Oran Nadler 2e3401f285 fix 2018-04-30 16:51:07 +03:00
Oran Nadler b49ba7526f fix 2018-04-30 16:48:42 +03:00
Oran Nadler d59e464578 only take running services 2018-04-30 16:44:43 +03:00
Oran Nadler ebda00b333 add list of critical services installed 2018-04-30 16:28:29 +03:00
Oran Nadler 5692d1dc86 add dns service to critical services 2018-04-30 16:19:58 +03:00
Daniel Goldberg a6d0a18313
Merge pull request #118 from VakarisZ/102_issue_fix
Bugfix(102) V under report generated after new monkey ran
2018-04-30 11:52:00 +03:00
Vakaris 5027c9b15b Tick under report, while map is still running fixed. Now tick only apears after map generation is finished. 2018-04-29 20:14:17 +03:00
Oran Nadler f7556b0930 fix 2018-04-17 15:57:44 +03:00
Oran Nadler c308532ff4 show low sevirity threat users 2018-04-17 15:54:03 +03:00
Oran Nadler e17f9b8273 fix 2018-04-17 15:02:49 +03:00
Oran Nadler 807606dae2 i think this is also a bug 2018-04-17 15:00:22 +03:00
Oran Nadler 29fac1a960 fix 2018-04-17 14:59:06 +03:00
Oran Nadler 0d4e28b55b small fixes 2018-04-17 14:43:26 +03:00
Daniel Goldberg 6dc1f6f661
Merge pull request #117 from guardicore/develop
Merge develop into master
2018-04-17 14:39:07 +03:00
Daniel Goldberg 3f0569a29e EG bugfixes
- Use dropper instead of monkey
 - Run disconnected shell
 - Check for dropper log instead of monkey log
2018-04-17 14:34:26 +03:00
Daniel Goldberg 4e5334f177 Fix possible bug when handling passwords with unicode characters #2 2018-04-17 14:23:00 +03:00
Daniel Goldberg 558fa749ca Bugfix in dropper.py, handle gracefully failure in cleanup 2018-04-17 14:20:21 +03:00
Daniel Goldberg cc4ad05be8 Bugfix in dropper.py, return value in all fail paths 2018-04-17 14:16:46 +03:00
Oran Nadler 7a7729c212 add threatning users to report 2018-04-17 13:58:47 +03:00
Oran Nadler 13bf7107c9 BUGFIX: Take the latest info_collection got from machine instead of oldest 2018-04-17 13:30:55 +03:00