feat(object): return 404 page when user, tag and question not found.

internal/controller/template_controller.go

@@ -404,22 +404,17 @@ func (tc *TemplateController) UserInfo(ctx *gin.Context) {
 	req := &schema.GetOtherUserInfoByUsernameReq{}
 	req.Username = username
 	userinfo, err := tc.templateRenderController.UserInfo(ctx, req)
-
 	if err != nil {
 		tc.Page404(ctx)
 		return
 	}
-	if !userinfo.Has {
-		tc.Page404(ctx)
-		return
-	}
 
 	siteInfo := tc.SiteInfo(ctx)
 	siteInfo.Canonical = fmt.Sprintf("%s/users/%s", siteInfo.General.SiteUrl, username)
 	siteInfo.Title = fmt.Sprintf("%s - %s", username, siteInfo.General.Name)
 	tc.html(ctx, http.StatusOK, "homepage.html", siteInfo, gin.H{
 		"userinfo": userinfo,
-		"bio":      template.HTML(userinfo.Info.BioHTML),
+		"bio":      template.HTML(userinfo.BioHTML),
 	})
 
 }

internal/controller/template_render/userinfo.go

@@ -5,6 +5,6 @@ import (
 	"golang.org/x/net/context"
 )
 
-func (q *TemplateRenderController) UserInfo(ctx context.Context, req *schema.GetOtherUserInfoByUsernameReq) (resp *schema.GetOtherUserInfoResp, err error) {
+func (q *TemplateRenderController) UserInfo(ctx context.Context, req *schema.GetOtherUserInfoByUsernameReq) (resp *schema.GetOtherUserInfoByUsernameResp, err error) {
 	return q.userService.GetOtherUserInfoByUsername(ctx, req.Username)
 }

internal/schema/user_schema.go

@@ -386,7 +386,6 @@ type GetOtherUserInfoByUsernameReq struct {
 
 type GetOtherUserInfoResp struct {
 	Info *GetOtherUserInfoByUsernameResp `json:"info"`
-	Has  bool                            `json:"has"`
 }
 
 type UserChangeEmailSendCodeReq struct {

internal/service/question_common/question.go

@@ -148,7 +148,7 @@ func (qs *QuestionCommon) Info(ctx context.Context, questionID string, loginUser
 		return showinfo, err
 	}
 	if !has {
-		return showinfo, errors.BadRequest(reason.QuestionNotFound)
+		return showinfo, errors.NotFound(reason.QuestionNotFound)
 	}
 	showinfo = qs.ShowFormat(ctx, dbinfo)
 

internal/service/tag/tag_service.go

@@ -102,7 +102,7 @@ func (ts *TagService) GetTagInfo(ctx context.Context, req *schema.GetTagInfoReq)
 		return nil, err
 	}
 	if !exist {
-		return nil, errors.BadRequest(reason.TagNotFound)
+		return nil, errors.NotFound(reason.TagNotFound)
 	}
 
 	resp = &schema.GetTagResp{}
@@ -113,7 +113,7 @@ func (ts *TagService) GetTagInfo(ctx context.Context, req *schema.GetTagInfoReq)
 			return nil, err
 		}
 		if !exist {
-			return nil, errors.BadRequest(reason.TagNotFound)
+			return nil, errors.NotFound(reason.TagNotFound)
 		}
 		resp.MainTagSlugName = tagInfo.SlugName
 	}

internal/service/user_service.go

@@ -86,19 +86,17 @@ func (us *UserService) GetUserInfoByUserID(ctx context.Context, token, userID st
 }
 
 func (us *UserService) GetOtherUserInfoByUsername(ctx context.Context, username string) (
-	resp *schema.GetOtherUserInfoResp, err error,
+	resp *schema.GetOtherUserInfoByUsernameResp, err error,
 ) {
 	userInfo, exist, err := us.userRepo.GetByUsername(ctx, username)
 	if err != nil {
 		return nil, err
 	}
-	resp = &schema.GetOtherUserInfoResp{}
 	if !exist {
-		return resp, nil
+		return nil, errors.NotFound(reason.UserNotFound)
 	}
-	resp.Has = true
+	resp = &schema.GetOtherUserInfoByUsernameResp{}
-	resp.Info = &schema.GetOtherUserInfoByUsernameResp{}
+	resp.GetFromUserEntity(userInfo)
-	resp.Info.GetFromUserEntity(userInfo)
 	return resp, nil
 }
 

ui/template/homepage.html

@@ -3,28 +3,28 @@
                 <div class="justify-content-center row">
                     <div class="col-xxl-7 col-lg-8 col-sm-12">
                         <div class="d-flex flex-column flex-md-row mb-4">
-                            <a href="/users/{{.userinfo.Info.Username}}"><img
+                            <a href="/users/{{.userinfo.Username}}"><img
-                                    src="{{.userinfo.Info.Avatar}}"
+                                    src="{{.userinfo.Avatar}}"
                                     width="160px" height="160px" class="rounded" alt="" /></a>
                             <div class="ms-0 ms-md-4 mt-4 mt-md-0">
                                 <div class="d-flex align-items-center mb-2">
-                                    <a class="link-dark h3 mb-0" href="/users/{{.userinfo.Info.Username}}">{{.userinfo.Info.DisplayName}}</a>
+                                    <a class="link-dark h3 mb-0" href="/users/{{.userinfo.Username}}">{{.userinfo.DisplayName}}</a>
 
                                 </div>
-                                <div class="text-secondary mb-4">@{{.userinfo.Info.Username}}</div>
+                                <div class="text-secondary mb-4">@{{.userinfo.Username}}</div>
                                 <div class="d-flex flex-wrap mb-3">
                                     <div class="me-3">
-                                        <strong class="fs-5">{{.userinfo.Info.Rank}}</strong><span class="text-secondary"> {{translator $.language "ui.personal.x_reputation"}}</span>
+                                        <strong class="fs-5">{{.userinfo.Rank}}</strong><span class="text-secondary"> {{translator $.language "ui.personal.x_reputation"}}</span>
                                     </div>
                                     <div class="me-3">
-                                        <strong class="fs-5">{{.userinfo.Info.AnswerCount}}</strong><span class="text-secondary"> {{translator $.language "ui.personal.x_answers"}}</span>
+                                        <strong class="fs-5">{{.userinfo.AnswerCount}}</strong><span class="text-secondary"> {{translator $.language "ui.personal.x_answers"}}</span>
                                     </div>
                                     <div>
-                                        <strong class="fs-5">{{.userinfo.Info.QuestionCount}}</strong><span class="text-secondary"> {{translator $.language "ui.personal.x_questions"}}</span>
+                                        <strong class="fs-5">{{.userinfo.QuestionCount}}</strong><span class="text-secondary"> {{translator $.language "ui.personal.x_questions"}}</span>
                                     </div>
                                 </div>
-                                {{if .userinfo.Info.Website }}
+                                {{if .userinfo.Website }}
-                                <div class="d-flex align-items-center"><i class="br bi-house-door-fill me-2"></i><a class="link-secondary" href="{{.userinfo.Info.Website}}">{{.userinfo.Info.Website}}</a></div>
+                                <div class="d-flex align-items-center"><i class="br bi-house-door-fill me-2"></i><a class="link-secondary" href="{{.userinfo.Website}}">{{.userinfo.Website}}</a></div>
                                 {{else}}
                                 {{end}}
                                 <div class="d-flex text-secondary"></div>