test-version22
/
MeterSphere
mirror of https://gitee.com/fit2cloud-feizhiyun/MeterSphere.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: --bug=1005746 --user=陈建星 【github#5354】非用例评审人员可通过脑图评审用例 https://www.tapd.cn/55049933/s/1043022

This commit is contained in:
chenjianxing 2021-09-02 13:51:58 +08:00 committed by jianxing
parent f51542882d
commit 061b2210d1
4 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
backend/src/main/java/io/metersphere/track/controller/TestReviewTestCaseController.java
View File

@ -48,10 +48,10 @@ public class TestReviewTestCaseController {
testReviewTestCaseService.editTestCaseBatchStatus(request); testReviewTestCaseService.editTestCaseBatchStatus(request);
} }
@PostMapping("/minder/edit") @PostMapping("/minder/edit/{reviewId}")
@MsAuditLog(module = "track_test_case_review", type = OperLogConstants.ASSOCIATE_CASE, content = "#msClass.getLogDetails(#testCases)", msClass = TestReviewTestCaseService.class) @MsAuditLog(module = "track_test_case_review", type = OperLogConstants.ASSOCIATE_CASE, content = "#msClass.getLogDetails(#testCases)", msClass = TestReviewTestCaseService.class)
public void editTestCaseForMinder(@RequestBody List<TestCaseReviewTestCase> testCases) { public void editTestCaseForMinder(@PathVariable("reviewId") String reviewId, @RequestBody List<TestCaseReviewTestCase> testCases) {
testReviewTestCaseService.editTestCaseForMinder(testCases); testReviewTestCaseService.editTestCaseForMinder(reviewId, testCases);
} }
@PostMapping("/list/minder") @PostMapping("/list/minder")

3
backend/src/main/java/io/metersphere/track/service/TestReviewTestCaseService.java
View File

@ -229,7 +229,8 @@ public class TestReviewTestCaseService {
} }
} }
public void editTestCaseForMinder(List<TestCaseReviewTestCase> testCaseReviewTestCases) { public void editTestCaseForMinder(String reviewId, List<TestCaseReviewTestCase> testCaseReviewTestCases) {
checkReviewCase(reviewId);
if (!CollectionUtils.isEmpty(testCaseReviewTestCases)) { if (!CollectionUtils.isEmpty(testCaseReviewTestCases)) {
List<TestCaseWithBLOBs> testCaseList = new ArrayList<>(); List<TestCaseWithBLOBs> testCaseList = new ArrayList<>();
testCaseReviewTestCases.forEach((item) -> { testCaseReviewTestCases.forEach((item) -> {

2
frontend/src/business/components/track/common/minder/TestReviewMinder.vue
View File

@ -111,7 +111,7 @@ name: "TestReviewMinder",
save(data) { save(data) {
let saveCases = []; let saveCases = [];
this.buildSaveCase(data.root, saveCases); this.buildSaveCase(data.root, saveCases);
this.result = this.$post('/test/review/case/minder/edit', saveCases, () => { this.result = this.$post('/test/review/case/minder/edit/' + this.reviewId, saveCases, () => {
this.$success(this.$t('commons.save_success')); this.$success(this.$t('commons.save_success'));
}); });
}, },

6
frontend/src/common/js/utils.js
View File

@ -390,11 +390,11 @@ function clearPageSetup(){
hkey_root="HKEY_CURRENT_USER"; hkey_root="HKEY_CURRENT_USER";
hkey_path="\\Software\\Microsoft\\Internet Explorer\\PageSetup\\"; hkey_path="\\Software\\Microsoft\\Internet Explorer\\PageSetup\\";
try{ try{
let RegWsh = new ActiveXObject("WScript.Shell"); let regWsh = new ActiveXObject("WScript.Shell");
hkey_key="header"; hkey_key="header";
RegWsh.RegWrite(hkey_root+hkey_path+hkey_key,""); regWsh.RegWrite(hkey_root+hkey_path+hkey_key,"");
hkey_key="footer"; hkey_key="footer";
RegWsh.RegWrite(hkey_root+hkey_path+hkey_key,""); regWsh.RegWrite(hkey_root+hkey_path+hkey_key,"");
}catch(e){} }catch(e){}
} }