diff --git a/backend/src/main/java/io/metersphere/track/service/TestCaseReviewService.java b/backend/src/main/java/io/metersphere/track/service/TestCaseReviewService.java index cb1e875d35..aba21779ec 100644 --- a/backend/src/main/java/io/metersphere/track/service/TestCaseReviewService.java +++ b/backend/src/main/java/io/metersphere/track/service/TestCaseReviewService.java @@ -360,9 +360,16 @@ public class TestCaseReviewService { public void testReviewRelevance(ReviewRelevanceRequest request) { String reviewId = request.getReviewId(); List userIds = getTestCaseReviewerIds(reviewId); + + String creator = ""; + TestCaseReview review = testCaseReviewMapper.selectByPrimaryKey(reviewId); + if (review != null) { + creator = review.getCreator(); + } + String currentId = SessionUtils.getUser().getId(); - if (!userIds.contains(currentId)) { - MSException.throwException("非用例评审人员,不能关联用例!"); + if (!userIds.contains(currentId) && !StringUtils.equals(creator, currentId)) { + MSException.throwException("没有权限,不能关联用例!"); } List testCaseIds = request.getTestCaseIds(); diff --git a/backend/src/main/java/io/metersphere/track/service/TestReviewTestCaseService.java b/backend/src/main/java/io/metersphere/track/service/TestReviewTestCaseService.java index ab6d852dfe..9ba0d15bab 100644 --- a/backend/src/main/java/io/metersphere/track/service/TestReviewTestCaseService.java +++ b/backend/src/main/java/io/metersphere/track/service/TestReviewTestCaseService.java @@ -87,8 +87,13 @@ public class TestReviewTestCaseService { private void checkReviewer(String reviewId) { List userIds = testCaseReviewService.getTestCaseReviewerIds(reviewId); String currentId = SessionUtils.getUser().getId(); - if (!userIds.contains(currentId)) { - MSException.throwException("非用例评审人员,不能解除用例关联!"); + TestCaseReview caseReview = testCaseReviewMapper.selectByPrimaryKey(reviewId); + String creator = ""; + if (caseReview != null) { + creator = caseReview.getCreator(); + } + if (!userIds.contains(currentId) && !StringUtils.equals(creator, currentId)) { + MSException.throwException("没有权限,不能解除用例关联!"); } }