fix(测试计划): 更新测试计划不生效问题
This commit is contained in:
parent
38975938aa
commit
796294ca3e
|
@ -51,5 +51,5 @@ public class TestPlanUpdateRequest {
|
|||
private Double passThreshold;
|
||||
|
||||
@Schema(description = "测试计划组Id")
|
||||
private String testPlanGroupId = TestPlanConstants.TEST_PLAN_DEFAULT_GROUP_ID;
|
||||
private String groupId = TestPlanConstants.TEST_PLAN_DEFAULT_GROUP_ID;
|
||||
}
|
||||
|
|
|
@ -321,7 +321,7 @@ public class TestPlanService extends TestPlanBaseUtilsService {
|
|||
public TestPlan update(TestPlanUpdateRequest request, String userId, String requestUrl, String requestMethod) {
|
||||
this.checkTestPlanNotArchived(request.getId());
|
||||
TestPlan testPlan = testPlanMapper.selectByPrimaryKey(request.getId());
|
||||
if (!ObjectUtils.allNull(request.getName(), request.getModuleId(), request.getTags(), request.getPlannedEndTime(), request.getPlannedStartTime(), request.getDescription(), request.getTestPlanGroupId())) {
|
||||
if (!ObjectUtils.allNull(request.getName(), request.getModuleId(), request.getTags(), request.getPlannedEndTime(), request.getPlannedStartTime(), request.getDescription(), request.getGroupId())) {
|
||||
TestPlan updateTestPlan = new TestPlan();
|
||||
updateTestPlan.setId(request.getId());
|
||||
if (StringUtils.isNotBlank(request.getModuleId())) {
|
||||
|
@ -341,7 +341,7 @@ public class TestPlanService extends TestPlanBaseUtilsService {
|
|||
updateTestPlan.setPlannedStartTime(request.getPlannedStartTime());
|
||||
updateTestPlan.setPlannedEndTime(request.getPlannedEndTime());
|
||||
updateTestPlan.setDescription(request.getDescription());
|
||||
updateTestPlan.setGroupId(request.getTestPlanGroupId());
|
||||
updateTestPlan.setGroupId(request.getGroupId());
|
||||
updateTestPlan.setType(testPlan.getType());
|
||||
testPlanMapper.updateByPrimaryKeySelective(updateTestPlan);
|
||||
}
|
||||
|
|
|
@ -1164,11 +1164,11 @@ public class TestPlanTests extends BaseTest {
|
|||
|
||||
//修改a2节点下的数据(91,92)的所属测试计划组
|
||||
updateRequest = testPlanTestService.generateUpdateRequest(testPlanTestService.selectTestPlanByName("testPlan_91").getId());
|
||||
updateRequest.setTestPlanGroupId(groupTestPlanId7);
|
||||
updateRequest.setGroupId(groupTestPlanId7);
|
||||
this.requestPostWithOk(URL_POST_TEST_PLAN_UPDATE, updateRequest);
|
||||
a2NodeCount--;
|
||||
updateRequest = testPlanTestService.generateUpdateRequest(testPlanTestService.selectTestPlanByName("testPlan_92").getId());
|
||||
updateRequest.setTestPlanGroupId(groupTestPlanId7);
|
||||
updateRequest.setGroupId(groupTestPlanId7);
|
||||
this.requestPostWithOk(URL_POST_TEST_PLAN_UPDATE, updateRequest);
|
||||
a2NodeCount--;
|
||||
|
||||
|
|
|
@ -299,8 +299,8 @@ public class TestPlanTestService {
|
|||
}
|
||||
}
|
||||
|
||||
if (updateRequest.getTestPlanGroupId() != null) {
|
||||
Assertions.assertEquals(newTestPlan.getGroupId(), updateRequest.getTestPlanGroupId());
|
||||
if (updateRequest.getGroupId() != null) {
|
||||
Assertions.assertEquals(newTestPlan.getGroupId(), updateRequest.getGroupId());
|
||||
} else {
|
||||
Assertions.assertEquals(newTestPlan.getGroupId(), testPlan.getGroupId());
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue