From cbf4c3a8cc5961381e8dfb6b5dcf2920bf7a8274 Mon Sep 17 00:00:00 2001
From: shiziyuan9527 <yuhao.li@fit2cloud.com>
Date: Tue, 19 May 2020 16:27:40 +0800
Subject: [PATCH 1/3] =?UTF-8?q?=E7=B3=BB=E7=BB=9F=E7=94=A8=E6=88=B7?=
 =?UTF-8?q?=E5=88=97=E8=A1=A8=E8=A7=92=E8=89=B2=E5=88=97?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../controller/UserController.java            |  9 +++-
 .../java/io/metersphere/dto/UserRoleDTO.java  | 18 ++++++++
 .../io/metersphere/service/UserService.java   | 18 +++++---
 .../components/settings/system/User.vue       | 41 +++++++++++++++----
 4 files changed, 70 insertions(+), 16 deletions(-)
 create mode 100644 backend/src/main/java/io/metersphere/dto/UserRoleDTO.java

diff --git a/backend/src/main/java/io/metersphere/controller/UserController.java b/backend/src/main/java/io/metersphere/controller/UserController.java
index 55324f028e..e6314d2788 100644
--- a/backend/src/main/java/io/metersphere/controller/UserController.java
+++ b/backend/src/main/java/io/metersphere/controller/UserController.java
@@ -17,15 +17,14 @@ import io.metersphere.controller.request.member.SetAdminRequest;
 import io.metersphere.controller.request.organization.AddOrgMemberRequest;
 import io.metersphere.controller.request.organization.QueryOrgMemberRequest;
 import io.metersphere.dto.UserDTO;
+import io.metersphere.dto.UserRoleDTO;
 import io.metersphere.service.OrganizationService;
 import io.metersphere.service.UserService;
 import io.metersphere.service.WorkspaceService;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.shiro.authz.annotation.Logical;
 import org.apache.shiro.authz.annotation.RequiresRoles;
-import org.springframework.beans.BeanUtils;
 import org.springframework.web.bind.annotation.*;
-
 import javax.annotation.Resource;
 import java.util.List;
 
@@ -54,6 +53,12 @@ public class UserController {
         return PageUtils.setPageInfo(page, userService.getUserListWithRequest(request));
     }
 
+    @GetMapping("/special/user/role/{userId}")
+    @RequiresRoles(RoleConstants.ADMIN)
+    public UserRoleDTO getUserRole(@PathVariable("userId") String userId) {
+        return userService.getUserRole(userId);
+    }
+
     @GetMapping("/special/delete/{userId}")
     @RequiresRoles(RoleConstants.ADMIN)
     public void deleteUser(@PathVariable(value = "userId") String userId) {
diff --git a/backend/src/main/java/io/metersphere/dto/UserRoleDTO.java b/backend/src/main/java/io/metersphere/dto/UserRoleDTO.java
new file mode 100644
index 0000000000..80009d51c3
--- /dev/null
+++ b/backend/src/main/java/io/metersphere/dto/UserRoleDTO.java
@@ -0,0 +1,18 @@
+package io.metersphere.dto;
+
+import io.metersphere.base.domain.Role;
+import io.metersphere.base.domain.UserRole;
+import lombok.Getter;
+import lombok.Setter;
+import java.util.List;
+
+@Getter
+@Setter
+public class UserRoleDTO {
+
+    private String userId;
+    private List<Role> roles;
+    private List<UserRole> userRoles;
+    private static final long serialVersionUID = 1L;
+
+}
diff --git a/backend/src/main/java/io/metersphere/service/UserService.java b/backend/src/main/java/io/metersphere/service/UserService.java
index 7ee198862b..f0c9a24416 100644
--- a/backend/src/main/java/io/metersphere/service/UserService.java
+++ b/backend/src/main/java/io/metersphere/service/UserService.java
@@ -17,13 +17,13 @@ import io.metersphere.controller.request.member.SetAdminRequest;
 import io.metersphere.controller.request.organization.AddOrgMemberRequest;
 import io.metersphere.controller.request.organization.QueryOrgMemberRequest;
 import io.metersphere.dto.UserDTO;
+import io.metersphere.dto.UserRoleDTO;
 import io.metersphere.i18n.Translator;
 import org.apache.commons.lang3.StringUtils;
 import org.springframework.beans.BeanUtils;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 import org.springframework.util.CollectionUtils;
-
 import javax.annotation.Resource;
 import java.util.List;
 import java.util.UUID;
@@ -100,16 +100,24 @@ public class UserService {
         }
         UserDTO userDTO = new UserDTO();
         BeanUtils.copyProperties(user, userDTO);
+        UserRoleDTO userRole = getUserRole(userId);
+        userDTO.setUserRoles(userRole.getUserRoles());
+        userDTO.setRoles(userRole.getRoles());
+        return userDTO;
+    }
+
+    public UserRoleDTO getUserRole(String userId) {
+        UserRoleDTO userRoleDTO = new UserRoleDTO();
         //
         UserRoleExample userRoleExample = new UserRoleExample();
         userRoleExample.createCriteria().andUserIdEqualTo(userId);
         List<UserRole> userRoleList = userRoleMapper.selectByExample(userRoleExample);
 
         if (CollectionUtils.isEmpty(userRoleList)) {
-            return userDTO;
+            return userRoleDTO;
         }
         // 设置 user_role
-        userDTO.setUserRoles(userRoleList);
+        userRoleDTO.setUserRoles(userRoleList);
 
         List<String> roleIds = userRoleList.stream().map(UserRole::getRoleId).collect(Collectors.toList());
 
@@ -117,9 +125,9 @@ public class UserService {
         roleExample.createCriteria().andIdIn(roleIds);
 
         List<Role> roleList = roleMapper.selectByExample(roleExample);
-        userDTO.setRoles(roleList);
+        userRoleDTO.setRoles(roleList);
 
-        return userDTO;
+        return userRoleDTO;
     }
 
     public List<User> getUserList() {
diff --git a/frontend/src/business/components/settings/system/User.vue b/frontend/src/business/components/settings/system/User.vue
index aaf7ca4ca1..56d1dc0389 100644
--- a/frontend/src/business/components/settings/system/User.vue
+++ b/frontend/src/business/components/settings/system/User.vue
@@ -1,7 +1,7 @@
 <template>
   <div v-loading="result.loading">
 
-     <el-card class="table-card">
+    <el-card class="table-card">
       <template v-slot:header>
         <ms-table-header :condition.sync="condition" @search="search" @create="create"
                          :create-tip="$t('user.create')" :title="$t('commons.member')"/>
@@ -9,7 +9,12 @@
 
       <el-table :data="tableData" style="width: 100%">
         <el-table-column prop="id" label="ID"/>
-        <el-table-column prop="name" :label="$t('commons.username')"/>
+        <el-table-column prop="name" :label="$t('commons.username')" width="200"/>
+        <el-table-column :label="$t('commons.role')" width="120">
+          <template v-slot:default="scope">
+            <ms-roles-tag :roles="scope.row.roles"/>
+          </template>
+        </el-table-column>
         <el-table-column prop="email" :label="$t('commons.email')"/>
         <el-table-column prop="status" :label="$t('commons.status')">
           <template v-slot:default="scope">
@@ -22,7 +27,7 @@
             />
           </template>
         </el-table-column>
-        <el-table-column prop="createTime" :label="$t('commons.create_time')" width="180">
+        <el-table-column prop="createTime" :label="$t('commons.create_time')">
           <template v-slot:default="scope">
             <span>{{ scope.row.createTime | timestampFormatDate }}</span>
           </template>
@@ -108,14 +113,14 @@
           @confirm="updateUser('updateUserForm')"/>
       </template>
     </el-dialog>
-   <!--Changing user password in system settings-->
+    <!--Changing user password in system settings-->
     <el-dialog :title="$t('member.edit_password')" :visible.sync="editPasswordVisible" width="30%" left>
       <el-form :model="ruleForm" label-position="right" label-width="100px" size="small" :rules="rule"
                ref="editPasswordForm" class="demo-ruleForm">
         <el-form-item :label="$t('member.new_password')" prop="newpassword">
           <el-input type="password" v-model="ruleForm.newpassword" autocomplete="off" show-password></el-input>
         </el-form-item>
-        <el-form-item >
+        <el-form-item>
           <el-input v-model="ruleForm.id" autocomplete="off" :disabled="true" style="display:none"/>
         </el-form-item>
       </el-form>
@@ -137,10 +142,19 @@
   import MsDialogFooter from "../../common/components/MsDialogFooter";
   import MsTableOperatorButton from "../../common/components/MsTableOperatorButton";
   import {getCurrentUser} from "../../../../common/js/utils";
+  import MsRolesTag from "../../common/components/MsRolesTag";
 
   export default {
     name: "MsUser",
-    components: {MsCreateBox, MsTablePagination, MsTableHeader, MsTableOperator, MsDialogFooter, MsTableOperatorButton},
+    components: {
+      MsCreateBox,
+      MsTablePagination,
+      MsTableHeader,
+      MsTableOperator,
+      MsDialogFooter,
+      MsTableOperatorButton,
+      MsRolesTag
+    },
     data() {
       return {
         queryPath: '/user/special/list',
@@ -271,9 +285,9 @@
           }
         })
       },
-      editUserPassword(editPasswordForm){
-        this.$refs[editPasswordForm].validate(valid=>{
-          if(valid){
+      editUserPassword(editPasswordForm) {
+        this.$refs[editPasswordForm].validate(valid => {
+          if (valid) {
             this.result = this.$post(this.editPasswordPath, this.ruleForm, response => {
               this.$success(this.$t('commons.modify_success'));
               this.editPasswordVisible = false;
@@ -290,6 +304,15 @@
           let data = response.data;
           this.total = data.itemCount;
           this.tableData = data.listObject;
+          let url = "/user/special/user/role";
+          for (let i = 0; i < this.tableData.length; i++) {
+            this.$get(url + '/' + this.tableData[i].id, result => {
+              let data = result.data;
+              let roles = data.roles;
+              // let userRoles = result.userRoles;
+              this.$set(this.tableData[i], "roles", roles);
+            })
+          }
         })
       },
       handleClose() {

From b65e327588cf1968ed982cbcbb588ea488207707 Mon Sep 17 00:00:00 2001
From: shiziyuan9527 <yuhao.li@fit2cloud.com>
Date: Tue, 19 May 2020 16:32:16 +0800
Subject: [PATCH 2/3] =?UTF-8?q?=E5=88=A0=E9=99=A4=E6=97=A0=E7=94=A8?=
 =?UTF-8?q?=E4=BB=A3=E7=A0=81?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../components/settings/system/User.vue       | 34 -------------------
 1 file changed, 34 deletions(-)

diff --git a/frontend/src/business/components/settings/system/User.vue b/frontend/src/business/components/settings/system/User.vue
index 1ddb27b04a..ef1a8becf2 100644
--- a/frontend/src/business/components/settings/system/User.vue
+++ b/frontend/src/business/components/settings/system/User.vue
@@ -48,21 +48,6 @@
                            :total="total"/>
     </el-card>
 
-    <el-dialog :title="$t('commons.verification')" :visible.sync="checkPasswordVisible" width="30%"
-               @close="closeCheckPassword" :destroy-on-close="true">
-      <el-form :model="checkPasswordForm" label-position="right" label-width="100px" size="small" :rules="rule"
-               ref="checkPasswordForm">
-        <el-form-item :label="$t('commons.password')" prop="password">
-          <el-input type="password" v-model="checkPasswordForm.password" autocomplete="off" show-password></el-input>
-        </el-form-item>
-      </el-form>
-      <template v-slot:footer>
-        <ms-dialog-footer
-          @cancel="checkPasswordVisible = false"
-          @confirm="setAdmin('checkPasswordForm')"/>
-      </template>
-    </el-dialog>
-
     <!--Create user-->
     <el-dialog :title="$t('user.create')" :visible.sync="createVisible" width="30%" @closed="handleClose"
                :destroy-on-close="true">
@@ -166,7 +151,6 @@
         createVisible: false,
         updateVisible: false,
         editPasswordVisible: false,
-        checkPasswordVisible: false,
         multipleSelection: [],
         currentPage: 1,
         pageSize: 5,
@@ -328,24 +312,6 @@
       },
       handleSelectionChange(val) {
         this.multipleSelection = val;
-      },
-      closeCheckPassword() {
-        this.checkPasswordForm = {};
-      },
-      setAdmin(checkPasswordForm) {
-        let user = getCurrentUser();
-        this.$set(this.setAdminParam, 'adminId', user.id);
-        this.$set(this.setAdminParam, 'password', this.checkPasswordForm.password);
-        this.$refs[checkPasswordForm].validate(valid => {
-          if (valid) {
-            this.$post("/user/set/admin", this.setAdminParam, () => {
-              this.$success(this.$t('commons.modify_success'));
-              this.checkPasswordVisible = false;
-            })
-          } else {
-            return false;
-          }
-        })
       }
     }
   }

From c1eb7cc3febaefe6c22dbf536e012796654d93f6 Mon Sep 17 00:00:00 2001
From: q4speed <kun@fit2cloud.com>
Date: Tue, 19 May 2020 17:47:50 +0800
Subject: [PATCH 3/3] =?UTF-8?q?=E5=90=8D=E5=AD=97=E5=81=9A=E9=93=BE?=
 =?UTF-8?q?=E6=8E=A5?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../src/business/components/api/report/ApiReportList.vue    | 6 +++++-
 frontend/src/business/components/api/test/ApiTestList.vue   | 5 ++++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/frontend/src/business/components/api/report/ApiReportList.vue b/frontend/src/business/components/api/report/ApiReportList.vue
index 1dbab837b0..5af0422595 100644
--- a/frontend/src/business/components/api/report/ApiReportList.vue
+++ b/frontend/src/business/components/api/report/ApiReportList.vue
@@ -7,7 +7,11 @@
                            :show-create="false"/>
         </template>
         <el-table :data="tableData" class="table-content">
-          <el-table-column prop="name" :label="$t('commons.name')" width="200" show-overflow-tooltip/>
+          <el-table-column :label="$t('commons.name')" width="200" show-overflow-tooltip>
+            <template v-slot:default="scope">
+              <el-link type="info" @click="handleView(scope.row)">{{ scope.row.name }}</el-link>
+            </template>
+          </el-table-column>
           <el-table-column prop="testName" :label="$t('api_report.test_name')" width="200" show-overflow-tooltip/>
           <el-table-column width="250" :label="$t('commons.create_time')">
             <template v-slot:default="scope">
diff --git a/frontend/src/business/components/api/test/ApiTestList.vue b/frontend/src/business/components/api/test/ApiTestList.vue
index f5ecb7edf8..a6cce7e191 100644
--- a/frontend/src/business/components/api/test/ApiTestList.vue
+++ b/frontend/src/business/components/api/test/ApiTestList.vue
@@ -7,7 +7,10 @@
                            @create="create" :createTip="$t('load_test.create')"/>
         </template>
         <el-table :data="tableData" class="table-content">
-          <el-table-column prop="name" :label="$t('commons.name')" width="150" show-overflow-tooltip>
+          <el-table-column :label="$t('commons.name')" width="150" show-overflow-tooltip>
+            <template v-slot:default="scope">
+              <el-link type="info" @click="handleEdit(scope.row)">{{ scope.row.name }}</el-link>
+            </template>
           </el-table-column>
           <el-table-column prop="projectName" :label="$t('load_test.project_name')" width="150" show-overflow-tooltip>
           </el-table-column>